Uh oh!
There was an error while loading. Please reload this page.
Add workflow CFG visualization to observability UI - #456
Conversation
🦋 Changeset detectedLatest commit: 986e07e The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@karthikscale3 is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
VaguelySerious
left a comment
There was a problem hiding this comment.
This looks great too! Since #455 might take a bit, and this PR has a lot of UI polish that we could merge already without necessarily adding the flow graph, while also being prone to merge conflicts for UI work.
Some options:
- We hide the UI that isn't complete yet (due to dependency on #455)
- We split this PR into graph-related and non-graph-related changes, and merge the latter without having to wait for the former.
- We leave this PR as is and wait for iteration on #455 and then alter resolve merge conflicts for UI code changes in the meantime
I'd prefer 1 or 2. If you're doing one, could I ask you to:
- Comment out the
TabsTriggerfor "Workflows" - Comment out the
TabsListused inrun-detail-view.tsx - Move all the files related to graphs in
web/src/libinto a subfolderweb/src/lib/experimental-graphs - Ensure DCO passes
and then we can merge this, and you can iterate on the graph solution separately in #455.
Later on, we want to store and fetch manifests from World storage, according to the version spec, but I don't why that has to block this PR in the meantime
karthikscale3
commented
Dec 2, 2025
Thanks for the review @VaguelySerious ! I made a round of updates to #455 and made the corresponding changes to this one too. I will wait for a day to see if #455 moves. If not, I will go ahead with 1. and update this PR accordingly. Will keep you posted. |
…/workflow-cfg-rendering
There was a problem hiding this comment.
Additional Suggestion:
The BackLink component is imported from ./display-utils/back-link, but this file was deleted in this PR. This will cause a compilation error.
View Details
📝 Patch Details
diff --git a/packages/web/src/components/display-utils/back-link.tsx b/packages/web/src/components/display-utils/back-link.tsx
new file mode 100644
index 0000000..6e2ebe0
--- /dev/null+++ b/packages/web/src/components/display-utils/back-link.tsx@@ -0,0 +1,21 @@+'use client';++import { ArrowLeft } from 'lucide-react';+import Link from 'next/link';++interface BackLinkProps {+ href: string;+ label?: string;+}++export function BackLink({ href, label = 'Back' }: BackLinkProps) {+ return (+ <Link+ href={href}+ className="inline-flex items-center gap-2 text-sm text-muted-foreground hover:text-foreground transition-colors mb-2"+ >+ <ArrowLeft className="h-4 w-4" />+ {label}+ </Link>+ );+}Analysis
Missing BackLink component causes build failure in StreamDetailView
What fails:stream-detail-view.tsx imports BackLink component from ./display-utils/back-link, but the file was deleted in commit 89c7721 ("Workflow CFG Viewer and nuqs migration"), causing a module resolution error during build.
How to reproduce:
cd packages/web
pnpm install
pnpm run buildResult: Build fails with error:
Module not found: Can't resolve './display-utils/back-link'
at packages/web/src/components/stream-detail-view.tsx:9:1
Expected: Build should succeed. The BackLink component is actively used on line 115 of stream-detail-view.tsx to render a navigation link with an arrow icon for navigating back from the stream detail view.
Fix: Restored packages/web/src/components/display-utils/back-link.tsx which was inadvertently deleted. The component provides a styled navigation link with an ArrowLeft icon from lucide-react, which is essential for stream detail view navigation.
…/workflow-cfg-rendering
I, Karthik Kalyanaraman <karthik@scale3labs.com>, hereby add my Signed-off-by to this commit: ef9e5e4 I, Karthik Kalyanaraman <karthik@scale3labs.com>, hereby add my Signed-off-by to this commit: c7d3256 I, Karthik Kalyanaraman <karthik@scale3labs.com>, hereby add my Signed-off-by to this commit: b561f40 I, Karthik Kalyanaraman <karthik@scale3labs.com>, hereby add my Signed-off-by to this commit: 6c51f45 I, Karthik Kalyanaraman <karthik@scale3labs.com>, hereby add my Signed-off-by to this commit: 89c7721 I, Karthik Kalyanaraman <karthik@scale3labs.com>, hereby add my Signed-off-by to this commit: 6d7cb0e I, Karthik Kalyanaraman <karthik@scale3labs.com>, hereby add my Signed-off-by to this commit: e018221 Signed-off-by: Karthik Kalyanaraman <karthik@scale3labs.com>
@VaguelySerious - I went with Option 1 and updated this PR by commenting out the parts that depend on #455 . Also made sure DCO passes in this one as well. Please take a look when you get a chance and let me know if it looks good. I will uncomment the changes related to #455 and make a separate PR after #455 merges. Thanks again |
karthikscale3
commented
Dec 5, 2025
This has been fixed |
VaguelySerious
left a comment
There was a problem hiding this comment.
This looks great! The changeset is slightly off. I might merge this and fix in a follow-up, but if you have a chance to accept the change, that'd be easier
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Peter Wielander <mittgfu@gmail.com>
karthikscale3
commented
Dec 5, 2025
Good catch! Sorry my bad! Accepted it. |
Uh oh!
There was an error while loading. Please reload this page.
The repro app at runtime needs to reach workflow-server-7pxaxn4d4.vercel.sh (preview of Pranay's monotonic-append PR #456) which has Vercel Deployment Protection enabled. PR #1882 removed the explicit-bypass-token flow in favor of OIDC trusted-sources, but trusted-sources only works for GitHub-Actions-issued OIDC tokens — not for tokens minted inside a customer Vercel deployment. Re-add WORKFLOW_VERCEL_PROTECTION_BYPASS support on the direct (non-proxy) path: if set, attach x-vercel-protection-bypass and x-vercel-set-bypass-cookie headers on every outbound workflow-server request. Diagnostic-only; not for production.
Note: This PR is related to #455
Adds a new "Workflows" tab to the observability dashboard that displays workflow definitions with interactive graph visualization.
Changes
@workflow/web-shared: AddfetchWorkflowsManifestserver action to read theworkflows.jsonmanifest generated by the build process@workflow/web: AdduseWorkflowGraphManifesthook for fetching workflow graph data@workflow/web: Add "Workflows" tab to the main page displaying all registered workflows@workflow/web: AddWorkflowsListcomponent with table view and slide-out graph viewerFeatures