Uh oh!
There was an error while loading. Please reload this page.
[world-local] Bump undici dependency to latest minor version - #568
Merged
Conversation
🦋 Changeset detectedLatest commit: ea78785 The changes in this PR will be included in the next version bump. This PR includes changesets to release 14 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
🧪 E2E Test Results❌ Some tests failed Summary
❌ Failed Tests▲ Vercel Production (50 failed)nextjs-turbopack (25 failed):
nextjs-webpack (25 failed):
🌍 Community Worlds (11 failed)mongodb (1 failed):
redis (1 failed):
starter (8 failed):
turso (1 failed):
Details by Category❌ ▲ Vercel Production
✅ 💻 Local Development
✅ 📦 Local Production
✅ 🐘 Local Postgres
✅ 🪟 Windows
❌ 🌍 Community Worlds
❌ Some E2E test jobs failed:
Check the workflow run for details. |
Contributor
📊 Benchmark Results
workflow with no steps💻 Local Development
▲ Production (Vercel)
workflow with 1 step💻 Local Development
▲ Production (Vercel)
workflow with 10 sequential steps💻 Local Development
▲ Production (Vercel)
workflow with 10 parallel steps💻 Local Development
▲ Production (Vercel)
stress test: Promise.all with 100 concurrent steps💻 Local Development
▲ Production (Vercel)
stress test: Promise.race with 100 concurrent steps💻 Local Development
▲ Production (Vercel)
Stream Benchmarks(includes TTFB metrics)workflow with stream💻 Local Development
▲ Production (Vercel)
SummaryFastest Framework by WorldWinner determined by most benchmark wins
Fastest World by FrameworkWinner determined by most benchmark wins
Column Definitions
Worlds:
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Contributor
There was a problem hiding this comment.
🔧 Build Fix:
An unused @ts-expect-error directive is causing TypeScript compilation to fail. The directive suppresses a type error that no longer exists due to improved type compatibility between the Fetch API and undici types.
View Details
📝 Patch Details
diff --git a/packages/world-local/src/queue.ts b/packages/world-local/src/queue.ts
index 229e1b0..c55eec8 100644
--- a/packages/world-local/src/queue.ts+++ b/packages/world-local/src/queue.ts@@ -91,7 +91,6 @@ export function createQueue(config: Partial<Config>): Queue {
{
method: 'POST',
duplex: 'half',
- // @ts-expect-error undici type differences
dispatcher: httpAgent,
headers: {
'content-type': 'application/json',
Analysis
Unused @ts-expect-error directive in queue.ts
What fails: TypeScript compilation fails with error TS2578: "Unused '@ts-expect-error' directive" in packages/world-local/src/queue.ts at line 94.
How to reproduce:
pnpm exec turbo run build --filter='@workflow/world-local'Result:
src/queue.ts(94,15): error TS2578: Unused '@ts-expect-error' directive.
Fix: Removed the unused @ts-expect-error comment on line 93. The comment was suppressing a type error that no longer exists due to improved type compatibility between the Fetch API and undici types in newer versions of TypeScript.
Contributor
There was a problem hiding this comment.
🔧 Build Fix:
The @ts-expect-error comment on line 93 is no longer needed because TypeScript can now properly type the dispatcher property in the fetch options. This unused directive causes the build to fail with a TypeScript error when strict checking is enabled.
View Details
📝 Patch Details
diff --git a/packages/world-local/src/queue.ts b/packages/world-local/src/queue.ts
index 229e1b0..c55eec8 100644
--- a/packages/world-local/src/queue.ts+++ b/packages/world-local/src/queue.ts@@ -91,7 +91,6 @@ export function createQueue(config: Partial<Config>): Queue {
{
method: 'POST',
duplex: 'half',
- // @ts-expect-error undici type differences
dispatcher: httpAgent,
headers: {
'content-type': 'application/json',
Analysis
Unused @ts-expect-error directive causes TypeScript compilation failure
What fails: TypeScript compiler fails on packages/world-local/src/queue.ts due to an unused @ts-expect-error directive that is no longer needed
How to reproduce:
pnpm turbo run build --filter='@workflow/world-local'Result:
src/queue.ts(94,15): error TS2578: Unused '@ts-expect-error' directive.
Root cause: The dispatcher property in the fetch options now has proper type definitions in the undici/fetch types, so the TypeScript error that the directive was suppressing no longer occurs. This causes TypeScript to report the directive as unused when noUnusedDirectives or similar strict checking is enabled.
pranaygp
approved these changes
Dec 7, 2025
pranaygp
commented
Dec 7, 2025
Contributor
all builds are failing @VaguelySerious |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current
undiciversion gets reported as vulnerable to request tampering, though this doesn't affect us (since it's the local world, and also running on the backend), but patching this to reduce dependabot noise for users