Uh oh!
There was an error while loading. Please reload this page.
Compile release note summaries using custom script in CI - #637
Merged
Conversation
🦋 Changeset detectedLatest commit: 35b21c9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
📊 Benchmark Results
workflow with no steps💻 Local Development
▲ Production (Vercel)
workflow with 1 step💻 Local Development
▲ Production (Vercel)
workflow with 10 sequential steps💻 Local Development
▲ Production (Vercel)
workflow with 10 parallel steps💻 Local Development
▲ Production (Vercel)
stress test: Promise.all with 100 concurrent steps💻 Local Development
▲ Production (Vercel)
stress test: Promise.race with 100 concurrent steps💻 Local Development
▲ Production (Vercel)
Stream Benchmarks(includes TTFB metrics)workflow with stream💻 Local Development
▲ Production (Vercel)
SummaryFastest Framework by WorldWinner determined by most benchmark wins
Fastest World by FrameworkWinner determined by most benchmark wins
Column Definitions
Worlds:
❌ Some benchmark jobs failed:
Check the workflow run for details. |
Contributor
🧪 E2E Test Results❌ Some tests failed Summary
❌ Failed Tests▲ Vercel Production (10 failed)nextjs-turbopack (8 failed):
nuxt (1 failed):
sveltekit (1 failed):
🌍 Community Worlds (11 failed)mongodb (1 failed):
redis (1 failed):
starter (8 failed):
turso (1 failed):
Details by Category❌ ▲ Vercel Production
✅ 💻 Local Development
✅ 📦 Local Production
✅ 🐘 Local Postgres
✅ 🪟 Windows
❌ 🌍 Community Worlds
❌ Some E2E test jobs failed:
Check the workflow run for details. |
TooTallNate
approved these changes
Dec 17, 2025
| --title "$TITLE" \ | ||
| --notes "$BODY" \ | ||
| --latest \ | ||
| --prerelease=false |
Contributor
There was a problem hiding this comment.
The workflow hardcodes --prerelease=false for all releases, but beta versions like 4.0.1-beta.28 should be marked as prerelease versions with --prerelease=true.
View Details
📝 Patch Details
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
index e20facf..80036ac 100644
--- a/.github/workflows/release.yml+++ b/.github/workflows/release.yml@@ -58,6 +58,7 @@ jobs:
TAG=$(echo "$RELEASE_JSON" | jq -r '.tag')
TITLE=$(echo "$RELEASE_JSON" | jq -r '.title')
BODY=$(echo "$RELEASE_JSON" | jq -r '.body')
+ IS_PRERELEASE=$(echo "$RELEASE_JSON" | jq -r '.isPrerelease')
# Check if a release with this tag already exists
if gh release view "$TAG" &>/dev/null; then
@@ -66,12 +67,12 @@ jobs:
--title "$TITLE" \
--notes "$BODY" \
--latest \
- --prerelease=false+ --prerelease="$IS_PRERELEASE"
else
echo "Creating new release $TAG..."
gh release create "$TAG" \
--title "$TITLE" \
--notes "$BODY" \
--latest \
- --prerelease=false+ --prerelease="$IS_PRERELEASE"
fi
diff --git a/scripts/generate-release-notes.mjs b/scripts/generate-release-notes.mjs
index ac98248..21ad0e5 100644
--- a/scripts/generate-release-notes.mjs+++ b/scripts/generate-release-notes.mjs@@ -216,10 +216,14 @@ function generateReleaseNotes() {
'This release contains dependency updates and internal improvements.';
}
+ // Detect if this is a prerelease version (contains hyphen per semantic versioning)+ const isPrerelease = workflowVersion.includes('-');+
const result = {
tag: `workflow@${workflowVersion}`,
title: `workflow@${workflowVersion}`,
body,
+ isPrerelease,
};
console.log(JSON.stringify(result, null, 2));
Analysis
GitHub workflow hardcodes prerelease=false for all releases, incorrectly marking beta versions as stable
What fails: The release workflow in .github/workflows/release.yml (lines 69, 76) hardcodes --prerelease=false regardless of version, causing prerelease versions like 4.0.1-beta.32 to be marked as stable releases in GitHub.
How to reproduce:
- Check
packages/workflow/package.json- current version is4.0.1-beta.32 - When release workflow runs and creates a GitHub release, it uses
gh release createwith--prerelease=false - The release appears in GitHub as a stable release instead of a prerelease
Result: Beta, alpha, and RC versions appear in GitHub as stable releases. Users viewing releases see 4.0.1-beta.32 marked as a full release, not a prerelease.
Expected: Per semantic versioning specification, versions containing hyphens (e.g., 4.0.1-beta.32, 1.0.0-alpha.1, 2.0.0-rc.1) are prerelease versions and should be marked with --prerelease=true. The GitHub REST API documentation confirms that prerelease: true identifies a release as a prerelease.
Fix: Modified scripts/generate-release-notes.mjs to detect prerelease status (version contains hyphen) and include isPrerelease field in JSON output. Updated .github/workflows/release.yml to use this field instead of hardcoded --prerelease=false.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creates a single release/tag that summarizes all the package changes in a single release, looks like this:
workflow@4.0.1-beta.28
@workflow/core@4.0.1-beta.27
b56aae3@copilot-swe-agent - [core] Override setTimeout, setInterval, and related functions in workflow VM context to throw helpful errors suggesting to usesleepinstead@workflow/world-vercel@4.0.1-beta.25
deaf019@VaguelySerious - [world-vercel] Allow skipping vercel backend proxy for e2e tests where CLI runs in runtime env