Uh oh!
There was an error while loading. Please reload this page.
Fix race conditions in webhook response handling - #672
Merged
TooTallNate merged 1 commit intoDec 22, 2025
Conversation
🦋 Changeset detectedLatest commit: e764695 The changes in this PR will be included in the next version bump. This PR includes changesets to release 14 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
🧪 E2E Test Results❌ Some tests failed Summary
❌ Failed Tests🌍 Community Worlds (10 failed)mongodb (1 failed):
starter (8 failed):
turso (1 failed):
Details by Category✅ ▲ Vercel Production
✅ 💻 Local Development
✅ 📦 Local Production
✅ 🐘 Local Postgres
✅ 🪟 Windows
❌ 🌍 Community Worlds
|
MemberAuthor
This stack of pull requests is managed by Graphite. Learn more about stacking. |
TooTallNateforce-pushed
the
12-22-fix_race_conditions_in_webhook_response_handling
branch
from
December 22, 2025 08:20
74ec92d to
2f9461fCompareTooTallNate
changed the base branch from
12-20-fix_stream_serialization_to_resolve_when_user_releases_lock_instead_of_waiting_for_stream_to_close
to
graphite-base/672December 22, 2025 08:20
TooTallNateforce-pushed
the
graphite-base/672
branch
from
December 22, 2025 08:20
2d007e6 to
88ad5c9CompareTooTallNateforce-pushed
the
12-22-fix_race_conditions_in_webhook_response_handling
branch
from
December 22, 2025 08:20
2f9461f to
e764695CompareContributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a race condition in the streamer's readFromStream method where close events arriving during disk reads would immediately close the ReadableStream controller before all data was enqueued, potentially causing data loss.
Key changes:
- Added a
pendingCloseflag to buffer close events that arrive while reading from disk - Modified
closeListenerto set the flag instead of closing immediately when disk reads are in progress - Added logic to process buffered close events after disk reads and buffered event chunks are processed
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/world-local/src/streamer.ts | Implements the race condition fix by buffering close events during disk reads and processing them after disk reading completes |
| .changeset/webhook-response-body-fix.md | Documents the fix for the changeset |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
VaguelySerious
approved these changes
Dec 22, 2025
Uh oh!
There was an error while loading. Please reload this page.
TooTallNate
deleted the
12-22-fix_race_conditions_in_webhook_response_handling
branch
December 22, 2025 18:41
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed a race condition in the streamer where close events could arrive during disk reads, causing premature controller closure. This fixes the flakiness in the
webhookWorkflowE2E test on "local" test suites.What changed?
pendingCloseflag to buffer close events that arrive during disk readingcloseListenerfunction to set this flag instead of immediately closing the controller when disk reads are in progressWhy make this change?
There was a race condition in the streamer where close events arriving during disk reads would close the controller before all data was enqueued. This could lead to incomplete data streams and potential data loss. This fix ensures that all data is properly processed before the stream is closed.