Uh oh!
There was an error while loading. Please reload this page.
Step queue write idempotency - #776
Merged
Merged
Conversation
This fixes a race condition where: 1. Step is written to workflow database 2. Process crashes/times out before queue write completes 3. Upstream retry occurs 4. Step already exists (409), so queue write was skipped 5. Step sits pending forever with 0 attempts The queue write already uses an idempotency key (correlation ID), so duplicate writes are safely deduplicated by the queue service.
Cursor Agent can help with this pull request. Just |
Contributor
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
🦋 Changeset detectedLatest commit: 967c489 The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
🧪 E2E Test Results❌ Some tests failed Summary
❌ Failed Tests🌍 Community Worlds (16 failed)mongodb (1 failed):
starter (14 failed):
turso (1 failed):
Details by Category✅ ▲ Vercel Production
✅ 💻 Local Development
✅ 📦 Local Production
✅ 🐘 Local Postgres
✅ 🪟 Windows
❌ 🌍 Community Worlds
|
Contributor
📊 Benchmark Results
workflow with no steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Nitro | Next.js (Turbopack) workflow with 1 step💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Next.js (Turbopack) | Express workflow with 10 sequential steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Nitro | Express Promise.all with 10 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Express | Next.js (Turbopack) Promise.all with 25 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Express | Next.js (Turbopack) Promise.race with 10 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Nitro | Next.js (Turbopack) Promise.race with 25 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Express | Next.js (Turbopack) Stream Benchmarks(includes TTFB metrics)workflow with stream💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Express | Next.js (Turbopack) SummaryFastest Framework by WorldWinner determined by most benchmark wins
Fastest World by FrameworkWinner determined by most benchmark wins
Column Definitions
Worlds:
|
The ops array was leftover from a previous refactor that used to collect promises for parallel execution. Nothing was ever pushed to it, making the waitUntil(Promise.all(ops)) a no-op.
Timer
marked this pull request as ready for review
January 13, 2026 21:28
I, Cursor Agent <cursoragent@cursor.com>, hereby add my Signed-off-by to this commit: 6e510f7 I, Cursor Agent <cursoragent@cursor.com>, hereby add my Signed-off-by to this commit: 5394d49 I, Cursor Agent <cursoragent@cursor.com>, hereby add my Signed-off-by to this commit: 23424ff Signed-off-by: Cursor Agent <cursoragent@cursor.com>
Comment on lines
-119
to
-127
| waitUntil( | ||
| Promise.all(ops).catch((opErr) => { | ||
| // Ignore expected client disconnect errors (e.g., browser refresh during streaming) | ||
| const isAbortError = | ||
| opErr?.name === 'AbortError' || opErr?.name === 'ResponseAborted'; | ||
| if (!isAbortError) throw opErr; | ||
| }) | ||
| ); | ||
Contributor
There was a problem hiding this comment.
will simplify this after event sourcing ( #621 ) but need to keep it in for now
Contributor
There was a problem hiding this comment.
hmm wait maybe Cursor is right and this is dead code since e2e tests are passing
TooTallNate
approved these changes
Jan 13, 2026
Uh oh!
There was an error while loading. Please reload this page.
Merged
VaguelySerious pushed a commit
that referenced
this pull request
Jan 16, 2026
* fix(core): always write step to queue even if step already exists This fixes a race condition where: 1. Step is written to workflow database 2. Process crashes/times out before queue write completes 3. Upstream retry occurs 4. Step already exists (409), so queue write was skipped 5. Step sits pending forever with 0 attempts The queue write already uses an idempotency key (correlation ID), so duplicate writes are safely deduplicated by the queue service. * chore: add changeset for step queue idempotency fix * chore(core): remove dead ops array code from processStep The ops array was leftover from a previous refactor that used to collect promises for parallel execution. Nothing was ever pushed to it, making the waitUntil(Promise.all(ops)) a no-op. * DCO Remediation Commit for Cursor Agent <cursoragent@cursor.com> I, Cursor Agent <cursoragent@cursor.com>, hereby add my Signed-off-by to this commit: 6e510f7 I, Cursor Agent <cursoragent@cursor.com>, hereby add my Signed-off-by to this commit: 5394d49 I, Cursor Agent <cursoragent@cursor.com>, hereby add my Signed-off-by to this commit: 23424ff Signed-off-by: Cursor Agent <cursoragent@cursor.com> --------- Signed-off-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: Cursor Agent <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a race condition where a workflow step could get stuck in a "pending" state indefinitely.
Previously, if a process crashed after creating a step in the database but before queuing it for execution, subsequent retries would encounter a 409 conflict (step already exists) and skip the queue write. This left the step pending with 0 attempts.
The fix ensures that the step is always written to the execution queue, even if it already exists in the database. The queue write uses an idempotency key (
correlationId), so duplicate queue messages are safely handled by the queue service. Detailed comments have been added to explain this critical behavior.How did you test your changes?
@workflow/corepackage locally.@workflow/corepackage, which passed successfully.@workflow/corepackage.PR Checklist - Required to merge
pnpm changesetwas run to create a changelog for this PRpnpm changeset --emptyif you are changing documentation or workbench appsgit commit --signoffon your commits)Slack Thread