Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/forty-tables-lick.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
---
"@workflow/web-shared": patch
"@workflow/core": patch
---

Show custom class serialization UI and class names in o11y
369 changes: 369 additions & 0 deletions packages/core/src/observability.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,369 @@
import { inspect } from 'node:util';
import { WORKFLOW_DESERIALIZE, WORKFLOW_SERIALIZE } from '@workflow/serde';
import { describe, expect, it } from 'vitest';
import { registerSerializationClass } from './class-serialization.js';
import {
CLASS_INSTANCE_REF_TYPE,
ClassInstanceRef,
extractStreamIds,
hydrateResourceIO,
isClassInstanceRef,
isStreamId,
isStreamRef,
STREAM_REF_TYPE,
truncateId,
} from './observability.js';
import { dehydrateStepReturnValue } from './serialization.js';

describe('ClassInstanceRef', () => {
describe('constructor and properties', () => {
it('should create instance with correct properties', () => {
const ref = new ClassInstanceRef('Point', 'class//file.ts//Point', {
x: 1,
y: 2,
});

expect(ref.className).toBe('Point');
expect(ref.classId).toBe('class//file.ts//Point');
expect(ref.data).toEqual({ x: 1, y: 2 });
expect(ref.__type).toBe(CLASS_INSTANCE_REF_TYPE);
});

it('should handle various data types', () => {
// Object data
const objRef = new ClassInstanceRef('Config', 'class//Config', {
key: 'value',
});
expect(objRef.data).toEqual({ key: 'value' });

// String data
const strRef = new ClassInstanceRef('Token', 'class//Token', 'abc123');
expect(strRef.data).toBe('abc123');

// Number data
const numRef = new ClassInstanceRef('Counter', 'class//Counter', 42);
expect(numRef.data).toBe(42);

// Null data
const nullRef = new ClassInstanceRef('Empty', 'class//Empty', null);
expect(nullRef.data).toBeNull();

// Array data
const arrRef = new ClassInstanceRef('List', 'class//List', [1, 2, 3]);
expect(arrRef.data).toEqual([1, 2, 3]);
});
});

describe('toJSON()', () => {
it('should return plain object representation', () => {
const ref = new ClassInstanceRef('Point', 'class//file.ts//Point', {
x: 1,
y: 2,
});

expect(ref.toJSON()).toEqual({
__type: CLASS_INSTANCE_REF_TYPE,
className: 'Point',
classId: 'class//file.ts//Point',
data: { x: 1, y: 2 },
});
});

it('should be used by JSON.stringify', () => {
const ref = new ClassInstanceRef('Point', 'class//file.ts//Point', {
x: 1,
y: 2,
});

const json = JSON.stringify(ref);
const parsed = JSON.parse(json);

expect(parsed).toEqual({
__type: CLASS_INSTANCE_REF_TYPE,
className: 'Point',
classId: 'class//file.ts//Point',
data: { x: 1, y: 2 },
});
});
});

describe('[inspect.custom]', () => {
it('should render as ClassName@filename { data }', () => {
const ref = new ClassInstanceRef(
'Point',
'class//workflows/user-signup.ts//Point',
{ x: 1, y: 2 }
);

const output = inspect(ref, { colors: false });
expect(output).toBe('Point@user-signup.ts { x: 1, y: 2 }');
});

it('should handle nested file paths', () => {
const ref = new ClassInstanceRef(
'Config',
'class//lib/models/config.ts//Config',
{ nested: { a: 1, b: 2 } }
);

const output = inspect(ref, { colors: false });
expect(output).toBe('Config@config.ts { nested: { a: 1, b: 2 } }');
});

it('should handle string data', () => {
const ref = new ClassInstanceRef(
'Token',
'class//auth/token.ts//Token',
'secret'
);

const output = inspect(ref, { colors: false });
expect(output).toBe("Token@token.ts 'secret'");
});

it('should handle null data', () => {
const ref = new ClassInstanceRef(
'Empty',
'class//utils/empty.ts//Empty',
null
);

const output = inspect(ref, { colors: false });
expect(output).toBe('Empty@empty.ts null');
});

it('should handle array data', () => {
const ref = new ClassInstanceRef(
'List',
'class//collections/list.ts//List',
[1, 2, 3]
);

const output = inspect(ref, { colors: false });
expect(output).toBe('List@list.ts [ 1, 2, 3 ]');
});

it('should handle simple classId format gracefully', () => {
// Fallback for non-standard classId format
const ref = new ClassInstanceRef('Point', 'test//TestPoint', {
x: 1,
y: 2,
});

const output = inspect(ref, { colors: false });
// Falls back to extracting just the last segment as filename
expect(output).toBe('Point@TestPoint { x: 1, y: 2 }');
});

it('should style @filename gray when colors are enabled', () => {
const ref = new ClassInstanceRef(
'Point',
'class//workflows/point.ts//Point',
{ x: 1, y: 2 }
);

const output = inspect(ref, { colors: true });
// When colors are enabled, the @filename should have ANSI escape codes
expect(output).toContain('Point');
// Check for ANSI escape codes (gray/dim styling for @filename)
expect(output).toMatch(/\x1b\[90m@point\.ts\x1b\[39m/);
// Data is also present (may have color codes for numbers)
expect(output).toContain('x:');
expect(output).toContain('y:');
});
});
});

describe('isClassInstanceRef', () => {
it('should return true for ClassInstanceRef instances', () => {
const ref = new ClassInstanceRef('Point', 'class//Point', { x: 1, y: 2 });
expect(isClassInstanceRef(ref)).toBe(true);
});

it('should return true for plain objects with correct structure', () => {
const plainObj = {
__type: CLASS_INSTANCE_REF_TYPE,
className: 'Point',
classId: 'class//Point',
data: { x: 1, y: 2 },
};
expect(isClassInstanceRef(plainObj)).toBe(true);
});

it('should return true for JSON-parsed ClassInstanceRef', () => {
const ref = new ClassInstanceRef('Point', 'class//Point', { x: 1, y: 2 });
const parsed = JSON.parse(JSON.stringify(ref));
expect(isClassInstanceRef(parsed)).toBe(true);
});

it('should return false for null', () => {
expect(isClassInstanceRef(null)).toBe(false);
});

it('should return false for undefined', () => {
expect(isClassInstanceRef(undefined)).toBe(false);
});

it('should return false for plain objects without __type', () => {
expect(isClassInstanceRef({ className: 'Point', data: {} })).toBe(false);
});

it('should return false for objects with wrong __type', () => {
expect(
isClassInstanceRef({
__type: 'wrong_type',
className: 'Point',
data: {},
})
).toBe(false);
});

it('should return false for objects without className', () => {
expect(
isClassInstanceRef({
__type: CLASS_INSTANCE_REF_TYPE,
classId: 'class//Point',
data: {},
})
).toBe(false);
});
});

describe('isStreamRef', () => {
it('should return true for valid StreamRef', () => {
const streamRef = {
__type: STREAM_REF_TYPE,
streamId: 'strm_123',
};
expect(isStreamRef(streamRef)).toBe(true);
});

it('should return false for null', () => {
expect(isStreamRef(null)).toBe(false);
});

it('should return false for wrong __type', () => {
expect(isStreamRef({ __type: 'wrong', streamId: 'strm_123' })).toBe(false);
});
});

describe('isStreamId', () => {
it('should return true for valid stream ID', () => {
expect(isStreamId('strm_abc123')).toBe(true);
});

it('should return false for non-stream strings', () => {
expect(isStreamId('not_a_stream')).toBe(false);
});

it('should return false for non-strings', () => {
expect(isStreamId(123)).toBe(false);
expect(isStreamId(null)).toBe(false);
expect(isStreamId({})).toBe(false);
});
});

describe('extractStreamIds', () => {
it('should extract stream IDs from flat objects', () => {
const obj = { stream: 'strm_123', other: 'not_stream' };
expect(extractStreamIds(obj)).toEqual(['strm_123']);
});

it('should extract stream IDs from nested objects', () => {
const obj = {
level1: {
level2: {
stream: 'strm_abc',
},
},
};
expect(extractStreamIds(obj)).toEqual(['strm_abc']);
});

it('should extract stream IDs from arrays', () => {
const arr = ['strm_1', 'strm_2', 'not_stream'];
expect(extractStreamIds(arr)).toEqual(['strm_1', 'strm_2']);
});

it('should deduplicate stream IDs', () => {
const obj = { a: 'strm_same', b: 'strm_same' };
expect(extractStreamIds(obj)).toEqual(['strm_same']);
});

it('should return empty array for no streams', () => {
expect(extractStreamIds({ foo: 'bar' })).toEqual([]);
});
});

describe('truncateId', () => {
it('should not truncate short IDs', () => {
expect(truncateId('short', 12)).toBe('short');
});

it('should truncate long IDs', () => {
expect(truncateId('verylongidentifier', 12)).toBe('verylongiden...');
});

it('should use default max length of 12', () => {
expect(truncateId('123456789012')).toBe('123456789012');
expect(truncateId('1234567890123')).toBe('123456789012...');
});
});

describe('hydrateResourceIO with custom class instances', () => {
// Create a test class with serialization symbols
class TestPoint {
constructor(
public x: number,
public y: number
) {}

static [WORKFLOW_SERIALIZE](instance: TestPoint) {
return { x: instance.x, y: instance.y };
}

static [WORKFLOW_DESERIALIZE](data: { x: number; y: number }) {
return new TestPoint(data.x, data.y);
}
}

// Register the class for serialization (so dehydrate works)
// but note: in o11y context, classes are NOT registered, which is the point of this test
(TestPoint as any).classId = 'test//TestPoint';
registerSerializationClass('test//TestPoint', TestPoint);

it('should convert Instance type to ClassInstanceRef in step output', () => {
// Simulate serialized step data with a custom class instance
const point = new TestPoint(3, 4);
const serialized = dehydrateStepReturnValue(point, [], 'wrun_test');

// Create a step resource with serialized output
const step = {
stepId: 'step_123',
runId: 'wrun_test',
output: serialized,
};

// Hydrate the step - this should convert Instance to ClassInstanceRef
// because the class is not registered in the o11y context (streamPrintRevivers)
const hydrated = hydrateResourceIO(step);

// The output should be a ClassInstanceRef
expect(isClassInstanceRef(hydrated.output)).toBe(true);
expect(hydrated.output.className).toBe('TestPoint');
expect(hydrated.output.classId).toBe('test//TestPoint');
expect(hydrated.output.data).toEqual({ x: 3, y: 4 });
});

it('should preserve ClassInstanceRef through JSON roundtrip', () => {
const ref = new ClassInstanceRef('Point', 'class//Point', { x: 1, y: 2 });
const json = JSON.stringify(ref);
const parsed = JSON.parse(json);

// After parsing, it's a plain object but still recognized
expect(isClassInstanceRef(parsed)).toBe(true);
expect(parsed.className).toBe('Point');
expect(parsed.classId).toBe('class//Point');
expect(parsed.data).toEqual({ x: 1, y: 2 });
});
});
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/forty-tables-lick.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
---
"@workflow/web-shared": patch
"@workflow/core": patch
---

Show custom class serialization UI and class names in o11y
369 changes: 369 additions & 0 deletions packages/core/src/observability.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,369 @@
import { inspect } from 'node:util';
import { WORKFLOW_DESERIALIZE, WORKFLOW_SERIALIZE } from '@workflow/serde';
import { describe, expect, it } from 'vitest';
import { registerSerializationClass } from './class-serialization.js';
import {
CLASS_INSTANCE_REF_TYPE,
ClassInstanceRef,
extractStreamIds,
hydrateResourceIO,
isClassInstanceRef,
isStreamId,
isStreamRef,
STREAM_REF_TYPE,
truncateId,
} from './observability.js';
import { dehydrateStepReturnValue } from './serialization.js';

describe('ClassInstanceRef', () => {
describe('constructor and properties', () => {
it('should create instance with correct properties', () => {
const ref = new ClassInstanceRef('Point', 'class//file.ts//Point', {
x: 1,
y: 2,
});

expect(ref.className).toBe('Point');
expect(ref.classId).toBe('class//file.ts//Point');
expect(ref.data).toEqual({ x: 1, y: 2 });
expect(ref.__type).toBe(CLASS_INSTANCE_REF_TYPE);
});

it('should handle various data types', () => {
// Object data
const objRef = new ClassInstanceRef('Config', 'class//Config', {
key: 'value',
});
expect(objRef.data).toEqual({ key: 'value' });

// String data
const strRef = new ClassInstanceRef('Token', 'class//Token', 'abc123');
expect(strRef.data).toBe('abc123');

// Number data
const numRef = new ClassInstanceRef('Counter', 'class//Counter', 42);
expect(numRef.data).toBe(42);

// Null data
const nullRef = new ClassInstanceRef('Empty', 'class//Empty', null);
expect(nullRef.data).toBeNull();

// Array data
const arrRef = new ClassInstanceRef('List', 'class//List', [1, 2, 3]);
expect(arrRef.data).toEqual([1, 2, 3]);
});
});

describe('toJSON()', () => {
it('should return plain object representation', () => {
const ref = new ClassInstanceRef('Point', 'class//file.ts//Point', {
x: 1,
y: 2,
});

expect(ref.toJSON()).toEqual({
__type: CLASS_INSTANCE_REF_TYPE,
className: 'Point',
classId: 'class//file.ts//Point',
data: { x: 1, y: 2 },
});
});

it('should be used by JSON.stringify', () => {
const ref = new ClassInstanceRef('Point', 'class//file.ts//Point', {
x: 1,
y: 2,
});

const json = JSON.stringify(ref);
const parsed = JSON.parse(json);

expect(parsed).toEqual({
__type: CLASS_INSTANCE_REF_TYPE,
className: 'Point',
classId: 'class//file.ts//Point',
data: { x: 1, y: 2 },
});
});
});

describe('[inspect.custom]', () => {
it('should render as ClassName@filename { data }', () => {
const ref = new ClassInstanceRef(
'Point',
'class//workflows/user-signup.ts//Point',
{ x: 1, y: 2 }
);

const output = inspect(ref, { colors: false });
expect(output).toBe('Point@user-signup.ts { x: 1, y: 2 }');
});

it('should handle nested file paths', () => {
const ref = new ClassInstanceRef(
'Config',
'class//lib/models/config.ts//Config',
{ nested: { a: 1, b: 2 } }
);

const output = inspect(ref, { colors: false });
expect(output).toBe('Config@config.ts { nested: { a: 1, b: 2 } }');
});

it('should handle string data', () => {
const ref = new ClassInstanceRef(
'Token',
'class//auth/token.ts//Token',
'secret'
);

const output = inspect(ref, { colors: false });
expect(output).toBe("Token@token.ts 'secret'");
});

it('should handle null data', () => {
const ref = new ClassInstanceRef(
'Empty',
'class//utils/empty.ts//Empty',
null
);

const output = inspect(ref, { colors: false });
expect(output).toBe('Empty@empty.ts null');
});

it('should handle array data', () => {
const ref = new ClassInstanceRef(
'List',
'class//collections/list.ts//List',
[1, 2, 3]
);

const output = inspect(ref, { colors: false });
expect(output).toBe('List@list.ts [ 1, 2, 3 ]');
});

it('should handle simple classId format gracefully', () => {
// Fallback for non-standard classId format
const ref = new ClassInstanceRef('Point', 'test//TestPoint', {
x: 1,
y: 2,
});

const output = inspect(ref, { colors: false });
// Falls back to extracting just the last segment as filename
expect(output).toBe('Point@TestPoint { x: 1, y: 2 }');
});

it('should style @filename gray when colors are enabled', () => {
const ref = new ClassInstanceRef(
'Point',
'class//workflows/point.ts//Point',
{ x: 1, y: 2 }
);

const output = inspect(ref, { colors: true });
// When colors are enabled, the @filename should have ANSI escape codes
expect(output).toContain('Point');
// Check for ANSI escape codes (gray/dim styling for @filename)
expect(output).toMatch(/\x1b\[90m@point\.ts\x1b\[39m/);
// Data is also present (may have color codes for numbers)
expect(output).toContain('x:');
expect(output).toContain('y:');
});
});
});

describe('isClassInstanceRef', () => {
it('should return true for ClassInstanceRef instances', () => {
const ref = new ClassInstanceRef('Point', 'class//Point', { x: 1, y: 2 });
expect(isClassInstanceRef(ref)).toBe(true);
});

it('should return true for plain objects with correct structure', () => {
const plainObj = {
__type: CLASS_INSTANCE_REF_TYPE,
className: 'Point',
classId: 'class//Point',
data: { x: 1, y: 2 },
};
expect(isClassInstanceRef(plainObj)).toBe(true);
});

it('should return true for JSON-parsed ClassInstanceRef', () => {
const ref = new ClassInstanceRef('Point', 'class//Point', { x: 1, y: 2 });
const parsed = JSON.parse(JSON.stringify(ref));
expect(isClassInstanceRef(parsed)).toBe(true);
});

it('should return false for null', () => {
expect(isClassInstanceRef(null)).toBe(false);
});

it('should return false for undefined', () => {
expect(isClassInstanceRef(undefined)).toBe(false);
});

it('should return false for plain objects without __type', () => {
expect(isClassInstanceRef({ className: 'Point', data: {} })).toBe(false);
});

it('should return false for objects with wrong __type', () => {
expect(
isClassInstanceRef({
__type: 'wrong_type',
className: 'Point',
data: {},
})
).toBe(false);
});

it('should return false for objects without className', () => {
expect(
isClassInstanceRef({
__type: CLASS_INSTANCE_REF_TYPE,
classId: 'class//Point',
data: {},
})
).toBe(false);
});
});

describe('isStreamRef', () => {
it('should return true for valid StreamRef', () => {
const streamRef = {
__type: STREAM_REF_TYPE,
streamId: 'strm_123',
};
expect(isStreamRef(streamRef)).toBe(true);
});

it('should return false for null', () => {
expect(isStreamRef(null)).toBe(false);
});

it('should return false for wrong __type', () => {
expect(isStreamRef({ __type: 'wrong', streamId: 'strm_123' })).toBe(false);
});
});

describe('isStreamId', () => {
it('should return true for valid stream ID', () => {
expect(isStreamId('strm_abc123')).toBe(true);
});

it('should return false for non-stream strings', () => {
expect(isStreamId('not_a_stream')).toBe(false);
});

it('should return false for non-strings', () => {
expect(isStreamId(123)).toBe(false);
expect(isStreamId(null)).toBe(false);
expect(isStreamId({})).toBe(false);
});
});

describe('extractStreamIds', () => {
it('should extract stream IDs from flat objects', () => {
const obj = { stream: 'strm_123', other: 'not_stream' };
expect(extractStreamIds(obj)).toEqual(['strm_123']);
});

it('should extract stream IDs from nested objects', () => {
const obj = {
level1: {
level2: {
stream: 'strm_abc',
},
},
};
expect(extractStreamIds(obj)).toEqual(['strm_abc']);
});

it('should extract stream IDs from arrays', () => {
const arr = ['strm_1', 'strm_2', 'not_stream'];
expect(extractStreamIds(arr)).toEqual(['strm_1', 'strm_2']);
});

it('should deduplicate stream IDs', () => {
const obj = { a: 'strm_same', b: 'strm_same' };
expect(extractStreamIds(obj)).toEqual(['strm_same']);
});

it('should return empty array for no streams', () => {
expect(extractStreamIds({ foo: 'bar' })).toEqual([]);
});
});

describe('truncateId', () => {
it('should not truncate short IDs', () => {
expect(truncateId('short', 12)).toBe('short');
});

it('should truncate long IDs', () => {
expect(truncateId('verylongidentifier', 12)).toBe('verylongiden...');
});

it('should use default max length of 12', () => {
expect(truncateId('123456789012')).toBe('123456789012');
expect(truncateId('1234567890123')).toBe('123456789012...');
});
});

describe('hydrateResourceIO with custom class instances', () => {
// Create a test class with serialization symbols
class TestPoint {
constructor(
public x: number,
public y: number
) {}

static [WORKFLOW_SERIALIZE](instance: TestPoint) {
return { x: instance.x, y: instance.y };
}

static [WORKFLOW_DESERIALIZE](data: { x: number; y: number }) {
return new TestPoint(data.x, data.y);
}
}

// Register the class for serialization (so dehydrate works)
// but note: in o11y context, classes are NOT registered, which is the point of this test
(TestPoint as any).classId = 'test//TestPoint';
registerSerializationClass('test//TestPoint', TestPoint);

it('should convert Instance type to ClassInstanceRef in step output', () => {
// Simulate serialized step data with a custom class instance
const point = new TestPoint(3, 4);
const serialized = dehydrateStepReturnValue(point, [], 'wrun_test');

// Create a step resource with serialized output
const step = {
stepId: 'step_123',
runId: 'wrun_test',
output: serialized,
};

// Hydrate the step - this should convert Instance to ClassInstanceRef
// because the class is not registered in the o11y context (streamPrintRevivers)
const hydrated = hydrateResourceIO(step);

// The output should be a ClassInstanceRef
expect(isClassInstanceRef(hydrated.output)).toBe(true);
expect(hydrated.output.className).toBe('TestPoint');
expect(hydrated.output.classId).toBe('test//TestPoint');
expect(hydrated.output.data).toEqual({ x: 3, y: 4 });
});

it('should preserve ClassInstanceRef through JSON roundtrip', () => {
const ref = new ClassInstanceRef('Point', 'class//Point', { x: 1, y: 2 });
const json = JSON.stringify(ref);
const parsed = JSON.parse(json);

// After parsing, it's a plain object but still recognized
expect(isClassInstanceRef(parsed)).toBe(true);
expect(parsed.className).toBe('Point');
expect(parsed.classId).toBe('class//Point');
expect(parsed.data).toEqual({ x: 1, y: 2 });
});
});
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/forty-tables-lick.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
---
"@workflow/web-shared": patch
"@workflow/core": patch
---

Show custom class serialization UI and class names in o11y
369 changes: 369 additions & 0 deletions packages/core/src/observability.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,369 @@
import { inspect } from 'node:util';
import { WORKFLOW_DESERIALIZE, WORKFLOW_SERIALIZE } from '@workflow/serde';
import { describe, expect, it } from 'vitest';
import { registerSerializationClass } from './class-serialization.js';
import {
CLASS_INSTANCE_REF_TYPE,
ClassInstanceRef,
extractStreamIds,
hydrateResourceIO,
isClassInstanceRef,
isStreamId,
isStreamRef,
STREAM_REF_TYPE,
truncateId,
} from './observability.js';
import { dehydrateStepReturnValue } from './serialization.js';

describe('ClassInstanceRef', () => {
describe('constructor and properties', () => {
it('should create instance with correct properties', () => {
const ref = new ClassInstanceRef('Point', 'class//file.ts//Point', {
x: 1,
y: 2,
});

expect(ref.className).toBe('Point');
expect(ref.classId).toBe('class//file.ts//Point');
expect(ref.data).toEqual({ x: 1, y: 2 });
expect(ref.__type).toBe(CLASS_INSTANCE_REF_TYPE);
});

it('should handle various data types', () => {
// Object data
const objRef = new ClassInstanceRef('Config', 'class//Config', {
key: 'value',
});
expect(objRef.data).toEqual({ key: 'value' });

// String data
const strRef = new ClassInstanceRef('Token', 'class//Token', 'abc123');
expect(strRef.data).toBe('abc123');

// Number data
const numRef = new ClassInstanceRef('Counter', 'class//Counter', 42);
expect(numRef.data).toBe(42);

// Null data
const nullRef = new ClassInstanceRef('Empty', 'class//Empty', null);
expect(nullRef.data).toBeNull();

// Array data
const arrRef = new ClassInstanceRef('List', 'class//List', [1, 2, 3]);
expect(arrRef.data).toEqual([1, 2, 3]);
});
});

describe('toJSON()', () => {
it('should return plain object representation', () => {
const ref = new ClassInstanceRef('Point', 'class//file.ts//Point', {
x: 1,
y: 2,
});

expect(ref.toJSON()).toEqual({
__type: CLASS_INSTANCE_REF_TYPE,
className: 'Point',
classId: 'class//file.ts//Point',
data: { x: 1, y: 2 },
});
});

it('should be used by JSON.stringify', () => {
const ref = new ClassInstanceRef('Point', 'class//file.ts//Point', {
x: 1,
y: 2,
});

const json = JSON.stringify(ref);
const parsed = JSON.parse(json);

expect(parsed).toEqual({
__type: CLASS_INSTANCE_REF_TYPE,
className: 'Point',
classId: 'class//file.ts//Point',
data: { x: 1, y: 2 },
});
});
});

describe('[inspect.custom]', () => {
it('should render as ClassName@filename { data }', () => {
const ref = new ClassInstanceRef(
'Point',
'class//workflows/user-signup.ts//Point',
{ x: 1, y: 2 }
);

const output = inspect(ref, { colors: false });
expect(output).toBe('Point@user-signup.ts { x: 1, y: 2 }');
});

it('should handle nested file paths', () => {
const ref = new ClassInstanceRef(
'Config',
'class//lib/models/config.ts//Config',
{ nested: { a: 1, b: 2 } }
);

const output = inspect(ref, { colors: false });
expect(output).toBe('Config@config.ts { nested: { a: 1, b: 2 } }');
});

it('should handle string data', () => {
const ref = new ClassInstanceRef(
'Token',
'class//auth/token.ts//Token',
'secret'
);

const output = inspect(ref, { colors: false });
expect(output).toBe("Token@token.ts 'secret'");
});

it('should handle null data', () => {
const ref = new ClassInstanceRef(
'Empty',
'class//utils/empty.ts//Empty',
null
);

const output = inspect(ref, { colors: false });
expect(output).toBe('Empty@empty.ts null');
});

it('should handle array data', () => {
const ref = new ClassInstanceRef(
'List',
'class//collections/list.ts//List',
[1, 2, 3]
);

const output = inspect(ref, { colors: false });
expect(output).toBe('List@list.ts [ 1, 2, 3 ]');
});

it('should handle simple classId format gracefully', () => {
// Fallback for non-standard classId format
const ref = new ClassInstanceRef('Point', 'test//TestPoint', {
x: 1,
y: 2,
});

const output = inspect(ref, { colors: false });
// Falls back to extracting just the last segment as filename
expect(output).toBe('Point@TestPoint { x: 1, y: 2 }');
});

it('should style @filename gray when colors are enabled', () => {
const ref = new ClassInstanceRef(
'Point',
'class//workflows/point.ts//Point',
{ x: 1, y: 2 }
);

const output = inspect(ref, { colors: true });
// When colors are enabled, the @filename should have ANSI escape codes
expect(output).toContain('Point');
// Check for ANSI escape codes (gray/dim styling for @filename)
expect(output).toMatch(/\x1b\[90m@point\.ts\x1b\[39m/);
// Data is also present (may have color codes for numbers)
expect(output).toContain('x:');
expect(output).toContain('y:');
});
});
});

describe('isClassInstanceRef', () => {
it('should return true for ClassInstanceRef instances', () => {
const ref = new ClassInstanceRef('Point', 'class//Point', { x: 1, y: 2 });
expect(isClassInstanceRef(ref)).toBe(true);
});

it('should return true for plain objects with correct structure', () => {
const plainObj = {
__type: CLASS_INSTANCE_REF_TYPE,
className: 'Point',
classId: 'class//Point',
data: { x: 1, y: 2 },
};
expect(isClassInstanceRef(plainObj)).toBe(true);
});

it('should return true for JSON-parsed ClassInstanceRef', () => {
const ref = new ClassInstanceRef('Point', 'class//Point', { x: 1, y: 2 });
const parsed = JSON.parse(JSON.stringify(ref));
expect(isClassInstanceRef(parsed)).toBe(true);
});

it('should return false for null', () => {
expect(isClassInstanceRef(null)).toBe(false);
});

it('should return false for undefined', () => {
expect(isClassInstanceRef(undefined)).toBe(false);
});

it('should return false for plain objects without __type', () => {
expect(isClassInstanceRef({ className: 'Point', data: {} })).toBe(false);
});

it('should return false for objects with wrong __type', () => {
expect(
isClassInstanceRef({
__type: 'wrong_type',
className: 'Point',
data: {},
})
).toBe(false);
});

it('should return false for objects without className', () => {
expect(
isClassInstanceRef({
__type: CLASS_INSTANCE_REF_TYPE,
classId: 'class//Point',
data: {},
})
).toBe(false);
});
});

describe('isStreamRef', () => {
it('should return true for valid StreamRef', () => {
const streamRef = {
__type: STREAM_REF_TYPE,
streamId: 'strm_123',
};
expect(isStreamRef(streamRef)).toBe(true);
});

it('should return false for null', () => {
expect(isStreamRef(null)).toBe(false);
});

it('should return false for wrong __type', () => {
expect(isStreamRef({ __type: 'wrong', streamId: 'strm_123' })).toBe(false);
});
});

describe('isStreamId', () => {
it('should return true for valid stream ID', () => {
expect(isStreamId('strm_abc123')).toBe(true);
});

it('should return false for non-stream strings', () => {
expect(isStreamId('not_a_stream')).toBe(false);
});

it('should return false for non-strings', () => {
expect(isStreamId(123)).toBe(false);
expect(isStreamId(null)).toBe(false);
expect(isStreamId({})).toBe(false);
});
});

describe('extractStreamIds', () => {
it('should extract stream IDs from flat objects', () => {
const obj = { stream: 'strm_123', other: 'not_stream' };
expect(extractStreamIds(obj)).toEqual(['strm_123']);
});

it('should extract stream IDs from nested objects', () => {
const obj = {
level1: {
level2: {
stream: 'strm_abc',
},
},
};
expect(extractStreamIds(obj)).toEqual(['strm_abc']);
});

it('should extract stream IDs from arrays', () => {
const arr = ['strm_1', 'strm_2', 'not_stream'];
expect(extractStreamIds(arr)).toEqual(['strm_1', 'strm_2']);
});

it('should deduplicate stream IDs', () => {
const obj = { a: 'strm_same', b: 'strm_same' };
expect(extractStreamIds(obj)).toEqual(['strm_same']);
});

it('should return empty array for no streams', () => {
expect(extractStreamIds({ foo: 'bar' })).toEqual([]);
});
});

describe('truncateId', () => {
it('should not truncate short IDs', () => {
expect(truncateId('short', 12)).toBe('short');
});

it('should truncate long IDs', () => {
expect(truncateId('verylongidentifier', 12)).toBe('verylongiden...');
});

it('should use default max length of 12', () => {
expect(truncateId('123456789012')).toBe('123456789012');
expect(truncateId('1234567890123')).toBe('123456789012...');
});
});

describe('hydrateResourceIO with custom class instances', () => {
// Create a test class with serialization symbols
class TestPoint {
constructor(
public x: number,
public y: number
) {}

static [WORKFLOW_SERIALIZE](instance: TestPoint) {
return { x: instance.x, y: instance.y };
}

static [WORKFLOW_DESERIALIZE](data: { x: number; y: number }) {
return new TestPoint(data.x, data.y);
}
}

// Register the class for serialization (so dehydrate works)
// but note: in o11y context, classes are NOT registered, which is the point of this test
(TestPoint as any).classId = 'test//TestPoint';
registerSerializationClass('test//TestPoint', TestPoint);

it('should convert Instance type to ClassInstanceRef in step output', () => {
// Simulate serialized step data with a custom class instance
const point = new TestPoint(3, 4);
const serialized = dehydrateStepReturnValue(point, [], 'wrun_test');

// Create a step resource with serialized output
const step = {
stepId: 'step_123',
runId: 'wrun_test',
output: serialized,
};

// Hydrate the step - this should convert Instance to ClassInstanceRef
// because the class is not registered in the o11y context (streamPrintRevivers)
const hydrated = hydrateResourceIO(step);

// The output should be a ClassInstanceRef
expect(isClassInstanceRef(hydrated.output)).toBe(true);
expect(hydrated.output.className).toBe('TestPoint');
expect(hydrated.output.classId).toBe('test//TestPoint');
expect(hydrated.output.data).toEqual({ x: 3, y: 4 });
});

it('should preserve ClassInstanceRef through JSON roundtrip', () => {
const ref = new ClassInstanceRef('Point', 'class//Point', { x: 1, y: 2 });
const json = JSON.stringify(ref);
const parsed = JSON.parse(json);

// After parsing, it's a plain object but still recognized
expect(isClassInstanceRef(parsed)).toBe(true);
expect(parsed.className).toBe('Point');
expect(parsed.classId).toBe('class//Point');
expect(parsed.data).toEqual({ x: 1, y: 2 });
});
});
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/forty-tables-lick.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
---
"@workflow/web-shared": patch
"@workflow/core": patch
---

Show custom class serialization UI and class names in o11y
369 changes: 369 additions & 0 deletions packages/core/src/observability.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,369 @@
import { inspect } from 'node:util';
import { WORKFLOW_DESERIALIZE, WORKFLOW_SERIALIZE } from '@workflow/serde';
import { describe, expect, it } from 'vitest';
import { registerSerializationClass } from './class-serialization.js';
import {
CLASS_INSTANCE_REF_TYPE,
ClassInstanceRef,
extractStreamIds,
hydrateResourceIO,
isClassInstanceRef,
isStreamId,
isStreamRef,
STREAM_REF_TYPE,
truncateId,
} from './observability.js';
import { dehydrateStepReturnValue } from './serialization.js';

describe('ClassInstanceRef', () => {
describe('constructor and properties', () => {
it('should create instance with correct properties', () => {
const ref = new ClassInstanceRef('Point', 'class//file.ts//Point', {
x: 1,
y: 2,
});

expect(ref.className).toBe('Point');
expect(ref.classId).toBe('class//file.ts//Point');
expect(ref.data).toEqual({ x: 1, y: 2 });
expect(ref.__type).toBe(CLASS_INSTANCE_REF_TYPE);
});

it('should handle various data types', () => {
// Object data
const objRef = new ClassInstanceRef('Config', 'class//Config', {
key: 'value',
});
expect(objRef.data).toEqual({ key: 'value' });

// String data
const strRef = new ClassInstanceRef('Token', 'class//Token', 'abc123');
expect(strRef.data).toBe('abc123');

// Number data
const numRef = new ClassInstanceRef('Counter', 'class//Counter', 42);
expect(numRef.data).toBe(42);

// Null data
const nullRef = new ClassInstanceRef('Empty', 'class//Empty', null);
expect(nullRef.data).toBeNull();

// Array data
const arrRef = new ClassInstanceRef('List', 'class//List', [1, 2, 3]);
expect(arrRef.data).toEqual([1, 2, 3]);
});
});

describe('toJSON()', () => {
it('should return plain object representation', () => {
const ref = new ClassInstanceRef('Point', 'class//file.ts//Point', {
x: 1,
y: 2,
});

expect(ref.toJSON()).toEqual({
__type: CLASS_INSTANCE_REF_TYPE,
className: 'Point',
classId: 'class//file.ts//Point',
data: { x: 1, y: 2 },
});
});

it('should be used by JSON.stringify', () => {
const ref = new ClassInstanceRef('Point', 'class//file.ts//Point', {
x: 1,
y: 2,
});

const json = JSON.stringify(ref);
const parsed = JSON.parse(json);

expect(parsed).toEqual({
__type: CLASS_INSTANCE_REF_TYPE,
className: 'Point',
classId: 'class//file.ts//Point',
data: { x: 1, y: 2 },
});
});
});

describe('[inspect.custom]', () => {
it('should render as ClassName@filename { data }', () => {
const ref = new ClassInstanceRef(
'Point',
'class//workflows/user-signup.ts//Point',
{ x: 1, y: 2 }
);

const output = inspect(ref, { colors: false });
expect(output).toBe('Point@user-signup.ts { x: 1, y: 2 }');
});

it('should handle nested file paths', () => {
const ref = new ClassInstanceRef(
'Config',
'class//lib/models/config.ts//Config',
{ nested: { a: 1, b: 2 } }
);

const output = inspect(ref, { colors: false });
expect(output).toBe('Config@config.ts { nested: { a: 1, b: 2 } }');
});

it('should handle string data', () => {
const ref = new ClassInstanceRef(
'Token',
'class//auth/token.ts//Token',
'secret'
);

const output = inspect(ref, { colors: false });
expect(output).toBe("Token@token.ts 'secret'");
});

it('should handle null data', () => {
const ref = new ClassInstanceRef(
'Empty',
'class//utils/empty.ts//Empty',
null
);

const output = inspect(ref, { colors: false });
expect(output).toBe('Empty@empty.ts null');
});

it('should handle array data', () => {
const ref = new ClassInstanceRef(
'List',
'class//collections/list.ts//List',
[1, 2, 3]
);

const output = inspect(ref, { colors: false });
expect(output).toBe('List@list.ts [ 1, 2, 3 ]');
});

it('should handle simple classId format gracefully', () => {
// Fallback for non-standard classId format
const ref = new ClassInstanceRef('Point', 'test//TestPoint', {
x: 1,
y: 2,
});

const output = inspect(ref, { colors: false });
// Falls back to extracting just the last segment as filename
expect(output).toBe('Point@TestPoint { x: 1, y: 2 }');
});

it('should style @filename gray when colors are enabled', () => {
const ref = new ClassInstanceRef(
'Point',
'class//workflows/point.ts//Point',
{ x: 1, y: 2 }
);

const output = inspect(ref, { colors: true });
// When colors are enabled, the @filename should have ANSI escape codes
expect(output).toContain('Point');
// Check for ANSI escape codes (gray/dim styling for @filename)
expect(output).toMatch(/\x1b\[90m@point\.ts\x1b\[39m/);
// Data is also present (may have color codes for numbers)
expect(output).toContain('x:');
expect(output).toContain('y:');
});
});
});

describe('isClassInstanceRef', () => {
it('should return true for ClassInstanceRef instances', () => {
const ref = new ClassInstanceRef('Point', 'class//Point', { x: 1, y: 2 });
expect(isClassInstanceRef(ref)).toBe(true);
});

it('should return true for plain objects with correct structure', () => {
const plainObj = {
__type: CLASS_INSTANCE_REF_TYPE,
className: 'Point',
classId: 'class//Point',
data: { x: 1, y: 2 },
};
expect(isClassInstanceRef(plainObj)).toBe(true);
});

it('should return true for JSON-parsed ClassInstanceRef', () => {
const ref = new ClassInstanceRef('Point', 'class//Point', { x: 1, y: 2 });
const parsed = JSON.parse(JSON.stringify(ref));
expect(isClassInstanceRef(parsed)).toBe(true);
});

it('should return false for null', () => {
expect(isClassInstanceRef(null)).toBe(false);
});

it('should return false for undefined', () => {
expect(isClassInstanceRef(undefined)).toBe(false);
});

it('should return false for plain objects without __type', () => {
expect(isClassInstanceRef({ className: 'Point', data: {} })).toBe(false);
});

it('should return false for objects with wrong __type', () => {
expect(
isClassInstanceRef({
__type: 'wrong_type',
className: 'Point',
data: {},
})
).toBe(false);
});

it('should return false for objects without className', () => {
expect(
isClassInstanceRef({
__type: CLASS_INSTANCE_REF_TYPE,
classId: 'class//Point',
data: {},
})
).toBe(false);
});
});

describe('isStreamRef', () => {
it('should return true for valid StreamRef', () => {
const streamRef = {
__type: STREAM_REF_TYPE,
streamId: 'strm_123',
};
expect(isStreamRef(streamRef)).toBe(true);
});

it('should return false for null', () => {
expect(isStreamRef(null)).toBe(false);
});

it('should return false for wrong __type', () => {
expect(isStreamRef({ __type: 'wrong', streamId: 'strm_123' })).toBe(false);
});
});

describe('isStreamId', () => {
it('should return true for valid stream ID', () => {
expect(isStreamId('strm_abc123')).toBe(true);
});

it('should return false for non-stream strings', () => {
expect(isStreamId('not_a_stream')).toBe(false);
});

it('should return false for non-strings', () => {
expect(isStreamId(123)).toBe(false);
expect(isStreamId(null)).toBe(false);
expect(isStreamId({})).toBe(false);
});
});

describe('extractStreamIds', () => {
it('should extract stream IDs from flat objects', () => {
const obj = { stream: 'strm_123', other: 'not_stream' };
expect(extractStreamIds(obj)).toEqual(['strm_123']);
});

it('should extract stream IDs from nested objects', () => {
const obj = {
level1: {
level2: {
stream: 'strm_abc',
},
},
};
expect(extractStreamIds(obj)).toEqual(['strm_abc']);
});

it('should extract stream IDs from arrays', () => {
const arr = ['strm_1', 'strm_2', 'not_stream'];
expect(extractStreamIds(arr)).toEqual(['strm_1', 'strm_2']);
});

it('should deduplicate stream IDs', () => {
const obj = { a: 'strm_same', b: 'strm_same' };
expect(extractStreamIds(obj)).toEqual(['strm_same']);
});

it('should return empty array for no streams', () => {
expect(extractStreamIds({ foo: 'bar' })).toEqual([]);
});
});

describe('truncateId', () => {
it('should not truncate short IDs', () => {
expect(truncateId('short', 12)).toBe('short');
});

it('should truncate long IDs', () => {
expect(truncateId('verylongidentifier', 12)).toBe('verylongiden...');
});

it('should use default max length of 12', () => {
expect(truncateId('123456789012')).toBe('123456789012');
expect(truncateId('1234567890123')).toBe('123456789012...');
});
});

describe('hydrateResourceIO with custom class instances', () => {
// Create a test class with serialization symbols
class TestPoint {
constructor(
public x: number,
public y: number
) {}

static [WORKFLOW_SERIALIZE](instance: TestPoint) {
return { x: instance.x, y: instance.y };
}

static [WORKFLOW_DESERIALIZE](data: { x: number; y: number }) {
return new TestPoint(data.x, data.y);
}
}

// Register the class for serialization (so dehydrate works)
// but note: in o11y context, classes are NOT registered, which is the point of this test
(TestPoint as any).classId = 'test//TestPoint';
registerSerializationClass('test//TestPoint', TestPoint);

it('should convert Instance type to ClassInstanceRef in step output', () => {
// Simulate serialized step data with a custom class instance
const point = new TestPoint(3, 4);
const serialized = dehydrateStepReturnValue(point, [], 'wrun_test');

// Create a step resource with serialized output
const step = {
stepId: 'step_123',
runId: 'wrun_test',
output: serialized,
};

// Hydrate the step - this should convert Instance to ClassInstanceRef
// because the class is not registered in the o11y context (streamPrintRevivers)
const hydrated = hydrateResourceIO(step);

// The output should be a ClassInstanceRef
expect(isClassInstanceRef(hydrated.output)).toBe(true);
expect(hydrated.output.className).toBe('TestPoint');
expect(hydrated.output.classId).toBe('test//TestPoint');
expect(hydrated.output.data).toEqual({ x: 3, y: 4 });
});

it('should preserve ClassInstanceRef through JSON roundtrip', () => {
const ref = new ClassInstanceRef('Point', 'class//Point', { x: 1, y: 2 });
const json = JSON.stringify(ref);
const parsed = JSON.parse(json);

// After parsing, it's a plain object but still recognized
expect(isClassInstanceRef(parsed)).toBe(true);
expect(parsed.className).toBe('Point');
expect(parsed.classId).toBe('class//Point');
expect(parsed.data).toEqual({ x: 1, y: 2 });
});
});
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/forty-tables-lick.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
---
"@workflow/web-shared": patch
"@workflow/core": patch
---

Show custom class serialization UI and class names in o11y
369 changes: 369 additions & 0 deletions packages/core/src/observability.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,369 @@
import { inspect } from 'node:util';
import { WORKFLOW_DESERIALIZE, WORKFLOW_SERIALIZE } from '@workflow/serde';
import { describe, expect, it } from 'vitest';
import { registerSerializationClass } from './class-serialization.js';
import {
CLASS_INSTANCE_REF_TYPE,
ClassInstanceRef,
extractStreamIds,
hydrateResourceIO,
isClassInstanceRef,
isStreamId,
isStreamRef,
STREAM_REF_TYPE,
truncateId,
} from './observability.js';
import { dehydrateStepReturnValue } from './serialization.js';

describe('ClassInstanceRef', () => {
describe('constructor and properties', () => {
it('should create instance with correct properties', () => {
const ref = new ClassInstanceRef('Point', 'class//file.ts//Point', {
x: 1,
y: 2,
});

expect(ref.className).toBe('Point');
expect(ref.classId).toBe('class//file.ts//Point');
expect(ref.data).toEqual({ x: 1, y: 2 });
expect(ref.__type).toBe(CLASS_INSTANCE_REF_TYPE);
});

it('should handle various data types', () => {
// Object data
const objRef = new ClassInstanceRef('Config', 'class//Config', {
key: 'value',
});
expect(objRef.data).toEqual({ key: 'value' });

// String data
const strRef = new ClassInstanceRef('Token', 'class//Token', 'abc123');
expect(strRef.data).toBe('abc123');

// Number data
const numRef = new ClassInstanceRef('Counter', 'class//Counter', 42);
expect(numRef.data).toBe(42);

// Null data
const nullRef = new ClassInstanceRef('Empty', 'class//Empty', null);
expect(nullRef.data).toBeNull();

// Array data
const arrRef = new ClassInstanceRef('List', 'class//List', [1, 2, 3]);
expect(arrRef.data).toEqual([1, 2, 3]);
});
});

describe('toJSON()', () => {
it('should return plain object representation', () => {
const ref = new ClassInstanceRef('Point', 'class//file.ts//Point', {
x: 1,
y: 2,
});

expect(ref.toJSON()).toEqual({
__type: CLASS_INSTANCE_REF_TYPE,
className: 'Point',
classId: 'class//file.ts//Point',
data: { x: 1, y: 2 },
});
});

it('should be used by JSON.stringify', () => {
const ref = new ClassInstanceRef('Point', 'class//file.ts//Point', {
x: 1,
y: 2,
});

const json = JSON.stringify(ref);
const parsed = JSON.parse(json);

expect(parsed).toEqual({
__type: CLASS_INSTANCE_REF_TYPE,
className: 'Point',
classId: 'class//file.ts//Point',
data: { x: 1, y: 2 },
});
});
});

describe('[inspect.custom]', () => {
it('should render as ClassName@filename { data }', () => {
const ref = new ClassInstanceRef(
'Point',
'class//workflows/user-signup.ts//Point',
{ x: 1, y: 2 }
);

const output = inspect(ref, { colors: false });
expect(output).toBe('Point@user-signup.ts { x: 1, y: 2 }');
});

it('should handle nested file paths', () => {
const ref = new ClassInstanceRef(
'Config',
'class//lib/models/config.ts//Config',
{ nested: { a: 1, b: 2 } }
);

const output = inspect(ref, { colors: false });
expect(output).toBe('Config@config.ts { nested: { a: 1, b: 2 } }');
});

it('should handle string data', () => {
const ref = new ClassInstanceRef(
'Token',
'class//auth/token.ts//Token',
'secret'
);

const output = inspect(ref, { colors: false });
expect(output).toBe("Token@token.ts 'secret'");
});

it('should handle null data', () => {
const ref = new ClassInstanceRef(
'Empty',
'class//utils/empty.ts//Empty',
null
);

const output = inspect(ref, { colors: false });
expect(output).toBe('Empty@empty.ts null');
});

it('should handle array data', () => {
const ref = new ClassInstanceRef(
'List',
'class//collections/list.ts//List',
[1, 2, 3]
);

const output = inspect(ref, { colors: false });
expect(output).toBe('List@list.ts [ 1, 2, 3 ]');
});

it('should handle simple classId format gracefully', () => {
// Fallback for non-standard classId format
const ref = new ClassInstanceRef('Point', 'test//TestPoint', {
x: 1,
y: 2,
});

const output = inspect(ref, { colors: false });
// Falls back to extracting just the last segment as filename
expect(output).toBe('Point@TestPoint { x: 1, y: 2 }');
});

it('should style @filename gray when colors are enabled', () => {
const ref = new ClassInstanceRef(
'Point',
'class//workflows/point.ts//Point',
{ x: 1, y: 2 }
);

const output = inspect(ref, { colors: true });
// When colors are enabled, the @filename should have ANSI escape codes
expect(output).toContain('Point');
// Check for ANSI escape codes (gray/dim styling for @filename)
expect(output).toMatch(/\x1b\[90m@point\.ts\x1b\[39m/);
// Data is also present (may have color codes for numbers)
expect(output).toContain('x:');
expect(output).toContain('y:');
});
});
});

describe('isClassInstanceRef', () => {
it('should return true for ClassInstanceRef instances', () => {
const ref = new ClassInstanceRef('Point', 'class//Point', { x: 1, y: 2 });
expect(isClassInstanceRef(ref)).toBe(true);
});

it('should return true for plain objects with correct structure', () => {
const plainObj = {
__type: CLASS_INSTANCE_REF_TYPE,
className: 'Point',
classId: 'class//Point',
data: { x: 1, y: 2 },
};
expect(isClassInstanceRef(plainObj)).toBe(true);
});

it('should return true for JSON-parsed ClassInstanceRef', () => {
const ref = new ClassInstanceRef('Point', 'class//Point', { x: 1, y: 2 });
const parsed = JSON.parse(JSON.stringify(ref));
expect(isClassInstanceRef(parsed)).toBe(true);
});

it('should return false for null', () => {
expect(isClassInstanceRef(null)).toBe(false);
});

it('should return false for undefined', () => {
expect(isClassInstanceRef(undefined)).toBe(false);
});

it('should return false for plain objects without __type', () => {
expect(isClassInstanceRef({ className: 'Point', data: {} })).toBe(false);
});

it('should return false for objects with wrong __type', () => {
expect(
isClassInstanceRef({
__type: 'wrong_type',
className: 'Point',
data: {},
})
).toBe(false);
});

it('should return false for objects without className', () => {
expect(
isClassInstanceRef({
__type: CLASS_INSTANCE_REF_TYPE,
classId: 'class//Point',
data: {},
})
).toBe(false);
});
});

describe('isStreamRef', () => {
it('should return true for valid StreamRef', () => {
const streamRef = {
__type: STREAM_REF_TYPE,
streamId: 'strm_123',
};
expect(isStreamRef(streamRef)).toBe(true);
});

it('should return false for null', () => {
expect(isStreamRef(null)).toBe(false);
});

it('should return false for wrong __type', () => {
expect(isStreamRef({ __type: 'wrong', streamId: 'strm_123' })).toBe(false);
});
});

describe('isStreamId', () => {
it('should return true for valid stream ID', () => {
expect(isStreamId('strm_abc123')).toBe(true);
});

it('should return false for non-stream strings', () => {
expect(isStreamId('not_a_stream')).toBe(false);
});

it('should return false for non-strings', () => {
expect(isStreamId(123)).toBe(false);
expect(isStreamId(null)).toBe(false);
expect(isStreamId({})).toBe(false);
});
});

describe('extractStreamIds', () => {
it('should extract stream IDs from flat objects', () => {
const obj = { stream: 'strm_123', other: 'not_stream' };
expect(extractStreamIds(obj)).toEqual(['strm_123']);
});

it('should extract stream IDs from nested objects', () => {
const obj = {
level1: {
level2: {
stream: 'strm_abc',
},
},
};
expect(extractStreamIds(obj)).toEqual(['strm_abc']);
});

it('should extract stream IDs from arrays', () => {
const arr = ['strm_1', 'strm_2', 'not_stream'];
expect(extractStreamIds(arr)).toEqual(['strm_1', 'strm_2']);
});

it('should deduplicate stream IDs', () => {
const obj = { a: 'strm_same', b: 'strm_same' };
expect(extractStreamIds(obj)).toEqual(['strm_same']);
});

it('should return empty array for no streams', () => {
expect(extractStreamIds({ foo: 'bar' })).toEqual([]);
});
});

describe('truncateId', () => {
it('should not truncate short IDs', () => {
expect(truncateId('short', 12)).toBe('short');
});

it('should truncate long IDs', () => {
expect(truncateId('verylongidentifier', 12)).toBe('verylongiden...');
});

it('should use default max length of 12', () => {
expect(truncateId('123456789012')).toBe('123456789012');
expect(truncateId('1234567890123')).toBe('123456789012...');
});
});

describe('hydrateResourceIO with custom class instances', () => {
// Create a test class with serialization symbols
class TestPoint {
constructor(
public x: number,
public y: number
) {}

static [WORKFLOW_SERIALIZE](instance: TestPoint) {
return { x: instance.x, y: instance.y };
}

static [WORKFLOW_DESERIALIZE](data: { x: number; y: number }) {
return new TestPoint(data.x, data.y);
}
}

// Register the class for serialization (so dehydrate works)
// but note: in o11y context, classes are NOT registered, which is the point of this test
(TestPoint as any).classId = 'test//TestPoint';
registerSerializationClass('test//TestPoint', TestPoint);

it('should convert Instance type to ClassInstanceRef in step output', () => {
// Simulate serialized step data with a custom class instance
const point = new TestPoint(3, 4);
const serialized = dehydrateStepReturnValue(point, [], 'wrun_test');

// Create a step resource with serialized output
const step = {
stepId: 'step_123',
runId: 'wrun_test',
output: serialized,
};

// Hydrate the step - this should convert Instance to ClassInstanceRef
// because the class is not registered in the o11y context (streamPrintRevivers)
const hydrated = hydrateResourceIO(step);

// The output should be a ClassInstanceRef
expect(isClassInstanceRef(hydrated.output)).toBe(true);
expect(hydrated.output.className).toBe('TestPoint');
expect(hydrated.output.classId).toBe('test//TestPoint');
expect(hydrated.output.data).toEqual({ x: 3, y: 4 });
});

it('should preserve ClassInstanceRef through JSON roundtrip', () => {
const ref = new ClassInstanceRef('Point', 'class//Point', { x: 1, y: 2 });
const json = JSON.stringify(ref);
const parsed = JSON.parse(json);

// After parsing, it's a plain object but still recognized
expect(isClassInstanceRef(parsed)).toBe(true);
expect(parsed.className).toBe('Point');
expect(parsed.classId).toBe('class//Point');
expect(parsed.data).toEqual({ x: 1, y: 2 });
});
});
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/forty-tables-lick.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
---
"@workflow/web-shared": patch
"@workflow/core": patch
---

Show custom class serialization UI and class names in o11y
369 changes: 369 additions & 0 deletions packages/core/src/observability.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,369 @@
import { inspect } from 'node:util';
import { WORKFLOW_DESERIALIZE, WORKFLOW_SERIALIZE } from '@workflow/serde';
import { describe, expect, it } from 'vitest';
import { registerSerializationClass } from './class-serialization.js';
import {
CLASS_INSTANCE_REF_TYPE,
ClassInstanceRef,
extractStreamIds,
hydrateResourceIO,
isClassInstanceRef,
isStreamId,
isStreamRef,
STREAM_REF_TYPE,
truncateId,
} from './observability.js';
import { dehydrateStepReturnValue } from './serialization.js';

describe('ClassInstanceRef', () => {
describe('constructor and properties', () => {
it('should create instance with correct properties', () => {
const ref = new ClassInstanceRef('Point', 'class//file.ts//Point', {
x: 1,
y: 2,
});

expect(ref.className).toBe('Point');
expect(ref.classId).toBe('class//file.ts//Point');
expect(ref.data).toEqual({ x: 1, y: 2 });
expect(ref.__type).toBe(CLASS_INSTANCE_REF_TYPE);
});

it('should handle various data types', () => {
// Object data
const objRef = new ClassInstanceRef('Config', 'class//Config', {
key: 'value',
});
expect(objRef.data).toEqual({ key: 'value' });

// String data
const strRef = new ClassInstanceRef('Token', 'class//Token', 'abc123');
expect(strRef.data).toBe('abc123');

// Number data
const numRef = new ClassInstanceRef('Counter', 'class//Counter', 42);
expect(numRef.data).toBe(42);

// Null data
const nullRef = new ClassInstanceRef('Empty', 'class//Empty', null);
expect(nullRef.data).toBeNull();

// Array data
const arrRef = new ClassInstanceRef('List', 'class//List', [1, 2, 3]);
expect(arrRef.data).toEqual([1, 2, 3]);
});
});

describe('toJSON()', () => {
it('should return plain object representation', () => {
const ref = new ClassInstanceRef('Point', 'class//file.ts//Point', {
x: 1,
y: 2,
});

expect(ref.toJSON()).toEqual({
__type: CLASS_INSTANCE_REF_TYPE,
className: 'Point',
classId: 'class//file.ts//Point',
data: { x: 1, y: 2 },
});
});

it('should be used by JSON.stringify', () => {
const ref = new ClassInstanceRef('Point', 'class//file.ts//Point', {
x: 1,
y: 2,
});

const json = JSON.stringify(ref);
const parsed = JSON.parse(json);

expect(parsed).toEqual({
__type: CLASS_INSTANCE_REF_TYPE,
className: 'Point',
classId: 'class//file.ts//Point',
data: { x: 1, y: 2 },
});
});
});

describe('[inspect.custom]', () => {
it('should render as ClassName@filename { data }', () => {
const ref = new ClassInstanceRef(
'Point',
'class//workflows/user-signup.ts//Point',
{ x: 1, y: 2 }
);

const output = inspect(ref, { colors: false });
expect(output).toBe('Point@user-signup.ts { x: 1, y: 2 }');
});

it('should handle nested file paths', () => {
const ref = new ClassInstanceRef(
'Config',
'class//lib/models/config.ts//Config',
{ nested: { a: 1, b: 2 } }
);

const output = inspect(ref, { colors: false });
expect(output).toBe('Config@config.ts { nested: { a: 1, b: 2 } }');
});

it('should handle string data', () => {
const ref = new ClassInstanceRef(
'Token',
'class//auth/token.ts//Token',
'secret'
);

const output = inspect(ref, { colors: false });
expect(output).toBe("Token@token.ts 'secret'");
});

it('should handle null data', () => {
const ref = new ClassInstanceRef(
'Empty',
'class//utils/empty.ts//Empty',
null
);

const output = inspect(ref, { colors: false });
expect(output).toBe('Empty@empty.ts null');
});

it('should handle array data', () => {
const ref = new ClassInstanceRef(
'List',
'class//collections/list.ts//List',
[1, 2, 3]
);

const output = inspect(ref, { colors: false });
expect(output).toBe('List@list.ts [ 1, 2, 3 ]');
});

it('should handle simple classId format gracefully', () => {
// Fallback for non-standard classId format
const ref = new ClassInstanceRef('Point', 'test//TestPoint', {
x: 1,
y: 2,
});

const output = inspect(ref, { colors: false });
// Falls back to extracting just the last segment as filename
expect(output).toBe('Point@TestPoint { x: 1, y: 2 }');
});

it('should style @filename gray when colors are enabled', () => {
const ref = new ClassInstanceRef(
'Point',
'class//workflows/point.ts//Point',
{ x: 1, y: 2 }
);

const output = inspect(ref, { colors: true });
// When colors are enabled, the @filename should have ANSI escape codes
expect(output).toContain('Point');
// Check for ANSI escape codes (gray/dim styling for @filename)
expect(output).toMatch(/\x1b\[90m@point\.ts\x1b\[39m/);
// Data is also present (may have color codes for numbers)
expect(output).toContain('x:');
expect(output).toContain('y:');
});
});
});

describe('isClassInstanceRef', () => {
it('should return true for ClassInstanceRef instances', () => {
const ref = new ClassInstanceRef('Point', 'class//Point', { x: 1, y: 2 });
expect(isClassInstanceRef(ref)).toBe(true);
});

it('should return true for plain objects with correct structure', () => {
const plainObj = {
__type: CLASS_INSTANCE_REF_TYPE,
className: 'Point',
classId: 'class//Point',
data: { x: 1, y: 2 },
};
expect(isClassInstanceRef(plainObj)).toBe(true);
});

it('should return true for JSON-parsed ClassInstanceRef', () => {
const ref = new ClassInstanceRef('Point', 'class//Point', { x: 1, y: 2 });
const parsed = JSON.parse(JSON.stringify(ref));
expect(isClassInstanceRef(parsed)).toBe(true);
});

it('should return false for null', () => {
expect(isClassInstanceRef(null)).toBe(false);
});

it('should return false for undefined', () => {
expect(isClassInstanceRef(undefined)).toBe(false);
});

it('should return false for plain objects without __type', () => {
expect(isClassInstanceRef({ className: 'Point', data: {} })).toBe(false);
});

it('should return false for objects with wrong __type', () => {
expect(
isClassInstanceRef({
__type: 'wrong_type',
className: 'Point',
data: {},
})
).toBe(false);
});

it('should return false for objects without className', () => {
expect(
isClassInstanceRef({
__type: CLASS_INSTANCE_REF_TYPE,
classId: 'class//Point',
data: {},
})
).toBe(false);
});
});

describe('isStreamRef', () => {
it('should return true for valid StreamRef', () => {
const streamRef = {
__type: STREAM_REF_TYPE,
streamId: 'strm_123',
};
expect(isStreamRef(streamRef)).toBe(true);
});

it('should return false for null', () => {
expect(isStreamRef(null)).toBe(false);
});

it('should return false for wrong __type', () => {
expect(isStreamRef({ __type: 'wrong', streamId: 'strm_123' })).toBe(false);
});
});

describe('isStreamId', () => {
it('should return true for valid stream ID', () => {
expect(isStreamId('strm_abc123')).toBe(true);
});

it('should return false for non-stream strings', () => {
expect(isStreamId('not_a_stream')).toBe(false);
});

it('should return false for non-strings', () => {
expect(isStreamId(123)).toBe(false);
expect(isStreamId(null)).toBe(false);
expect(isStreamId({})).toBe(false);
});
});

describe('extractStreamIds', () => {
it('should extract stream IDs from flat objects', () => {
const obj = { stream: 'strm_123', other: 'not_stream' };
expect(extractStreamIds(obj)).toEqual(['strm_123']);
});

it('should extract stream IDs from nested objects', () => {
const obj = {
level1: {
level2: {
stream: 'strm_abc',
},
},
};
expect(extractStreamIds(obj)).toEqual(['strm_abc']);
});

it('should extract stream IDs from arrays', () => {
const arr = ['strm_1', 'strm_2', 'not_stream'];
expect(extractStreamIds(arr)).toEqual(['strm_1', 'strm_2']);
});

it('should deduplicate stream IDs', () => {
const obj = { a: 'strm_same', b: 'strm_same' };
expect(extractStreamIds(obj)).toEqual(['strm_same']);
});

it('should return empty array for no streams', () => {
expect(extractStreamIds({ foo: 'bar' })).toEqual([]);
});
});

describe('truncateId', () => {
it('should not truncate short IDs', () => {
expect(truncateId('short', 12)).toBe('short');
});

it('should truncate long IDs', () => {
expect(truncateId('verylongidentifier', 12)).toBe('verylongiden...');
});

it('should use default max length of 12', () => {
expect(truncateId('123456789012')).toBe('123456789012');
expect(truncateId('1234567890123')).toBe('123456789012...');
});
});

describe('hydrateResourceIO with custom class instances', () => {
// Create a test class with serialization symbols
class TestPoint {
constructor(
public x: number,
public y: number
) {}

static [WORKFLOW_SERIALIZE](instance: TestPoint) {
return { x: instance.x, y: instance.y };
}

static [WORKFLOW_DESERIALIZE](data: { x: number; y: number }) {
return new TestPoint(data.x, data.y);
}
}

// Register the class for serialization (so dehydrate works)
// but note: in o11y context, classes are NOT registered, which is the point of this test
(TestPoint as any).classId = 'test//TestPoint';
registerSerializationClass('test//TestPoint', TestPoint);

it('should convert Instance type to ClassInstanceRef in step output', () => {
// Simulate serialized step data with a custom class instance
const point = new TestPoint(3, 4);
const serialized = dehydrateStepReturnValue(point, [], 'wrun_test');

// Create a step resource with serialized output
const step = {
stepId: 'step_123',
runId: 'wrun_test',
output: serialized,
};

// Hydrate the step - this should convert Instance to ClassInstanceRef
// because the class is not registered in the o11y context (streamPrintRevivers)
const hydrated = hydrateResourceIO(step);

// The output should be a ClassInstanceRef
expect(isClassInstanceRef(hydrated.output)).toBe(true);
expect(hydrated.output.className).toBe('TestPoint');
expect(hydrated.output.classId).toBe('test//TestPoint');
expect(hydrated.output.data).toEqual({ x: 3, y: 4 });
});

it('should preserve ClassInstanceRef through JSON roundtrip', () => {
const ref = new ClassInstanceRef('Point', 'class//Point', { x: 1, y: 2 });
const json = JSON.stringify(ref);
const parsed = JSON.parse(json);

// After parsing, it's a plain object but still recognized
expect(isClassInstanceRef(parsed)).toBe(true);
expect(parsed.className).toBe('Point');
expect(parsed.classId).toBe('class//Point');
expect(parsed.data).toEqual({ x: 1, y: 2 });
});
});
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/forty-tables-lick.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
---
"@workflow/web-shared": patch
"@workflow/core": patch
---

Show custom class serialization UI and class names in o11y
369 changes: 369 additions & 0 deletions packages/core/src/observability.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,369 @@
import { inspect } from 'node:util';
import { WORKFLOW_DESERIALIZE, WORKFLOW_SERIALIZE } from '@workflow/serde';
import { describe, expect, it } from 'vitest';
import { registerSerializationClass } from './class-serialization.js';
import {
CLASS_INSTANCE_REF_TYPE,
ClassInstanceRef,
extractStreamIds,
hydrateResourceIO,
isClassInstanceRef,
isStreamId,
isStreamRef,
STREAM_REF_TYPE,
truncateId,
} from './observability.js';
import { dehydrateStepReturnValue } from './serialization.js';

describe('ClassInstanceRef', () => {
describe('constructor and properties', () => {
it('should create instance with correct properties', () => {
const ref = new ClassInstanceRef('Point', 'class//file.ts//Point', {
x: 1,
y: 2,
});

expect(ref.className).toBe('Point');
expect(ref.classId).toBe('class//file.ts//Point');
expect(ref.data).toEqual({ x: 1, y: 2 });
expect(ref.__type).toBe(CLASS_INSTANCE_REF_TYPE);
});

it('should handle various data types', () => {
// Object data
const objRef = new ClassInstanceRef('Config', 'class//Config', {
key: 'value',
});
expect(objRef.data).toEqual({ key: 'value' });

// String data
const strRef = new ClassInstanceRef('Token', 'class//Token', 'abc123');
expect(strRef.data).toBe('abc123');

// Number data
const numRef = new ClassInstanceRef('Counter', 'class//Counter', 42);
expect(numRef.data).toBe(42);

// Null data
const nullRef = new ClassInstanceRef('Empty', 'class//Empty', null);
expect(nullRef.data).toBeNull();

// Array data
const arrRef = new ClassInstanceRef('List', 'class//List', [1, 2, 3]);
expect(arrRef.data).toEqual([1, 2, 3]);
});
});

describe('toJSON()', () => {
it('should return plain object representation', () => {
const ref = new ClassInstanceRef('Point', 'class//file.ts//Point', {
x: 1,
y: 2,
});

expect(ref.toJSON()).toEqual({
__type: CLASS_INSTANCE_REF_TYPE,
className: 'Point',
classId: 'class//file.ts//Point',
data: { x: 1, y: 2 },
});
});

it('should be used by JSON.stringify', () => {
const ref = new ClassInstanceRef('Point', 'class//file.ts//Point', {
x: 1,
y: 2,
});

const json = JSON.stringify(ref);
const parsed = JSON.parse(json);

expect(parsed).toEqual({
__type: CLASS_INSTANCE_REF_TYPE,
className: 'Point',
classId: 'class//file.ts//Point',
data: { x: 1, y: 2 },
});
});
});

describe('[inspect.custom]', () => {
it('should render as ClassName@filename { data }', () => {
const ref = new ClassInstanceRef(
'Point',
'class//workflows/user-signup.ts//Point',
{ x: 1, y: 2 }
);

const output = inspect(ref, { colors: false });
expect(output).toBe('Point@user-signup.ts { x: 1, y: 2 }');
});

it('should handle nested file paths', () => {
const ref = new ClassInstanceRef(
'Config',
'class//lib/models/config.ts//Config',
{ nested: { a: 1, b: 2 } }
);

const output = inspect(ref, { colors: false });
expect(output).toBe('Config@config.ts { nested: { a: 1, b: 2 } }');
});

it('should handle string data', () => {
const ref = new ClassInstanceRef(
'Token',
'class//auth/token.ts//Token',
'secret'
);

const output = inspect(ref, { colors: false });
expect(output).toBe("Token@token.ts 'secret'");
});

it('should handle null data', () => {
const ref = new ClassInstanceRef(
'Empty',
'class//utils/empty.ts//Empty',
null
);

const output = inspect(ref, { colors: false });
expect(output).toBe('Empty@empty.ts null');
});

it('should handle array data', () => {
const ref = new ClassInstanceRef(
'List',
'class//collections/list.ts//List',
[1, 2, 3]
);

const output = inspect(ref, { colors: false });
expect(output).toBe('List@list.ts [ 1, 2, 3 ]');
});

it('should handle simple classId format gracefully', () => {
// Fallback for non-standard classId format
const ref = new ClassInstanceRef('Point', 'test//TestPoint', {
x: 1,
y: 2,
});

const output = inspect(ref, { colors: false });
// Falls back to extracting just the last segment as filename
expect(output).toBe('Point@TestPoint { x: 1, y: 2 }');
});

it('should style @filename gray when colors are enabled', () => {
const ref = new ClassInstanceRef(
'Point',
'class//workflows/point.ts//Point',
{ x: 1, y: 2 }
);

const output = inspect(ref, { colors: true });
// When colors are enabled, the @filename should have ANSI escape codes
expect(output).toContain('Point');
// Check for ANSI escape codes (gray/dim styling for @filename)
expect(output).toMatch(/\x1b\[90m@point\.ts\x1b\[39m/);
// Data is also present (may have color codes for numbers)
expect(output).toContain('x:');
expect(output).toContain('y:');
});
});
});

describe('isClassInstanceRef', () => {
it('should return true for ClassInstanceRef instances', () => {
const ref = new ClassInstanceRef('Point', 'class//Point', { x: 1, y: 2 });
expect(isClassInstanceRef(ref)).toBe(true);
});

it('should return true for plain objects with correct structure', () => {
const plainObj = {
__type: CLASS_INSTANCE_REF_TYPE,
className: 'Point',
classId: 'class//Point',
data: { x: 1, y: 2 },
};
expect(isClassInstanceRef(plainObj)).toBe(true);
});

it('should return true for JSON-parsed ClassInstanceRef', () => {
const ref = new ClassInstanceRef('Point', 'class//Point', { x: 1, y: 2 });
const parsed = JSON.parse(JSON.stringify(ref));
expect(isClassInstanceRef(parsed)).toBe(true);
});

it('should return false for null', () => {
expect(isClassInstanceRef(null)).toBe(false);
});

it('should return false for undefined', () => {
expect(isClassInstanceRef(undefined)).toBe(false);
});

it('should return false for plain objects without __type', () => {
expect(isClassInstanceRef({ className: 'Point', data: {} })).toBe(false);
});

it('should return false for objects with wrong __type', () => {
expect(
isClassInstanceRef({
__type: 'wrong_type',
className: 'Point',
data: {},
})
).toBe(false);
});

it('should return false for objects without className', () => {
expect(
isClassInstanceRef({
__type: CLASS_INSTANCE_REF_TYPE,
classId: 'class//Point',
data: {},
})
).toBe(false);
});
});

describe('isStreamRef', () => {
it('should return true for valid StreamRef', () => {
const streamRef = {
__type: STREAM_REF_TYPE,
streamId: 'strm_123',
};
expect(isStreamRef(streamRef)).toBe(true);
});

it('should return false for null', () => {
expect(isStreamRef(null)).toBe(false);
});

it('should return false for wrong __type', () => {
expect(isStreamRef({ __type: 'wrong', streamId: 'strm_123' })).toBe(false);
});
});

describe('isStreamId', () => {
it('should return true for valid stream ID', () => {
expect(isStreamId('strm_abc123')).toBe(true);
});

it('should return false for non-stream strings', () => {
expect(isStreamId('not_a_stream')).toBe(false);
});

it('should return false for non-strings', () => {
expect(isStreamId(123)).toBe(false);
expect(isStreamId(null)).toBe(false);
expect(isStreamId({})).toBe(false);
});
});

describe('extractStreamIds', () => {
it('should extract stream IDs from flat objects', () => {
const obj = { stream: 'strm_123', other: 'not_stream' };
expect(extractStreamIds(obj)).toEqual(['strm_123']);
});

it('should extract stream IDs from nested objects', () => {
const obj = {
level1: {
level2: {
stream: 'strm_abc',
},
},
};
expect(extractStreamIds(obj)).toEqual(['strm_abc']);
});

it('should extract stream IDs from arrays', () => {
const arr = ['strm_1', 'strm_2', 'not_stream'];
expect(extractStreamIds(arr)).toEqual(['strm_1', 'strm_2']);
});

it('should deduplicate stream IDs', () => {
const obj = { a: 'strm_same', b: 'strm_same' };
expect(extractStreamIds(obj)).toEqual(['strm_same']);
});

it('should return empty array for no streams', () => {
expect(extractStreamIds({ foo: 'bar' })).toEqual([]);
});
});

describe('truncateId', () => {
it('should not truncate short IDs', () => {
expect(truncateId('short', 12)).toBe('short');
});

it('should truncate long IDs', () => {
expect(truncateId('verylongidentifier', 12)).toBe('verylongiden...');
});

it('should use default max length of 12', () => {
expect(truncateId('123456789012')).toBe('123456789012');
expect(truncateId('1234567890123')).toBe('123456789012...');
});
});

describe('hydrateResourceIO with custom class instances', () => {
// Create a test class with serialization symbols
class TestPoint {
constructor(
public x: number,
public y: number
) {}

static [WORKFLOW_SERIALIZE](instance: TestPoint) {
return { x: instance.x, y: instance.y };
}

static [WORKFLOW_DESERIALIZE](data: { x: number; y: number }) {
return new TestPoint(data.x, data.y);
}
}

// Register the class for serialization (so dehydrate works)
// but note: in o11y context, classes are NOT registered, which is the point of this test
(TestPoint as any).classId = 'test//TestPoint';
registerSerializationClass('test//TestPoint', TestPoint);

it('should convert Instance type to ClassInstanceRef in step output', () => {
// Simulate serialized step data with a custom class instance
const point = new TestPoint(3, 4);
const serialized = dehydrateStepReturnValue(point, [], 'wrun_test');

// Create a step resource with serialized output
const step = {
stepId: 'step_123',
runId: 'wrun_test',
output: serialized,
};

// Hydrate the step - this should convert Instance to ClassInstanceRef
// because the class is not registered in the o11y context (streamPrintRevivers)
const hydrated = hydrateResourceIO(step);

// The output should be a ClassInstanceRef
expect(isClassInstanceRef(hydrated.output)).toBe(true);
expect(hydrated.output.className).toBe('TestPoint');
expect(hydrated.output.classId).toBe('test//TestPoint');
expect(hydrated.output.data).toEqual({ x: 3, y: 4 });
});

it('should preserve ClassInstanceRef through JSON roundtrip', () => {
const ref = new ClassInstanceRef('Point', 'class//Point', { x: 1, y: 2 });
const json = JSON.stringify(ref);
const parsed = JSON.parse(json);

// After parsing, it's a plain object but still recognized
expect(isClassInstanceRef(parsed)).toBe(true);
expect(parsed.className).toBe('Point');
expect(parsed.classId).toBe('class//Point');
expect(parsed.data).toEqual({ x: 1, y: 2 });
});
});
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/forty-tables-lick.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
---
"@workflow/web-shared": patch
"@workflow/core": patch
---

Show custom class serialization UI and class names in o11y
369 changes: 369 additions & 0 deletions packages/core/src/observability.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,369 @@
import { inspect } from 'node:util';
import { WORKFLOW_DESERIALIZE, WORKFLOW_SERIALIZE } from '@workflow/serde';
import { describe, expect, it } from 'vitest';
import { registerSerializationClass } from './class-serialization.js';
import {
CLASS_INSTANCE_REF_TYPE,
ClassInstanceRef,
extractStreamIds,
hydrateResourceIO,
isClassInstanceRef,
isStreamId,
isStreamRef,
STREAM_REF_TYPE,
truncateId,
} from './observability.js';
import { dehydrateStepReturnValue } from './serialization.js';

describe('ClassInstanceRef', () => {
describe('constructor and properties', () => {
it('should create instance with correct properties', () => {
const ref = new ClassInstanceRef('Point', 'class//file.ts//Point', {
x: 1,
y: 2,
});

expect(ref.className).toBe('Point');
expect(ref.classId).toBe('class//file.ts//Point');
expect(ref.data).toEqual({ x: 1, y: 2 });
expect(ref.__type).toBe(CLASS_INSTANCE_REF_TYPE);
});

it('should handle various data types', () => {
// Object data
const objRef = new ClassInstanceRef('Config', 'class//Config', {
key: 'value',
});
expect(objRef.data).toEqual({ key: 'value' });

// String data
const strRef = new ClassInstanceRef('Token', 'class//Token', 'abc123');
expect(strRef.data).toBe('abc123');

// Number data
const numRef = new ClassInstanceRef('Counter', 'class//Counter', 42);
expect(numRef.data).toBe(42);

// Null data
const nullRef = new ClassInstanceRef('Empty', 'class//Empty', null);
expect(nullRef.data).toBeNull();

// Array data
const arrRef = new ClassInstanceRef('List', 'class//List', [1, 2, 3]);
expect(arrRef.data).toEqual([1, 2, 3]);
});
});

describe('toJSON()', () => {
it('should return plain object representation', () => {
const ref = new ClassInstanceRef('Point', 'class//file.ts//Point', {
x: 1,
y: 2,
});

expect(ref.toJSON()).toEqual({
__type: CLASS_INSTANCE_REF_TYPE,
className: 'Point',
classId: 'class//file.ts//Point',
data: { x: 1, y: 2 },
});
});

it('should be used by JSON.stringify', () => {
const ref = new ClassInstanceRef('Point', 'class//file.ts//Point', {
x: 1,
y: 2,
});

const json = JSON.stringify(ref);
const parsed = JSON.parse(json);

expect(parsed).toEqual({
__type: CLASS_INSTANCE_REF_TYPE,
className: 'Point',
classId: 'class//file.ts//Point',
data: { x: 1, y: 2 },
});
});
});

describe('[inspect.custom]', () => {
it('should render as ClassName@filename { data }', () => {
const ref = new ClassInstanceRef(
'Point',
'class//workflows/user-signup.ts//Point',
{ x: 1, y: 2 }
);

const output = inspect(ref, { colors: false });
expect(output).toBe('Point@user-signup.ts { x: 1, y: 2 }');
});

it('should handle nested file paths', () => {
const ref = new ClassInstanceRef(
'Config',
'class//lib/models/config.ts//Config',
{ nested: { a: 1, b: 2 } }
);

const output = inspect(ref, { colors: false });
expect(output).toBe('Config@config.ts { nested: { a: 1, b: 2 } }');
});

it('should handle string data', () => {
const ref = new ClassInstanceRef(
'Token',
'class//auth/token.ts//Token',
'secret'
);

const output = inspect(ref, { colors: false });
expect(output).toBe("Token@token.ts 'secret'");
});

it('should handle null data', () => {
const ref = new ClassInstanceRef(
'Empty',
'class//utils/empty.ts//Empty',
null
);

const output = inspect(ref, { colors: false });
expect(output).toBe('Empty@empty.ts null');
});

it('should handle array data', () => {
const ref = new ClassInstanceRef(
'List',
'class//collections/list.ts//List',
[1, 2, 3]
);

const output = inspect(ref, { colors: false });
expect(output).toBe('List@list.ts [ 1, 2, 3 ]');
});

it('should handle simple classId format gracefully', () => {
// Fallback for non-standard classId format
const ref = new ClassInstanceRef('Point', 'test//TestPoint', {
x: 1,
y: 2,
});

const output = inspect(ref, { colors: false });
// Falls back to extracting just the last segment as filename
expect(output).toBe('Point@TestPoint { x: 1, y: 2 }');
});

it('should style @filename gray when colors are enabled', () => {
const ref = new ClassInstanceRef(
'Point',
'class//workflows/point.ts//Point',
{ x: 1, y: 2 }
);

const output = inspect(ref, { colors: true });
// When colors are enabled, the @filename should have ANSI escape codes
expect(output).toContain('Point');
// Check for ANSI escape codes (gray/dim styling for @filename)
expect(output).toMatch(/\x1b\[90m@point\.ts\x1b\[39m/);
// Data is also present (may have color codes for numbers)
expect(output).toContain('x:');
expect(output).toContain('y:');
});
});
});

describe('isClassInstanceRef', () => {
it('should return true for ClassInstanceRef instances', () => {
const ref = new ClassInstanceRef('Point', 'class//Point', { x: 1, y: 2 });
expect(isClassInstanceRef(ref)).toBe(true);
});

it('should return true for plain objects with correct structure', () => {
const plainObj = {
__type: CLASS_INSTANCE_REF_TYPE,
className: 'Point',
classId: 'class//Point',
data: { x: 1, y: 2 },
};
expect(isClassInstanceRef(plainObj)).toBe(true);
});

it('should return true for JSON-parsed ClassInstanceRef', () => {
const ref = new ClassInstanceRef('Point', 'class//Point', { x: 1, y: 2 });
const parsed = JSON.parse(JSON.stringify(ref));
expect(isClassInstanceRef(parsed)).toBe(true);
});

it('should return false for null', () => {
expect(isClassInstanceRef(null)).toBe(false);
});

it('should return false for undefined', () => {
expect(isClassInstanceRef(undefined)).toBe(false);
});

it('should return false for plain objects without __type', () => {
expect(isClassInstanceRef({ className: 'Point', data: {} })).toBe(false);
});

it('should return false for objects with wrong __type', () => {
expect(
isClassInstanceRef({
__type: 'wrong_type',
className: 'Point',
data: {},
})
).toBe(false);
});

it('should return false for objects without className', () => {
expect(
isClassInstanceRef({
__type: CLASS_INSTANCE_REF_TYPE,
classId: 'class//Point',
data: {},
})
).toBe(false);
});
});

describe('isStreamRef', () => {
it('should return true for valid StreamRef', () => {
const streamRef = {
__type: STREAM_REF_TYPE,
streamId: 'strm_123',
};
expect(isStreamRef(streamRef)).toBe(true);
});

it('should return false for null', () => {
expect(isStreamRef(null)).toBe(false);
});

it('should return false for wrong __type', () => {
expect(isStreamRef({ __type: 'wrong', streamId: 'strm_123' })).toBe(false);
});
});

describe('isStreamId', () => {
it('should return true for valid stream ID', () => {
expect(isStreamId('strm_abc123')).toBe(true);
});

it('should return false for non-stream strings', () => {
expect(isStreamId('not_a_stream')).toBe(false);
});

it('should return false for non-strings', () => {
expect(isStreamId(123)).toBe(false);
expect(isStreamId(null)).toBe(false);
expect(isStreamId({})).toBe(false);
});
});

describe('extractStreamIds', () => {
it('should extract stream IDs from flat objects', () => {
const obj = { stream: 'strm_123', other: 'not_stream' };
expect(extractStreamIds(obj)).toEqual(['strm_123']);
});

it('should extract stream IDs from nested objects', () => {
const obj = {
level1: {
level2: {
stream: 'strm_abc',
},
},
};
expect(extractStreamIds(obj)).toEqual(['strm_abc']);
});

it('should extract stream IDs from arrays', () => {
const arr = ['strm_1', 'strm_2', 'not_stream'];
expect(extractStreamIds(arr)).toEqual(['strm_1', 'strm_2']);
});

it('should deduplicate stream IDs', () => {
const obj = { a: 'strm_same', b: 'strm_same' };
expect(extractStreamIds(obj)).toEqual(['strm_same']);
});

it('should return empty array for no streams', () => {
expect(extractStreamIds({ foo: 'bar' })).toEqual([]);
});
});

describe('truncateId', () => {
it('should not truncate short IDs', () => {
expect(truncateId('short', 12)).toBe('short');
});

it('should truncate long IDs', () => {
expect(truncateId('verylongidentifier', 12)).toBe('verylongiden...');
});

it('should use default max length of 12', () => {
expect(truncateId('123456789012')).toBe('123456789012');
expect(truncateId('1234567890123')).toBe('123456789012...');
});
});

describe('hydrateResourceIO with custom class instances', () => {
// Create a test class with serialization symbols
class TestPoint {
constructor(
public x: number,
public y: number
) {}

static [WORKFLOW_SERIALIZE](instance: TestPoint) {
return { x: instance.x, y: instance.y };
}

static [WORKFLOW_DESERIALIZE](data: { x: number; y: number }) {
return new TestPoint(data.x, data.y);
}
}

// Register the class for serialization (so dehydrate works)
// but note: in o11y context, classes are NOT registered, which is the point of this test
(TestPoint as any).classId = 'test//TestPoint';
registerSerializationClass('test//TestPoint', TestPoint);

it('should convert Instance type to ClassInstanceRef in step output', () => {
// Simulate serialized step data with a custom class instance
const point = new TestPoint(3, 4);
const serialized = dehydrateStepReturnValue(point, [], 'wrun_test');

// Create a step resource with serialized output
const step = {
stepId: 'step_123',
runId: 'wrun_test',
output: serialized,
};

// Hydrate the step - this should convert Instance to ClassInstanceRef
// because the class is not registered in the o11y context (streamPrintRevivers)
const hydrated = hydrateResourceIO(step);

// The output should be a ClassInstanceRef
expect(isClassInstanceRef(hydrated.output)).toBe(true);
expect(hydrated.output.className).toBe('TestPoint');
expect(hydrated.output.classId).toBe('test//TestPoint');
expect(hydrated.output.data).toEqual({ x: 3, y: 4 });
});

it('should preserve ClassInstanceRef through JSON roundtrip', () => {
const ref = new ClassInstanceRef('Point', 'class//Point', { x: 1, y: 2 });
const json = JSON.stringify(ref);
const parsed = JSON.parse(json);

// After parsing, it's a plain object but still recognized
expect(isClassInstanceRef(parsed)).toBe(true);
expect(parsed.className).toBe('Point');
expect(parsed.classId).toBe('class//Point');
expect(parsed.data).toEqual({ x: 1, y: 2 });
});
});
Loading
Loading