Uh oh!
There was an error while loading. Please reload this page.
Revert "Update docs template (#552)" - #883
Closed
pranaygp wants to merge 1 commit into
Closed
Conversation
This reverts commit 9ec2158.
Contributor
|
Contributor
🧪 E2E Test Results❌ Some tests failed Summary
❌ Failed Tests🌍 Community Worlds (161 failed)mongodb (40 failed):
redis (40 failed):
starter (41 failed):
turso (40 failed):
Details by Category✅ ▲ Vercel Production
✅ 💻 Local Development
✅ 📦 Local Production
✅ 🐘 Local Postgres
✅ 🪟 Windows
❌ 🌍 Community Worlds
✅ 📋 Other
|
Contributor
📊 Benchmark Results
workflow with no steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express workflow with 1 step💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express workflow with 10 sequential steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express Promise.all with 10 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express Promise.all with 25 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express Promise.race with 10 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express Promise.race with 25 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express Stream Benchmarks(includes TTFB metrics)workflow with stream💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express SummaryFastest Framework by WorldWinner determined by most benchmark wins
Fastest World by FrameworkWinner determined by most benchmark wins
Column Definitions
Worlds:
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
| sendFeedback(url, feedback).then(() => { | ||
| setSubmitted(true); | ||
| sendFeedback(url, feedback).then((response) => { |
Contributor
There was a problem hiding this comment.
Missing .catch() handler for sendFeedback server action causes unhandled promise rejections when feedback submission fails
| isActive(item.href) && 'text-primary' | ||
| )} | ||
| > | ||
| <Link href={item.href}>{item.label}</Link> |
Contributor
There was a problem hiding this comment.
External links in desktop navigation menu are rendered using Next.js Link component, causing them to navigate away from the page instead of opening in a new tab.
Contributor
There was a problem hiding this comment.
Pull request overview
Reverts the docs template update introduced in #552 by removing i18n routing/support and returning the docs app to a flat (non-[lang]) route structure while preserving the sitemap matcher exclusion from #879.
Changes:
- Remove i18n middleware/config, language selector UI, and
[lang]route tree; reintroduce flat/docs,/worlds,/llms.*routes. - Refactor docs shell components (navbar/provider/sidebar/search/docs layout) to match the non-i18n routing model.
- Add/restore home + worlds pages/components and supporting endpoints (RSS/LLMs/feedback/search/chat) aligned with the reverted template structure.
Reviewed changes
Copilot reviewed 70 out of 90 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| workbench/nest/package.json | Removes SWC dev dependencies as part of reverting the prior template/tooling changes. |
| docs/tsconfig.json | Adjusts TS paths/includes to match the flat docs structure and .source entrypoint. |
| docs/source.config.ts | Removes last-modified plugin usage from the MDX source config. |
| docs/proxy.ts | Simplifies markdown-preference rewrite behavior and keeps sitemap matcher exclusion. |
| docs/package.json | Removes translation deps/scripts and aligns versions back with pre-i18n template. |
| docs/next.config.ts | Removes experimental config and simplifies redirects/rewrite definitions. |
| docs/lib/utils.ts | Minor import ordering change. |
| docs/lib/geistdocs/source.ts | Drops i18n wiring and adds helpers for OG image + LLM text. |
| docs/lib/geistdocs/i18n.ts | Removes i18n configuration module. |
| docs/lib/geistdocs/db.ts | Renames chat Dexie DB initialization to a fixed name. |
| docs/hooks/geistdocs/use-sidebar.ts | Removes custom sidebar state hook (moving to fumadocs sidebar context). |
| docs/hooks/geistdocs/use-chat.ts | Removes persisted chat-open state and uses an in-memory atom. |
| docs/content/guides/meta.json | Adds guides meta for page tree organization. |
| docs/content/docs/getting-started/vite.mdx | Converts markdown image syntax to explicit <img> usage. |
| docs/content/docs/getting-started/sveltekit.mdx | Converts markdown image syntax to explicit <img> usage. |
| docs/content/docs/getting-started/nuxt.mdx | Converts markdown image syntax to explicit <img> usage. |
| docs/content/docs/getting-started/nitro.mdx | Converts markdown image syntax to explicit <img> usage. |
| docs/content/docs/getting-started/next.mdx | Converts markdown image syntax to explicit <img> usage. |
| docs/content/docs/getting-started/hono.mdx | Converts markdown image syntax to explicit <img> usage. |
| docs/content/docs/getting-started/fastify.mdx | Converts markdown image syntax to explicit <img> usage. |
| docs/content/docs/getting-started/express.mdx | Converts markdown image syntax to explicit <img> usage. |
| docs/content/docs/getting-started/astro.mdx | Converts markdown image syntax to explicit <img> usage. |
| docs/content/docs/getting-started/meta.json | Adds section meta for “Getting Started” ordering/defaultOpen. |
| docs/content/docs/getting-started/index.mdx | Updates import path to non-[lang] home components. |
| docs/components/geistdocs/video.tsx | Adjusts wrapper class list for the video component. |
| docs/components/geistdocs/toc.tsx | Adds TOC wrapper component that reacts to chat sidebar visibility. |
| docs/components/geistdocs/sidebar.tsx | Replaces fumadocs sidebar components with custom Collapsible-based rendering. |
| docs/components/geistdocs/search.tsx | Removes basePath plumbing and adds mobile icon-only search button. |
| docs/components/geistdocs/provider.tsx | Removes i18n/basePath wiring and simplifies search provider injection. |
| docs/components/geistdocs/navbar.tsx | Refactors navbar to accept links/logo children; removes [lang] routing. |
| docs/components/geistdocs/mobile-menu.tsx | Switches to fumadocs useSidebar() context instead of custom hook. |
| docs/components/geistdocs/message-metadata.tsx | Small markup simplification for “Thinking…” UI. |
| docs/components/geistdocs/mdx-components.tsx | Removes [lang]-aware link rewriting; uses plain anchors. |
| docs/components/geistdocs/language-selector.tsx | Removes language selector UI. |
| docs/components/geistdocs/installer.tsx | Removes configurable input width and uses default styling. |
| docs/components/geistdocs/home-layout.tsx | Switches home layout to use source.pageTree without i18n. |
| docs/components/geistdocs/github-button.tsx | Reads repo/owner from env vars instead of imported config. |
| docs/components/geistdocs/footer.tsx | Removes footer (including language selector). |
| docs/components/geistdocs/feedback.tsx | Adds persistence + “View on GitHub” flow for feedback submissions. |
| docs/components/geistdocs/edit-source.tsx | Updates edit-source URL to new docs content path and env-based repo config. |
| docs/components/geistdocs/docs-page.tsx | Wraps docs page rendering with source.getPage() + metadata/static params helpers. |
| docs/components/geistdocs/docs-layout.tsx | Updates docs layout grid/sidebar config and uses source.pageTree. |
| docs/components/geistdocs/desktop-menu.tsx | Switches to next/link and adds active-link styling logic. |
| docs/components/geistdocs/chat.tsx | Removes basePath transport override and simplifies message rendering pipeline. |
| docs/app/worlds/page.tsx | Adds /worlds landing page for worlds directory listing. |
| docs/app/worlds/layout.tsx | Adds layout wrapper for /worlds routes. |
| docs/app/worlds/compare/page.tsx | Adds /worlds/compare benchmark comparison page. |
| docs/app/worlds/[id]/page.tsx | Adds per-world detail page with optional embedded MDX for official worlds. |
| docs/app/worlds/[id]/opengraph-image.tsx | Adds per-world OG image generation route. |
| docs/app/styles/geistdocs.css | Moves most global theme setup out (now primarily contains custom layers/patches). |
| docs/app/rss.xml/route.ts | Removes i18n params and generates RSS for all pages with fixed language. |
| docs/app/llms.txt/route.ts | Adds flat llms.txt route for aggregated LLM text. |
| docs/app/llms.mdx/[[...slug]]/route.ts | Removes i18n params and updates to flat route context. |
| docs/app/layout.tsx | Replaces [lang] root layout with non-i18n layout and nav config. |
| docs/app/global.css | Reintroduces fumadocs/shadcn/tw-animate imports and theme variables globally. |
| docs/app/docs/layout.tsx | Adds flat /docs layout wrapper. |
| docs/app/docs/[[...slug]]/page.tsx | Updates docs page routing to non-i18n paths and new TOC component usage. |
| docs/app/api/search/route.ts | Removes locale-aware tokenizers and uses a single English search config. |
| docs/app/api/chat/utils.ts | Simplifies system prompt generation and removes appended prompt constant. |
| docs/app/api/chat/tools.ts | Removes i18n from tooling and builds a single search index for all docs pages. |
| docs/app/api/chat/route.ts | Updates model/provider options and removes forced initial tool call. |
| docs/app/actions/feedback/index.ts | Replaces external feedback endpoint with GitHub Discussions via GitHub App auth. |
| docs/app/actions/feedback/emotions.ts | Updates emotion names/emojis used by feedback UI. |
| docs/app/[lang]/worlds/layout.tsx | Removes i18n worlds layout. |
| docs/app/[lang]/llms.txt/route.ts | Removes i18n llms.txt route. |
| docs/app/[lang]/layout.tsx | Removes i18n root layout. |
| docs/app/[lang]/docs/layout.tsx | Removes i18n docs layout. |
| docs/app/[lang]/(home)/layout.tsx | Removes i18n home layout. |
| docs/app/(home)/page.tsx | Adds non-i18n home page entrypoint. |
| docs/app/(home)/layout.tsx | Adds non-i18n home layout wrapper. |
| docs/app/(home)/components/use-cases-server.tsx | Updates import paths to non-[lang] code-block component. |
| docs/app/(home)/components/use-cases-client.tsx | Adds client-side selector with analytics tracking for use-case examples. |
| docs/app/(home)/components/templates/index.tsx | Adds “Templates” section component for the home page. |
| docs/app/(home)/components/templates/flight.png | Adds template screenshot asset. |
| docs/app/(home)/components/run-anywhere.tsx | Updates import paths to non-[lang] code-block component. |
| docs/app/(home)/components/observability.tsx | Adds animated observability visualization section. |
| docs/app/(home)/components/intro/workflow.tsx | Adds “with Workflow DevKit” animated example component. |
| docs/app/(home)/components/intro/workflow-logs.tsx | Adds animated log line component used by intro examples. |
| docs/app/(home)/components/intro/non-workflow.tsx | Adds “without Workflow DevKit” animated example component. |
| docs/app/(home)/components/intro/intro.tsx | Updates import paths to non-[lang] code-block component. |
| docs/app/(home)/components/intro/intro-tabs.tsx | Adds tab UI (with analytics) for switching intro examples. |
| docs/app/(home)/components/implementation.tsx | Updates import paths to non-[lang] code-block component. |
| docs/app/(home)/components/hero.tsx | Adds new home hero section with copy-to-clipboard behavior. |
| docs/app/(home)/components/features.tsx | Adds features grid section for home page. |
| docs/app/(home)/components/cta.tsx | Updates CTA markup for the home page. |
| docs/app/(home)/components/code-block.tsx | Adds server-rendered Shiki code block component for home sections. |
Comments suppressed due to low confidence (1)
docs/app/(home)/components/cta.tsx:10
- JSX has duplicate
classNameprops on the Button (classNameis specified twice), which will fail TSX compilation. Combine the classes into a singleclassNameprop (and keepasChild/sizeas separate props).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+57
to
60
| const submit = (e?: SyntheticEvent) => { | ||
| if (emotion == null) { | ||
| return; | ||
| } |
There was a problem hiding this comment.
submit returns early when emotion is null, but only calls preventDefault() at the end. When invoked via form submit/Enter key, this can trigger a real form submission (page navigation/reload). Call e.preventDefault() at the start of submit (when e is provided) before any early returns, and/or keep the submit button disabled until required fields are set.
Comment on lines
41
to
45
| return; | ||
| } | ||
| setSubmitted(true); | ||
| setPrevious(JSON.parse(item) as Result); | ||
| }, [url]); |
There was a problem hiding this comment.
JSON.parse(item) can throw and/or return a non-object (e.g., legacy values like "true"), which can put previous into an unexpected shape and break later logic. Wrap parsing in try/catch and validate the parsed value before calling setPrevious.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[lang]directory structure to flat structureNote: Conflicts with #879 (sitemap.xml fix) were resolved by preserving the sitemap.xml matcher exclusion while reverting the i18n changes.
🤖 Generated with Claude Code