Skip to content

Fix discovery of serde classes to detect [WORKFLOW_SERIALIZE] and [WORKFLOW_DESERIALIZE] computed property usage in bundled code - #908

Merged
TooTallNate merged 2 commits into
mainfrom
01-30-fix_discovery_of_serde_classes_to_detect_workflow_serialize_and_workflow_deserialize_computed_property_usage_in_bundled_code
Feb 9, 2026
Merged

Fix discovery of serde classes to detect [WORKFLOW_SERIALIZE] and [WORKFLOW_DESERIALIZE] computed property usage in bundled code#908
TooTallNate merged 2 commits into
mainfrom
01-30-fix_discovery_of_serde_classes_to_detect_workflow_serialize_and_workflow_deserialize_computed_property_usage_in_bundled_code

Conversation

@TooTallNate

@TooTallNateTooTallNate commented Jan 30, 2026

Copy link
Copy Markdown
Member

Fix detection of serializable classes in bundled code by recognizing computed property usage of [WORKFLOW_SERIALIZE] and [WORKFLOW_DESERIALIZE].

What changed?

  • Added a new regex pattern workflowSerdeComputedPropertyPattern to detect computed property usage of WORKFLOW_SERIALIZE and WORKFLOW_DESERIALIZE symbols
  • Updated detectWorkflowPatterns to identify serializable classes based on this pattern
  • Modified the turbopackContentPattern to include the new pattern for content matching
  • Added serializable files to the bundle entries to ensure proper discovery
  • Fixed method invocation context in serialization by using call() to ensure the class constructor is the this value

How to test?

  1. Create a bundled package that uses WORKFLOW_SERIALIZE and WORKFLOW_DESERIALIZE as computed properties
  2. Verify that the builder correctly identifies these files as containing serializable classes
  3. Confirm that serialization and deserialization work correctly with the proper this context

Why make this change?

When third-party packages are bundled, the standard import pattern detection for @workflow/serde fails because imports are often from internal chunk files rather than directly from the package. This change ensures that serializable classes are properly detected even in bundled code by looking for the actual computed property usage pattern, improving compatibility with bundled dependencies.

@changeset-bot

changeset-botBot commented Jan 30, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 52c4669

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 14 packages
NameType
@workflow/buildersPatch
@workflow/astroPatch
@workflow/cliPatch
@workflow/nestPatch
@workflow/nextPatch
@workflow/nitroPatch
@workflow/rollupPatch
@workflow/sveltekitPatch
@workflow/vitePatch
workflowPatch
@workflow/world-testingPatch
@workflow/nuxtPatch
@workflow/corePatch
@workflow/web-sharedPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions

github-actionsBot commented Jan 30, 2026

Copy link
Copy Markdown
Contributor

🧪 E2E Test Results

Some tests failed

Summary

PassedFailedSkippedTotal
✅ ▲ Vercel Production490038528
✅ 💻 Local Development418062480
✅ 📦 Local Production418062480
✅ 🐘 Local Postgres418062480
✅ 🪟 Windows450348
❌ 🌍 Community Worlds3515712204
✅ 📋 Other123021144
Total19471572602364

❌ Failed Tests

🌍 Community Worlds (157 failed)

mongodb (37 failed):

  • addTenWorkflow
  • addTenWorkflow
  • should work with react rendering in step
  • promiseAllWorkflow
  • promiseRaceWorkflow
  • promiseAnyWorkflow
  • hookWorkflow
  • webhookWorkflow
  • sleepingWorkflow
  • nullByteWorkflow
  • workflowAndStepMetadataWorkflow
  • fetchWorkflow
  • promiseRaceStressTestWorkflow
  • error handling error propagation workflow errors nested function calls preserve message and stack trace
  • error handling error propagation workflow errors cross-file imports preserve message and stack trace
  • error handling error propagation step errors basic step error preserves message and stack trace
  • error handling error propagation step errors cross-file step error preserves message and function names in stack
  • error handling retry behavior regular Error retries until success
  • error handling retry behavior FatalError fails immediately without retries
  • error handling retry behavior RetryableError respects custom retryAfter delay
  • error handling retry behavior maxRetries=0 disables retries
  • error handling catchability FatalError can be caught and detected with FatalError.is()
  • hookCleanupTestWorkflow - hook token reuse after workflow completion
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously
  • stepFunctionPassingWorkflow - step function references can be passed as arguments (without closure vars)
  • stepFunctionWithClosureWorkflow - step function with closure variables passed as argument
  • closureVariableWorkflow - nested step functions with closure variables
  • spawnWorkflowFromStepWorkflow - spawning a child workflow using start() inside a step
  • pathsAliasWorkflow - TypeScript path aliases resolve correctly
  • Calculator.calculate - static workflow method using static step methods from another class
  • AllInOneService.processNumber - static workflow method using sibling static step methods
  • ChainableService.processWithThis - static step methods using this to reference the class
  • thisSerializationWorkflow - step function invoked with .call() and .apply()
  • customSerializationWorkflow - custom class serialization with WORKFLOW_SERIALIZE/WORKFLOW_DESERIALIZE
  • instanceMethodStepWorkflow - instance methods with "use step" directive
  • crossContextSerdeWorkflow - classes defined in step code are deserializable in workflow context
  • stepFunctionAsStartArgWorkflow - step function reference passed as start() argument

redis (37 failed):

  • addTenWorkflow
  • addTenWorkflow
  • should work with react rendering in step
  • promiseAllWorkflow
  • promiseRaceWorkflow
  • promiseAnyWorkflow
  • hookWorkflow
  • webhookWorkflow
  • sleepingWorkflow
  • nullByteWorkflow
  • workflowAndStepMetadataWorkflow
  • fetchWorkflow
  • promiseRaceStressTestWorkflow
  • error handling error propagation workflow errors nested function calls preserve message and stack trace
  • error handling error propagation workflow errors cross-file imports preserve message and stack trace
  • error handling error propagation step errors basic step error preserves message and stack trace
  • error handling error propagation step errors cross-file step error preserves message and function names in stack
  • error handling retry behavior regular Error retries until success
  • error handling retry behavior FatalError fails immediately without retries
  • error handling retry behavior RetryableError respects custom retryAfter delay
  • error handling retry behavior maxRetries=0 disables retries
  • error handling catchability FatalError can be caught and detected with FatalError.is()
  • hookCleanupTestWorkflow - hook token reuse after workflow completion
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously
  • stepFunctionPassingWorkflow - step function references can be passed as arguments (without closure vars)
  • stepFunctionWithClosureWorkflow - step function with closure variables passed as argument
  • closureVariableWorkflow - nested step functions with closure variables
  • spawnWorkflowFromStepWorkflow - spawning a child workflow using start() inside a step
  • pathsAliasWorkflow - TypeScript path aliases resolve correctly
  • Calculator.calculate - static workflow method using static step methods from another class
  • AllInOneService.processNumber - static workflow method using sibling static step methods
  • ChainableService.processWithThis - static step methods using this to reference the class
  • thisSerializationWorkflow - step function invoked with .call() and .apply()
  • customSerializationWorkflow - custom class serialization with WORKFLOW_SERIALIZE/WORKFLOW_DESERIALIZE
  • instanceMethodStepWorkflow - instance methods with "use step" directive
  • crossContextSerdeWorkflow - classes defined in step code are deserializable in workflow context
  • stepFunctionAsStartArgWorkflow - step function reference passed as start() argument

starter (42 failed):

  • addTenWorkflow
  • addTenWorkflow
  • should work with react rendering in step
  • promiseAllWorkflow
  • promiseRaceWorkflow
  • promiseAnyWorkflow
  • hookWorkflow
  • webhookWorkflow
  • sleepingWorkflow
  • nullByteWorkflow
  • workflowAndStepMetadataWorkflow
  • fetchWorkflow
  • promiseRaceStressTestWorkflow
  • error handling error propagation workflow errors nested function calls preserve message and stack trace
  • error handling error propagation workflow errors cross-file imports preserve message and stack trace
  • error handling error propagation step errors basic step error preserves message and stack trace
  • error handling error propagation step errors cross-file step error preserves message and function names in stack
  • error handling retry behavior regular Error retries until success
  • error handling retry behavior FatalError fails immediately without retries
  • error handling retry behavior RetryableError respects custom retryAfter delay
  • error handling retry behavior maxRetries=0 disables retries
  • error handling catchability FatalError can be caught and detected with FatalError.is()
  • hookCleanupTestWorkflow - hook token reuse after workflow completion
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously
  • stepFunctionPassingWorkflow - step function references can be passed as arguments (without closure vars)
  • stepFunctionWithClosureWorkflow - step function with closure variables passed as argument
  • closureVariableWorkflow - nested step functions with closure variables
  • spawnWorkflowFromStepWorkflow - spawning a child workflow using start() inside a step
  • health check (queue-based) - workflow and step endpoints respond to health check messages
  • health check (CLI) - workflow health command reports healthy endpoints
  • pathsAliasWorkflow - TypeScript path aliases resolve correctly
  • Calculator.calculate - static workflow method using static step methods from another class
  • AllInOneService.processNumber - static workflow method using sibling static step methods
  • ChainableService.processWithThis - static step methods using this to reference the class
  • thisSerializationWorkflow - step function invoked with .call() and .apply()
  • customSerializationWorkflow - custom class serialization with WORKFLOW_SERIALIZE/WORKFLOW_DESERIALIZE
  • instanceMethodStepWorkflow - instance methods with "use step" directive
  • crossContextSerdeWorkflow - classes defined in step code are deserializable in workflow context
  • stepFunctionAsStartArgWorkflow - step function reference passed as start() argument
  • pages router addTenWorkflow via pages router
  • pages router promiseAllWorkflow via pages router
  • pages router sleepingWorkflow via pages router

turso (41 failed):

  • addTenWorkflow
  • addTenWorkflow
  • should work with react rendering in step
  • promiseAllWorkflow
  • promiseRaceWorkflow
  • promiseAnyWorkflow
  • hookWorkflow
  • webhookWorkflow
  • sleepingWorkflow
  • nullByteWorkflow
  • workflowAndStepMetadataWorkflow
  • fetchWorkflow
  • promiseRaceStressTestWorkflow
  • error handling error propagation workflow errors nested function calls preserve message and stack trace
  • error handling error propagation workflow errors cross-file imports preserve message and stack trace
  • error handling error propagation step errors basic step error preserves message and stack trace
  • error handling error propagation step errors cross-file step error preserves message and function names in stack
  • error handling retry behavior regular Error retries until success
  • error handling retry behavior FatalError fails immediately without retries
  • error handling retry behavior RetryableError respects custom retryAfter delay
  • error handling retry behavior maxRetries=0 disables retries
  • error handling catchability FatalError can be caught and detected with FatalError.is()
  • hookCleanupTestWorkflow - hook token reuse after workflow completion
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously
  • stepFunctionPassingWorkflow - step function references can be passed as arguments (without closure vars)
  • stepFunctionWithClosureWorkflow - step function with closure variables passed as argument
  • closureVariableWorkflow - nested step functions with closure variables
  • spawnWorkflowFromStepWorkflow - spawning a child workflow using start() inside a step
  • health check (queue-based) - workflow and step endpoints respond to health check messages
  • pathsAliasWorkflow - TypeScript path aliases resolve correctly
  • Calculator.calculate - static workflow method using static step methods from another class
  • AllInOneService.processNumber - static workflow method using sibling static step methods
  • ChainableService.processWithThis - static step methods using this to reference the class
  • thisSerializationWorkflow - step function invoked with .call() and .apply()
  • customSerializationWorkflow - custom class serialization with WORKFLOW_SERIALIZE/WORKFLOW_DESERIALIZE
  • instanceMethodStepWorkflow - instance methods with "use step" directive
  • crossContextSerdeWorkflow - classes defined in step code are deserializable in workflow context
  • stepFunctionAsStartArgWorkflow - step function reference passed as start() argument
  • pages router addTenWorkflow via pages router
  • pages router promiseAllWorkflow via pages router
  • pages router sleepingWorkflow via pages router

Details by Category

✅ ▲ Vercel Production
AppPassedFailedSkipped
✅ astro4404
✅ example4404
✅ express4404
✅ fastify4404
✅ hono4404
✅ nextjs-turbopack4701
✅ nextjs-webpack4701
✅ nitro4404
✅ nuxt4404
✅ sveltekit4404
✅ vite4404
✅ 💻 Local Development
AppPassedFailedSkipped
✅ astro-stable4107
✅ express-stable4107
✅ fastify-stable4107
✅ hono-stable4107
✅ nextjs-turbopack-stable4503
✅ nextjs-webpack-stable4503
✅ nitro-stable4107
✅ nuxt-stable4107
✅ sveltekit-stable4107
✅ vite-stable4107
✅ 📦 Local Production
AppPassedFailedSkipped
✅ astro-stable4107
✅ express-stable4107
✅ fastify-stable4107
✅ hono-stable4107
✅ nextjs-turbopack-stable4503
✅ nextjs-webpack-stable4503
✅ nitro-stable4107
✅ nuxt-stable4107
✅ sveltekit-stable4107
✅ vite-stable4107
✅ 🐘 Local Postgres
AppPassedFailedSkipped
✅ astro-stable4107
✅ express-stable4107
✅ fastify-stable4107
✅ hono-stable4107
✅ nextjs-turbopack-stable4503
✅ nextjs-webpack-stable4503
✅ nitro-stable4107
✅ nuxt-stable4107
✅ sveltekit-stable4107
✅ vite-stable4107
✅ 🪟 Windows
AppPassedFailedSkipped
✅ nextjs-turbopack4503
❌ 🌍 Community Worlds
AppPassedFailedSkipped
✅ mongodb-dev300
❌ mongodb8373
✅ redis-dev300
❌ redis8373
✅ starter-dev300
❌ starter3423
✅ turso-dev300
❌ turso4413
✅ 📋 Other
AppPassedFailedSkipped
✅ e2e-local-dev-nest-stable4107
✅ e2e-local-postgres-nest-stable4107
✅ e2e-local-prod-nest-stable4107

📋 View full workflow run

@vercel

vercelBot commented Jan 30, 2026

Copy link
Copy Markdown
Contributor

@TooTallNateGraphite App

TooTallNate commented Jan 30, 2026

Copy link
Copy Markdown
MemberAuthor

@TooTallNate
TooTallNate marked this pull request as ready for review January 30, 2026 23:59
CopilotAI review requested due to automatic review settings January 30, 2026 23:59
@TooTallNate
TooTallNateforce-pushed the 01-30-fix_discovery_of_serde_classes_to_detect_workflow_serialize_and_workflow_deserialize_computed_property_usage_in_bundled_code branch from e8e5910 to 0a998eeCompareFebruary 3, 2026 08:13
@TooTallNate
TooTallNateforce-pushed the 01-30-new_and_improved_manifest.json_format branch from 70146d0 to 012ec09CompareFebruary 4, 2026 21:44
@TooTallNate
TooTallNateforce-pushed the 01-30-fix_discovery_of_serde_classes_to_detect_workflow_serialize_and_workflow_deserialize_computed_property_usage_in_bundled_code branch from 0a998ee to 697579aCompareFebruary 4, 2026 21:44
…[WORKFLOW_DESERIALIZE]` computed property usage in bundled code
Update comment to describe the preferred approach: adding 'use step'
directives to instance methods that rely on Node.js imports, allowing
those methods to be replaced with step proxy functions and the Node.js
imports to be dead code eliminated.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@TooTallNate@karthikscale3
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Fix discovery of serde classes to detect `[WORKFLOW_SERIALIZE]` and `[WORKFLOW_DESERIALIZE]` computed property usage in bundled code by TooTallNate · Pull Request #908 · vercel/workflow · GitHub
Skip to content

Fix discovery of serde classes to detect [WORKFLOW_SERIALIZE] and [WORKFLOW_DESERIALIZE] computed property usage in bundled code - #908

Merged
TooTallNate merged 2 commits into
mainfrom
01-30-fix_discovery_of_serde_classes_to_detect_workflow_serialize_and_workflow_deserialize_computed_property_usage_in_bundled_code
Feb 9, 2026
Merged

Fix discovery of serde classes to detect [WORKFLOW_SERIALIZE] and [WORKFLOW_DESERIALIZE] computed property usage in bundled code#908
TooTallNate merged 2 commits into
mainfrom
01-30-fix_discovery_of_serde_classes_to_detect_workflow_serialize_and_workflow_deserialize_computed_property_usage_in_bundled_code

Conversation

@TooTallNate

@TooTallNateTooTallNate commented Jan 30, 2026

Copy link
Copy Markdown
Member

Fix detection of serializable classes in bundled code by recognizing computed property usage of [WORKFLOW_SERIALIZE] and [WORKFLOW_DESERIALIZE].

What changed?

  • Added a new regex pattern workflowSerdeComputedPropertyPattern to detect computed property usage of WORKFLOW_SERIALIZE and WORKFLOW_DESERIALIZE symbols
  • Updated detectWorkflowPatterns to identify serializable classes based on this pattern
  • Modified the turbopackContentPattern to include the new pattern for content matching
  • Added serializable files to the bundle entries to ensure proper discovery
  • Fixed method invocation context in serialization by using call() to ensure the class constructor is the this value

How to test?

  1. Create a bundled package that uses WORKFLOW_SERIALIZE and WORKFLOW_DESERIALIZE as computed properties
  2. Verify that the builder correctly identifies these files as containing serializable classes
  3. Confirm that serialization and deserialization work correctly with the proper this context

Why make this change?

When third-party packages are bundled, the standard import pattern detection for @workflow/serde fails because imports are often from internal chunk files rather than directly from the package. This change ensures that serializable classes are properly detected even in bundled code by looking for the actual computed property usage pattern, improving compatibility with bundled dependencies.

@changeset-bot

changeset-botBot commented Jan 30, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 52c4669

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 14 packages
NameType
@workflow/buildersPatch
@workflow/astroPatch
@workflow/cliPatch
@workflow/nestPatch
@workflow/nextPatch
@workflow/nitroPatch
@workflow/rollupPatch
@workflow/sveltekitPatch
@workflow/vitePatch
workflowPatch
@workflow/world-testingPatch
@workflow/nuxtPatch
@workflow/corePatch
@workflow/web-sharedPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions

github-actionsBot commented Jan 30, 2026

Copy link
Copy Markdown
Contributor

🧪 E2E Test Results

Some tests failed

Summary

PassedFailedSkippedTotal
✅ ▲ Vercel Production490038528
✅ 💻 Local Development418062480
✅ 📦 Local Production418062480
✅ 🐘 Local Postgres418062480
✅ 🪟 Windows450348
❌ 🌍 Community Worlds3515712204
✅ 📋 Other123021144
Total19471572602364

❌ Failed Tests

🌍 Community Worlds (157 failed)

mongodb (37 failed):

  • addTenWorkflow
  • addTenWorkflow
  • should work with react rendering in step
  • promiseAllWorkflow
  • promiseRaceWorkflow
  • promiseAnyWorkflow
  • hookWorkflow
  • webhookWorkflow
  • sleepingWorkflow
  • nullByteWorkflow
  • workflowAndStepMetadataWorkflow
  • fetchWorkflow
  • promiseRaceStressTestWorkflow
  • error handling error propagation workflow errors nested function calls preserve message and stack trace
  • error handling error propagation workflow errors cross-file imports preserve message and stack trace
  • error handling error propagation step errors basic step error preserves message and stack trace
  • error handling error propagation step errors cross-file step error preserves message and function names in stack
  • error handling retry behavior regular Error retries until success
  • error handling retry behavior FatalError fails immediately without retries
  • error handling retry behavior RetryableError respects custom retryAfter delay
  • error handling retry behavior maxRetries=0 disables retries
  • error handling catchability FatalError can be caught and detected with FatalError.is()
  • hookCleanupTestWorkflow - hook token reuse after workflow completion
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously
  • stepFunctionPassingWorkflow - step function references can be passed as arguments (without closure vars)
  • stepFunctionWithClosureWorkflow - step function with closure variables passed as argument
  • closureVariableWorkflow - nested step functions with closure variables
  • spawnWorkflowFromStepWorkflow - spawning a child workflow using start() inside a step
  • pathsAliasWorkflow - TypeScript path aliases resolve correctly
  • Calculator.calculate - static workflow method using static step methods from another class
  • AllInOneService.processNumber - static workflow method using sibling static step methods
  • ChainableService.processWithThis - static step methods using this to reference the class
  • thisSerializationWorkflow - step function invoked with .call() and .apply()
  • customSerializationWorkflow - custom class serialization with WORKFLOW_SERIALIZE/WORKFLOW_DESERIALIZE
  • instanceMethodStepWorkflow - instance methods with "use step" directive
  • crossContextSerdeWorkflow - classes defined in step code are deserializable in workflow context
  • stepFunctionAsStartArgWorkflow - step function reference passed as start() argument

redis (37 failed):

  • addTenWorkflow
  • addTenWorkflow
  • should work with react rendering in step
  • promiseAllWorkflow
  • promiseRaceWorkflow
  • promiseAnyWorkflow
  • hookWorkflow
  • webhookWorkflow
  • sleepingWorkflow
  • nullByteWorkflow
  • workflowAndStepMetadataWorkflow
  • fetchWorkflow
  • promiseRaceStressTestWorkflow
  • error handling error propagation workflow errors nested function calls preserve message and stack trace
  • error handling error propagation workflow errors cross-file imports preserve message and stack trace
  • error handling error propagation step errors basic step error preserves message and stack trace
  • error handling error propagation step errors cross-file step error preserves message and function names in stack
  • error handling retry behavior regular Error retries until success
  • error handling retry behavior FatalError fails immediately without retries
  • error handling retry behavior RetryableError respects custom retryAfter delay
  • error handling retry behavior maxRetries=0 disables retries
  • error handling catchability FatalError can be caught and detected with FatalError.is()
  • hookCleanupTestWorkflow - hook token reuse after workflow completion
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously
  • stepFunctionPassingWorkflow - step function references can be passed as arguments (without closure vars)
  • stepFunctionWithClosureWorkflow - step function with closure variables passed as argument
  • closureVariableWorkflow - nested step functions with closure variables
  • spawnWorkflowFromStepWorkflow - spawning a child workflow using start() inside a step
  • pathsAliasWorkflow - TypeScript path aliases resolve correctly
  • Calculator.calculate - static workflow method using static step methods from another class
  • AllInOneService.processNumber - static workflow method using sibling static step methods
  • ChainableService.processWithThis - static step methods using this to reference the class
  • thisSerializationWorkflow - step function invoked with .call() and .apply()
  • customSerializationWorkflow - custom class serialization with WORKFLOW_SERIALIZE/WORKFLOW_DESERIALIZE
  • instanceMethodStepWorkflow - instance methods with "use step" directive
  • crossContextSerdeWorkflow - classes defined in step code are deserializable in workflow context
  • stepFunctionAsStartArgWorkflow - step function reference passed as start() argument

starter (42 failed):

  • addTenWorkflow
  • addTenWorkflow
  • should work with react rendering in step
  • promiseAllWorkflow
  • promiseRaceWorkflow
  • promiseAnyWorkflow
  • hookWorkflow
  • webhookWorkflow
  • sleepingWorkflow
  • nullByteWorkflow
  • workflowAndStepMetadataWorkflow
  • fetchWorkflow
  • promiseRaceStressTestWorkflow
  • error handling error propagation workflow errors nested function calls preserve message and stack trace
  • error handling error propagation workflow errors cross-file imports preserve message and stack trace
  • error handling error propagation step errors basic step error preserves message and stack trace
  • error handling error propagation step errors cross-file step error preserves message and function names in stack
  • error handling retry behavior regular Error retries until success
  • error handling retry behavior FatalError fails immediately without retries
  • error handling retry behavior RetryableError respects custom retryAfter delay
  • error handling retry behavior maxRetries=0 disables retries
  • error handling catchability FatalError can be caught and detected with FatalError.is()
  • hookCleanupTestWorkflow - hook token reuse after workflow completion
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously
  • stepFunctionPassingWorkflow - step function references can be passed as arguments (without closure vars)
  • stepFunctionWithClosureWorkflow - step function with closure variables passed as argument
  • closureVariableWorkflow - nested step functions with closure variables
  • spawnWorkflowFromStepWorkflow - spawning a child workflow using start() inside a step
  • health check (queue-based) - workflow and step endpoints respond to health check messages
  • health check (CLI) - workflow health command reports healthy endpoints
  • pathsAliasWorkflow - TypeScript path aliases resolve correctly
  • Calculator.calculate - static workflow method using static step methods from another class
  • AllInOneService.processNumber - static workflow method using sibling static step methods
  • ChainableService.processWithThis - static step methods using this to reference the class
  • thisSerializationWorkflow - step function invoked with .call() and .apply()
  • customSerializationWorkflow - custom class serialization with WORKFLOW_SERIALIZE/WORKFLOW_DESERIALIZE
  • instanceMethodStepWorkflow - instance methods with "use step" directive
  • crossContextSerdeWorkflow - classes defined in step code are deserializable in workflow context
  • stepFunctionAsStartArgWorkflow - step function reference passed as start() argument
  • pages router addTenWorkflow via pages router
  • pages router promiseAllWorkflow via pages router
  • pages router sleepingWorkflow via pages router

turso (41 failed):

  • addTenWorkflow
  • addTenWorkflow
  • should work with react rendering in step
  • promiseAllWorkflow
  • promiseRaceWorkflow
  • promiseAnyWorkflow
  • hookWorkflow
  • webhookWorkflow
  • sleepingWorkflow
  • nullByteWorkflow
  • workflowAndStepMetadataWorkflow
  • fetchWorkflow
  • promiseRaceStressTestWorkflow
  • error handling error propagation workflow errors nested function calls preserve message and stack trace
  • error handling error propagation workflow errors cross-file imports preserve message and stack trace
  • error handling error propagation step errors basic step error preserves message and stack trace
  • error handling error propagation step errors cross-file step error preserves message and function names in stack
  • error handling retry behavior regular Error retries until success
  • error handling retry behavior FatalError fails immediately without retries
  • error handling retry behavior RetryableError respects custom retryAfter delay
  • error handling retry behavior maxRetries=0 disables retries
  • error handling catchability FatalError can be caught and detected with FatalError.is()
  • hookCleanupTestWorkflow - hook token reuse after workflow completion
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously
  • stepFunctionPassingWorkflow - step function references can be passed as arguments (without closure vars)
  • stepFunctionWithClosureWorkflow - step function with closure variables passed as argument
  • closureVariableWorkflow - nested step functions with closure variables
  • spawnWorkflowFromStepWorkflow - spawning a child workflow using start() inside a step
  • health check (queue-based) - workflow and step endpoints respond to health check messages
  • pathsAliasWorkflow - TypeScript path aliases resolve correctly
  • Calculator.calculate - static workflow method using static step methods from another class
  • AllInOneService.processNumber - static workflow method using sibling static step methods
  • ChainableService.processWithThis - static step methods using this to reference the class
  • thisSerializationWorkflow - step function invoked with .call() and .apply()
  • customSerializationWorkflow - custom class serialization with WORKFLOW_SERIALIZE/WORKFLOW_DESERIALIZE
  • instanceMethodStepWorkflow - instance methods with "use step" directive
  • crossContextSerdeWorkflow - classes defined in step code are deserializable in workflow context
  • stepFunctionAsStartArgWorkflow - step function reference passed as start() argument
  • pages router addTenWorkflow via pages router
  • pages router promiseAllWorkflow via pages router
  • pages router sleepingWorkflow via pages router

Details by Category

✅ ▲ Vercel Production
AppPassedFailedSkipped
✅ astro4404
✅ example4404
✅ express4404
✅ fastify4404
✅ hono4404
✅ nextjs-turbopack4701
✅ nextjs-webpack4701
✅ nitro4404
✅ nuxt4404
✅ sveltekit4404
✅ vite4404
✅ 💻 Local Development
AppPassedFailedSkipped
✅ astro-stable4107
✅ express-stable4107
✅ fastify-stable4107
✅ hono-stable4107
✅ nextjs-turbopack-stable4503
✅ nextjs-webpack-stable4503
✅ nitro-stable4107
✅ nuxt-stable4107
✅ sveltekit-stable4107
✅ vite-stable4107
✅ 📦 Local Production
AppPassedFailedSkipped
✅ astro-stable4107
✅ express-stable4107
✅ fastify-stable4107
✅ hono-stable4107
✅ nextjs-turbopack-stable4503
✅ nextjs-webpack-stable4503
✅ nitro-stable4107
✅ nuxt-stable4107
✅ sveltekit-stable4107
✅ vite-stable4107
✅ 🐘 Local Postgres
AppPassedFailedSkipped
✅ astro-stable4107
✅ express-stable4107
✅ fastify-stable4107
✅ hono-stable4107
✅ nextjs-turbopack-stable4503
✅ nextjs-webpack-stable4503
✅ nitro-stable4107
✅ nuxt-stable4107
✅ sveltekit-stable4107
✅ vite-stable4107
✅ 🪟 Windows
AppPassedFailedSkipped
✅ nextjs-turbopack4503
❌ 🌍 Community Worlds
AppPassedFailedSkipped
✅ mongodb-dev300
❌ mongodb8373
✅ redis-dev300
❌ redis8373
✅ starter-dev300
❌ starter3423
✅ turso-dev300
❌ turso4413
✅ 📋 Other
AppPassedFailedSkipped
✅ e2e-local-dev-nest-stable4107
✅ e2e-local-postgres-nest-stable4107
✅ e2e-local-prod-nest-stable4107

📋 View full workflow run

@vercel

vercelBot commented Jan 30, 2026

Copy link
Copy Markdown
Contributor

@TooTallNateGraphite App

TooTallNate commented Jan 30, 2026

Copy link
Copy Markdown
MemberAuthor

@TooTallNate
TooTallNate marked this pull request as ready for review January 30, 2026 23:59
CopilotAI review requested due to automatic review settings January 30, 2026 23:59
@TooTallNate
TooTallNateforce-pushed the 01-30-fix_discovery_of_serde_classes_to_detect_workflow_serialize_and_workflow_deserialize_computed_property_usage_in_bundled_code branch from e8e5910 to 0a998eeCompareFebruary 3, 2026 08:13
@TooTallNate
TooTallNateforce-pushed the 01-30-new_and_improved_manifest.json_format branch from 70146d0 to 012ec09CompareFebruary 4, 2026 21:44
@TooTallNate
TooTallNateforce-pushed the 01-30-fix_discovery_of_serde_classes_to_detect_workflow_serialize_and_workflow_deserialize_computed_property_usage_in_bundled_code branch from 0a998ee to 697579aCompareFebruary 4, 2026 21:44
…[WORKFLOW_DESERIALIZE]` computed property usage in bundled code
Update comment to describe the preferred approach: adding 'use step'
directives to instance methods that rely on Node.js imports, allowing
those methods to be replaced with step proxy functions and the Node.js
imports to be dead code eliminated.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@TooTallNate@karthikscale3
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Fix discovery of serde classes to detect `[WORKFLOW_SERIALIZE]` and `[WORKFLOW_DESERIALIZE]` computed property usage in bundled code by TooTallNate · Pull Request #908 · vercel/workflow · GitHub
Skip to content

Fix discovery of serde classes to detect [WORKFLOW_SERIALIZE] and [WORKFLOW_DESERIALIZE] computed property usage in bundled code - #908

Merged
TooTallNate merged 2 commits into
mainfrom
01-30-fix_discovery_of_serde_classes_to_detect_workflow_serialize_and_workflow_deserialize_computed_property_usage_in_bundled_code
Feb 9, 2026
Merged

Fix discovery of serde classes to detect [WORKFLOW_SERIALIZE] and [WORKFLOW_DESERIALIZE] computed property usage in bundled code#908
TooTallNate merged 2 commits into
mainfrom
01-30-fix_discovery_of_serde_classes_to_detect_workflow_serialize_and_workflow_deserialize_computed_property_usage_in_bundled_code

Conversation

@TooTallNate

@TooTallNateTooTallNate commented Jan 30, 2026

Copy link
Copy Markdown
Member

Fix detection of serializable classes in bundled code by recognizing computed property usage of [WORKFLOW_SERIALIZE] and [WORKFLOW_DESERIALIZE].

What changed?

  • Added a new regex pattern workflowSerdeComputedPropertyPattern to detect computed property usage of WORKFLOW_SERIALIZE and WORKFLOW_DESERIALIZE symbols
  • Updated detectWorkflowPatterns to identify serializable classes based on this pattern
  • Modified the turbopackContentPattern to include the new pattern for content matching
  • Added serializable files to the bundle entries to ensure proper discovery
  • Fixed method invocation context in serialization by using call() to ensure the class constructor is the this value

How to test?

  1. Create a bundled package that uses WORKFLOW_SERIALIZE and WORKFLOW_DESERIALIZE as computed properties
  2. Verify that the builder correctly identifies these files as containing serializable classes
  3. Confirm that serialization and deserialization work correctly with the proper this context

Why make this change?

When third-party packages are bundled, the standard import pattern detection for @workflow/serde fails because imports are often from internal chunk files rather than directly from the package. This change ensures that serializable classes are properly detected even in bundled code by looking for the actual computed property usage pattern, improving compatibility with bundled dependencies.

@changeset-bot

changeset-botBot commented Jan 30, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 52c4669

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 14 packages
NameType
@workflow/buildersPatch
@workflow/astroPatch
@workflow/cliPatch
@workflow/nestPatch
@workflow/nextPatch
@workflow/nitroPatch
@workflow/rollupPatch
@workflow/sveltekitPatch
@workflow/vitePatch
workflowPatch
@workflow/world-testingPatch
@workflow/nuxtPatch
@workflow/corePatch
@workflow/web-sharedPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions

github-actionsBot commented Jan 30, 2026

Copy link
Copy Markdown
Contributor

🧪 E2E Test Results

Some tests failed

Summary

PassedFailedSkippedTotal
✅ ▲ Vercel Production490038528
✅ 💻 Local Development418062480
✅ 📦 Local Production418062480
✅ 🐘 Local Postgres418062480
✅ 🪟 Windows450348
❌ 🌍 Community Worlds3515712204
✅ 📋 Other123021144
Total19471572602364

❌ Failed Tests

🌍 Community Worlds (157 failed)

mongodb (37 failed):

  • addTenWorkflow
  • addTenWorkflow
  • should work with react rendering in step
  • promiseAllWorkflow
  • promiseRaceWorkflow
  • promiseAnyWorkflow
  • hookWorkflow
  • webhookWorkflow
  • sleepingWorkflow
  • nullByteWorkflow
  • workflowAndStepMetadataWorkflow
  • fetchWorkflow
  • promiseRaceStressTestWorkflow
  • error handling error propagation workflow errors nested function calls preserve message and stack trace
  • error handling error propagation workflow errors cross-file imports preserve message and stack trace
  • error handling error propagation step errors basic step error preserves message and stack trace
  • error handling error propagation step errors cross-file step error preserves message and function names in stack
  • error handling retry behavior regular Error retries until success
  • error handling retry behavior FatalError fails immediately without retries
  • error handling retry behavior RetryableError respects custom retryAfter delay
  • error handling retry behavior maxRetries=0 disables retries
  • error handling catchability FatalError can be caught and detected with FatalError.is()
  • hookCleanupTestWorkflow - hook token reuse after workflow completion
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously
  • stepFunctionPassingWorkflow - step function references can be passed as arguments (without closure vars)
  • stepFunctionWithClosureWorkflow - step function with closure variables passed as argument
  • closureVariableWorkflow - nested step functions with closure variables
  • spawnWorkflowFromStepWorkflow - spawning a child workflow using start() inside a step
  • pathsAliasWorkflow - TypeScript path aliases resolve correctly
  • Calculator.calculate - static workflow method using static step methods from another class
  • AllInOneService.processNumber - static workflow method using sibling static step methods
  • ChainableService.processWithThis - static step methods using this to reference the class
  • thisSerializationWorkflow - step function invoked with .call() and .apply()
  • customSerializationWorkflow - custom class serialization with WORKFLOW_SERIALIZE/WORKFLOW_DESERIALIZE
  • instanceMethodStepWorkflow - instance methods with "use step" directive
  • crossContextSerdeWorkflow - classes defined in step code are deserializable in workflow context
  • stepFunctionAsStartArgWorkflow - step function reference passed as start() argument

redis (37 failed):

  • addTenWorkflow
  • addTenWorkflow
  • should work with react rendering in step
  • promiseAllWorkflow
  • promiseRaceWorkflow
  • promiseAnyWorkflow
  • hookWorkflow
  • webhookWorkflow
  • sleepingWorkflow
  • nullByteWorkflow
  • workflowAndStepMetadataWorkflow
  • fetchWorkflow
  • promiseRaceStressTestWorkflow
  • error handling error propagation workflow errors nested function calls preserve message and stack trace
  • error handling error propagation workflow errors cross-file imports preserve message and stack trace
  • error handling error propagation step errors basic step error preserves message and stack trace
  • error handling error propagation step errors cross-file step error preserves message and function names in stack
  • error handling retry behavior regular Error retries until success
  • error handling retry behavior FatalError fails immediately without retries
  • error handling retry behavior RetryableError respects custom retryAfter delay
  • error handling retry behavior maxRetries=0 disables retries
  • error handling catchability FatalError can be caught and detected with FatalError.is()
  • hookCleanupTestWorkflow - hook token reuse after workflow completion
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously
  • stepFunctionPassingWorkflow - step function references can be passed as arguments (without closure vars)
  • stepFunctionWithClosureWorkflow - step function with closure variables passed as argument
  • closureVariableWorkflow - nested step functions with closure variables
  • spawnWorkflowFromStepWorkflow - spawning a child workflow using start() inside a step
  • pathsAliasWorkflow - TypeScript path aliases resolve correctly
  • Calculator.calculate - static workflow method using static step methods from another class
  • AllInOneService.processNumber - static workflow method using sibling static step methods
  • ChainableService.processWithThis - static step methods using this to reference the class
  • thisSerializationWorkflow - step function invoked with .call() and .apply()
  • customSerializationWorkflow - custom class serialization with WORKFLOW_SERIALIZE/WORKFLOW_DESERIALIZE
  • instanceMethodStepWorkflow - instance methods with "use step" directive
  • crossContextSerdeWorkflow - classes defined in step code are deserializable in workflow context
  • stepFunctionAsStartArgWorkflow - step function reference passed as start() argument

starter (42 failed):

  • addTenWorkflow
  • addTenWorkflow
  • should work with react rendering in step
  • promiseAllWorkflow
  • promiseRaceWorkflow
  • promiseAnyWorkflow
  • hookWorkflow
  • webhookWorkflow
  • sleepingWorkflow
  • nullByteWorkflow
  • workflowAndStepMetadataWorkflow
  • fetchWorkflow
  • promiseRaceStressTestWorkflow
  • error handling error propagation workflow errors nested function calls preserve message and stack trace
  • error handling error propagation workflow errors cross-file imports preserve message and stack trace
  • error handling error propagation step errors basic step error preserves message and stack trace
  • error handling error propagation step errors cross-file step error preserves message and function names in stack
  • error handling retry behavior regular Error retries until success
  • error handling retry behavior FatalError fails immediately without retries
  • error handling retry behavior RetryableError respects custom retryAfter delay
  • error handling retry behavior maxRetries=0 disables retries
  • error handling catchability FatalError can be caught and detected with FatalError.is()
  • hookCleanupTestWorkflow - hook token reuse after workflow completion
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously
  • stepFunctionPassingWorkflow - step function references can be passed as arguments (without closure vars)
  • stepFunctionWithClosureWorkflow - step function with closure variables passed as argument
  • closureVariableWorkflow - nested step functions with closure variables
  • spawnWorkflowFromStepWorkflow - spawning a child workflow using start() inside a step
  • health check (queue-based) - workflow and step endpoints respond to health check messages
  • health check (CLI) - workflow health command reports healthy endpoints
  • pathsAliasWorkflow - TypeScript path aliases resolve correctly
  • Calculator.calculate - static workflow method using static step methods from another class
  • AllInOneService.processNumber - static workflow method using sibling static step methods
  • ChainableService.processWithThis - static step methods using this to reference the class
  • thisSerializationWorkflow - step function invoked with .call() and .apply()
  • customSerializationWorkflow - custom class serialization with WORKFLOW_SERIALIZE/WORKFLOW_DESERIALIZE
  • instanceMethodStepWorkflow - instance methods with "use step" directive
  • crossContextSerdeWorkflow - classes defined in step code are deserializable in workflow context
  • stepFunctionAsStartArgWorkflow - step function reference passed as start() argument
  • pages router addTenWorkflow via pages router
  • pages router promiseAllWorkflow via pages router
  • pages router sleepingWorkflow via pages router

turso (41 failed):

  • addTenWorkflow
  • addTenWorkflow
  • should work with react rendering in step
  • promiseAllWorkflow
  • promiseRaceWorkflow
  • promiseAnyWorkflow
  • hookWorkflow
  • webhookWorkflow
  • sleepingWorkflow
  • nullByteWorkflow
  • workflowAndStepMetadataWorkflow
  • fetchWorkflow
  • promiseRaceStressTestWorkflow
  • error handling error propagation workflow errors nested function calls preserve message and stack trace
  • error handling error propagation workflow errors cross-file imports preserve message and stack trace
  • error handling error propagation step errors basic step error preserves message and stack trace
  • error handling error propagation step errors cross-file step error preserves message and function names in stack
  • error handling retry behavior regular Error retries until success
  • error handling retry behavior FatalError fails immediately without retries
  • error handling retry behavior RetryableError respects custom retryAfter delay
  • error handling retry behavior maxRetries=0 disables retries
  • error handling catchability FatalError can be caught and detected with FatalError.is()
  • hookCleanupTestWorkflow - hook token reuse after workflow completion
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously
  • stepFunctionPassingWorkflow - step function references can be passed as arguments (without closure vars)
  • stepFunctionWithClosureWorkflow - step function with closure variables passed as argument
  • closureVariableWorkflow - nested step functions with closure variables
  • spawnWorkflowFromStepWorkflow - spawning a child workflow using start() inside a step
  • health check (queue-based) - workflow and step endpoints respond to health check messages
  • pathsAliasWorkflow - TypeScript path aliases resolve correctly
  • Calculator.calculate - static workflow method using static step methods from another class
  • AllInOneService.processNumber - static workflow method using sibling static step methods
  • ChainableService.processWithThis - static step methods using this to reference the class
  • thisSerializationWorkflow - step function invoked with .call() and .apply()
  • customSerializationWorkflow - custom class serialization with WORKFLOW_SERIALIZE/WORKFLOW_DESERIALIZE
  • instanceMethodStepWorkflow - instance methods with "use step" directive
  • crossContextSerdeWorkflow - classes defined in step code are deserializable in workflow context
  • stepFunctionAsStartArgWorkflow - step function reference passed as start() argument
  • pages router addTenWorkflow via pages router
  • pages router promiseAllWorkflow via pages router
  • pages router sleepingWorkflow via pages router

Details by Category

✅ ▲ Vercel Production
AppPassedFailedSkipped
✅ astro4404
✅ example4404
✅ express4404
✅ fastify4404
✅ hono4404
✅ nextjs-turbopack4701
✅ nextjs-webpack4701
✅ nitro4404
✅ nuxt4404
✅ sveltekit4404
✅ vite4404
✅ 💻 Local Development
AppPassedFailedSkipped
✅ astro-stable4107
✅ express-stable4107
✅ fastify-stable4107
✅ hono-stable4107
✅ nextjs-turbopack-stable4503
✅ nextjs-webpack-stable4503
✅ nitro-stable4107
✅ nuxt-stable4107
✅ sveltekit-stable4107
✅ vite-stable4107
✅ 📦 Local Production
AppPassedFailedSkipped
✅ astro-stable4107
✅ express-stable4107
✅ fastify-stable4107
✅ hono-stable4107
✅ nextjs-turbopack-stable4503
✅ nextjs-webpack-stable4503
✅ nitro-stable4107
✅ nuxt-stable4107
✅ sveltekit-stable4107
✅ vite-stable4107
✅ 🐘 Local Postgres
AppPassedFailedSkipped
✅ astro-stable4107
✅ express-stable4107
✅ fastify-stable4107
✅ hono-stable4107
✅ nextjs-turbopack-stable4503
✅ nextjs-webpack-stable4503
✅ nitro-stable4107
✅ nuxt-stable4107
✅ sveltekit-stable4107
✅ vite-stable4107
✅ 🪟 Windows
AppPassedFailedSkipped
✅ nextjs-turbopack4503
❌ 🌍 Community Worlds
AppPassedFailedSkipped
✅ mongodb-dev300
❌ mongodb8373
✅ redis-dev300
❌ redis8373
✅ starter-dev300
❌ starter3423
✅ turso-dev300
❌ turso4413
✅ 📋 Other
AppPassedFailedSkipped
✅ e2e-local-dev-nest-stable4107
✅ e2e-local-postgres-nest-stable4107
✅ e2e-local-prod-nest-stable4107

📋 View full workflow run

@vercel

vercelBot commented Jan 30, 2026

Copy link
Copy Markdown
Contributor

@TooTallNateGraphite App

TooTallNate commented Jan 30, 2026

Copy link
Copy Markdown
MemberAuthor

@TooTallNate
TooTallNate marked this pull request as ready for review January 30, 2026 23:59
CopilotAI review requested due to automatic review settings January 30, 2026 23:59
@TooTallNate
TooTallNateforce-pushed the 01-30-fix_discovery_of_serde_classes_to_detect_workflow_serialize_and_workflow_deserialize_computed_property_usage_in_bundled_code branch from e8e5910 to 0a998eeCompareFebruary 3, 2026 08:13
@TooTallNate
TooTallNateforce-pushed the 01-30-new_and_improved_manifest.json_format branch from 70146d0 to 012ec09CompareFebruary 4, 2026 21:44
@TooTallNate
TooTallNateforce-pushed the 01-30-fix_discovery_of_serde_classes_to_detect_workflow_serialize_and_workflow_deserialize_computed_property_usage_in_bundled_code branch from 0a998ee to 697579aCompareFebruary 4, 2026 21:44
…[WORKFLOW_DESERIALIZE]` computed property usage in bundled code
Update comment to describe the preferred approach: adding 'use step'
directives to instance methods that rely on Node.js imports, allowing
those methods to be replaced with step proxy functions and the Node.js
imports to be dead code eliminated.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@TooTallNate@karthikscale3
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Fix discovery of serde classes to detect `[WORKFLOW_SERIALIZE]` and `[WORKFLOW_DESERIALIZE]` computed property usage in bundled code by TooTallNate · Pull Request #908 · vercel/workflow · GitHub
Skip to content

Fix discovery of serde classes to detect [WORKFLOW_SERIALIZE] and [WORKFLOW_DESERIALIZE] computed property usage in bundled code - #908

Merged
TooTallNate merged 2 commits into
mainfrom
01-30-fix_discovery_of_serde_classes_to_detect_workflow_serialize_and_workflow_deserialize_computed_property_usage_in_bundled_code
Feb 9, 2026
Merged

Fix discovery of serde classes to detect [WORKFLOW_SERIALIZE] and [WORKFLOW_DESERIALIZE] computed property usage in bundled code#908
TooTallNate merged 2 commits into
mainfrom
01-30-fix_discovery_of_serde_classes_to_detect_workflow_serialize_and_workflow_deserialize_computed_property_usage_in_bundled_code

Conversation

@TooTallNate

@TooTallNateTooTallNate commented Jan 30, 2026

Copy link
Copy Markdown
Member

Fix detection of serializable classes in bundled code by recognizing computed property usage of [WORKFLOW_SERIALIZE] and [WORKFLOW_DESERIALIZE].

What changed?

  • Added a new regex pattern workflowSerdeComputedPropertyPattern to detect computed property usage of WORKFLOW_SERIALIZE and WORKFLOW_DESERIALIZE symbols
  • Updated detectWorkflowPatterns to identify serializable classes based on this pattern
  • Modified the turbopackContentPattern to include the new pattern for content matching
  • Added serializable files to the bundle entries to ensure proper discovery
  • Fixed method invocation context in serialization by using call() to ensure the class constructor is the this value

How to test?

  1. Create a bundled package that uses WORKFLOW_SERIALIZE and WORKFLOW_DESERIALIZE as computed properties
  2. Verify that the builder correctly identifies these files as containing serializable classes
  3. Confirm that serialization and deserialization work correctly with the proper this context

Why make this change?

When third-party packages are bundled, the standard import pattern detection for @workflow/serde fails because imports are often from internal chunk files rather than directly from the package. This change ensures that serializable classes are properly detected even in bundled code by looking for the actual computed property usage pattern, improving compatibility with bundled dependencies.

@changeset-bot

changeset-botBot commented Jan 30, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 52c4669

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 14 packages
NameType
@workflow/buildersPatch
@workflow/astroPatch
@workflow/cliPatch
@workflow/nestPatch
@workflow/nextPatch
@workflow/nitroPatch
@workflow/rollupPatch
@workflow/sveltekitPatch
@workflow/vitePatch
workflowPatch
@workflow/world-testingPatch
@workflow/nuxtPatch
@workflow/corePatch
@workflow/web-sharedPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions

github-actionsBot commented Jan 30, 2026

Copy link
Copy Markdown
Contributor

🧪 E2E Test Results

Some tests failed

Summary

PassedFailedSkippedTotal
✅ ▲ Vercel Production490038528
✅ 💻 Local Development418062480
✅ 📦 Local Production418062480
✅ 🐘 Local Postgres418062480
✅ 🪟 Windows450348
❌ 🌍 Community Worlds3515712204
✅ 📋 Other123021144
Total19471572602364

❌ Failed Tests

🌍 Community Worlds (157 failed)

mongodb (37 failed):

  • addTenWorkflow
  • addTenWorkflow
  • should work with react rendering in step
  • promiseAllWorkflow
  • promiseRaceWorkflow
  • promiseAnyWorkflow
  • hookWorkflow
  • webhookWorkflow
  • sleepingWorkflow
  • nullByteWorkflow
  • workflowAndStepMetadataWorkflow
  • fetchWorkflow
  • promiseRaceStressTestWorkflow
  • error handling error propagation workflow errors nested function calls preserve message and stack trace
  • error handling error propagation workflow errors cross-file imports preserve message and stack trace
  • error handling error propagation step errors basic step error preserves message and stack trace
  • error handling error propagation step errors cross-file step error preserves message and function names in stack
  • error handling retry behavior regular Error retries until success
  • error handling retry behavior FatalError fails immediately without retries
  • error handling retry behavior RetryableError respects custom retryAfter delay
  • error handling retry behavior maxRetries=0 disables retries
  • error handling catchability FatalError can be caught and detected with FatalError.is()
  • hookCleanupTestWorkflow - hook token reuse after workflow completion
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously
  • stepFunctionPassingWorkflow - step function references can be passed as arguments (without closure vars)
  • stepFunctionWithClosureWorkflow - step function with closure variables passed as argument
  • closureVariableWorkflow - nested step functions with closure variables
  • spawnWorkflowFromStepWorkflow - spawning a child workflow using start() inside a step
  • pathsAliasWorkflow - TypeScript path aliases resolve correctly
  • Calculator.calculate - static workflow method using static step methods from another class
  • AllInOneService.processNumber - static workflow method using sibling static step methods
  • ChainableService.processWithThis - static step methods using this to reference the class
  • thisSerializationWorkflow - step function invoked with .call() and .apply()
  • customSerializationWorkflow - custom class serialization with WORKFLOW_SERIALIZE/WORKFLOW_DESERIALIZE
  • instanceMethodStepWorkflow - instance methods with "use step" directive
  • crossContextSerdeWorkflow - classes defined in step code are deserializable in workflow context
  • stepFunctionAsStartArgWorkflow - step function reference passed as start() argument

redis (37 failed):

  • addTenWorkflow
  • addTenWorkflow
  • should work with react rendering in step
  • promiseAllWorkflow
  • promiseRaceWorkflow
  • promiseAnyWorkflow
  • hookWorkflow
  • webhookWorkflow
  • sleepingWorkflow
  • nullByteWorkflow
  • workflowAndStepMetadataWorkflow
  • fetchWorkflow
  • promiseRaceStressTestWorkflow
  • error handling error propagation workflow errors nested function calls preserve message and stack trace
  • error handling error propagation workflow errors cross-file imports preserve message and stack trace
  • error handling error propagation step errors basic step error preserves message and stack trace
  • error handling error propagation step errors cross-file step error preserves message and function names in stack
  • error handling retry behavior regular Error retries until success
  • error handling retry behavior FatalError fails immediately without retries
  • error handling retry behavior RetryableError respects custom retryAfter delay
  • error handling retry behavior maxRetries=0 disables retries
  • error handling catchability FatalError can be caught and detected with FatalError.is()
  • hookCleanupTestWorkflow - hook token reuse after workflow completion
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously
  • stepFunctionPassingWorkflow - step function references can be passed as arguments (without closure vars)
  • stepFunctionWithClosureWorkflow - step function with closure variables passed as argument
  • closureVariableWorkflow - nested step functions with closure variables
  • spawnWorkflowFromStepWorkflow - spawning a child workflow using start() inside a step
  • pathsAliasWorkflow - TypeScript path aliases resolve correctly
  • Calculator.calculate - static workflow method using static step methods from another class
  • AllInOneService.processNumber - static workflow method using sibling static step methods
  • ChainableService.processWithThis - static step methods using this to reference the class
  • thisSerializationWorkflow - step function invoked with .call() and .apply()
  • customSerializationWorkflow - custom class serialization with WORKFLOW_SERIALIZE/WORKFLOW_DESERIALIZE
  • instanceMethodStepWorkflow - instance methods with "use step" directive
  • crossContextSerdeWorkflow - classes defined in step code are deserializable in workflow context
  • stepFunctionAsStartArgWorkflow - step function reference passed as start() argument

starter (42 failed):

  • addTenWorkflow
  • addTenWorkflow
  • should work with react rendering in step
  • promiseAllWorkflow
  • promiseRaceWorkflow
  • promiseAnyWorkflow
  • hookWorkflow
  • webhookWorkflow
  • sleepingWorkflow
  • nullByteWorkflow
  • workflowAndStepMetadataWorkflow
  • fetchWorkflow
  • promiseRaceStressTestWorkflow
  • error handling error propagation workflow errors nested function calls preserve message and stack trace
  • error handling error propagation workflow errors cross-file imports preserve message and stack trace
  • error handling error propagation step errors basic step error preserves message and stack trace
  • error handling error propagation step errors cross-file step error preserves message and function names in stack
  • error handling retry behavior regular Error retries until success
  • error handling retry behavior FatalError fails immediately without retries
  • error handling retry behavior RetryableError respects custom retryAfter delay
  • error handling retry behavior maxRetries=0 disables retries
  • error handling catchability FatalError can be caught and detected with FatalError.is()
  • hookCleanupTestWorkflow - hook token reuse after workflow completion
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously
  • stepFunctionPassingWorkflow - step function references can be passed as arguments (without closure vars)
  • stepFunctionWithClosureWorkflow - step function with closure variables passed as argument
  • closureVariableWorkflow - nested step functions with closure variables
  • spawnWorkflowFromStepWorkflow - spawning a child workflow using start() inside a step
  • health check (queue-based) - workflow and step endpoints respond to health check messages
  • health check (CLI) - workflow health command reports healthy endpoints
  • pathsAliasWorkflow - TypeScript path aliases resolve correctly
  • Calculator.calculate - static workflow method using static step methods from another class
  • AllInOneService.processNumber - static workflow method using sibling static step methods
  • ChainableService.processWithThis - static step methods using this to reference the class
  • thisSerializationWorkflow - step function invoked with .call() and .apply()
  • customSerializationWorkflow - custom class serialization with WORKFLOW_SERIALIZE/WORKFLOW_DESERIALIZE
  • instanceMethodStepWorkflow - instance methods with "use step" directive
  • crossContextSerdeWorkflow - classes defined in step code are deserializable in workflow context
  • stepFunctionAsStartArgWorkflow - step function reference passed as start() argument
  • pages router addTenWorkflow via pages router
  • pages router promiseAllWorkflow via pages router
  • pages router sleepingWorkflow via pages router

turso (41 failed):

  • addTenWorkflow
  • addTenWorkflow
  • should work with react rendering in step
  • promiseAllWorkflow
  • promiseRaceWorkflow
  • promiseAnyWorkflow
  • hookWorkflow
  • webhookWorkflow
  • sleepingWorkflow
  • nullByteWorkflow
  • workflowAndStepMetadataWorkflow
  • fetchWorkflow
  • promiseRaceStressTestWorkflow
  • error handling error propagation workflow errors nested function calls preserve message and stack trace
  • error handling error propagation workflow errors cross-file imports preserve message and stack trace
  • error handling error propagation step errors basic step error preserves message and stack trace
  • error handling error propagation step errors cross-file step error preserves message and function names in stack
  • error handling retry behavior regular Error retries until success
  • error handling retry behavior FatalError fails immediately without retries
  • error handling retry behavior RetryableError respects custom retryAfter delay
  • error handling retry behavior maxRetries=0 disables retries
  • error handling catchability FatalError can be caught and detected with FatalError.is()
  • hookCleanupTestWorkflow - hook token reuse after workflow completion
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously
  • stepFunctionPassingWorkflow - step function references can be passed as arguments (without closure vars)
  • stepFunctionWithClosureWorkflow - step function with closure variables passed as argument
  • closureVariableWorkflow - nested step functions with closure variables
  • spawnWorkflowFromStepWorkflow - spawning a child workflow using start() inside a step
  • health check (queue-based) - workflow and step endpoints respond to health check messages
  • pathsAliasWorkflow - TypeScript path aliases resolve correctly
  • Calculator.calculate - static workflow method using static step methods from another class
  • AllInOneService.processNumber - static workflow method using sibling static step methods
  • ChainableService.processWithThis - static step methods using this to reference the class
  • thisSerializationWorkflow - step function invoked with .call() and .apply()
  • customSerializationWorkflow - custom class serialization with WORKFLOW_SERIALIZE/WORKFLOW_DESERIALIZE
  • instanceMethodStepWorkflow - instance methods with "use step" directive
  • crossContextSerdeWorkflow - classes defined in step code are deserializable in workflow context
  • stepFunctionAsStartArgWorkflow - step function reference passed as start() argument
  • pages router addTenWorkflow via pages router
  • pages router promiseAllWorkflow via pages router
  • pages router sleepingWorkflow via pages router

Details by Category

✅ ▲ Vercel Production
AppPassedFailedSkipped
✅ astro4404
✅ example4404
✅ express4404
✅ fastify4404
✅ hono4404
✅ nextjs-turbopack4701
✅ nextjs-webpack4701
✅ nitro4404
✅ nuxt4404
✅ sveltekit4404
✅ vite4404
✅ 💻 Local Development
AppPassedFailedSkipped
✅ astro-stable4107
✅ express-stable4107
✅ fastify-stable4107
✅ hono-stable4107
✅ nextjs-turbopack-stable4503
✅ nextjs-webpack-stable4503
✅ nitro-stable4107
✅ nuxt-stable4107
✅ sveltekit-stable4107
✅ vite-stable4107
✅ 📦 Local Production
AppPassedFailedSkipped
✅ astro-stable4107
✅ express-stable4107
✅ fastify-stable4107
✅ hono-stable4107
✅ nextjs-turbopack-stable4503
✅ nextjs-webpack-stable4503
✅ nitro-stable4107
✅ nuxt-stable4107
✅ sveltekit-stable4107
✅ vite-stable4107
✅ 🐘 Local Postgres
AppPassedFailedSkipped
✅ astro-stable4107
✅ express-stable4107
✅ fastify-stable4107
✅ hono-stable4107
✅ nextjs-turbopack-stable4503
✅ nextjs-webpack-stable4503
✅ nitro-stable4107
✅ nuxt-stable4107
✅ sveltekit-stable4107
✅ vite-stable4107
✅ 🪟 Windows
AppPassedFailedSkipped
✅ nextjs-turbopack4503
❌ 🌍 Community Worlds
AppPassedFailedSkipped
✅ mongodb-dev300
❌ mongodb8373
✅ redis-dev300
❌ redis8373
✅ starter-dev300
❌ starter3423
✅ turso-dev300
❌ turso4413
✅ 📋 Other
AppPassedFailedSkipped
✅ e2e-local-dev-nest-stable4107
✅ e2e-local-postgres-nest-stable4107
✅ e2e-local-prod-nest-stable4107

📋 View full workflow run

@vercel

vercelBot commented Jan 30, 2026

Copy link
Copy Markdown
Contributor

@TooTallNateGraphite App

TooTallNate commented Jan 30, 2026

Copy link
Copy Markdown
MemberAuthor

@TooTallNate
TooTallNate marked this pull request as ready for review January 30, 2026 23:59
CopilotAI review requested due to automatic review settings January 30, 2026 23:59
@TooTallNate
TooTallNateforce-pushed the 01-30-fix_discovery_of_serde_classes_to_detect_workflow_serialize_and_workflow_deserialize_computed_property_usage_in_bundled_code branch from e8e5910 to 0a998eeCompareFebruary 3, 2026 08:13
@TooTallNate
TooTallNateforce-pushed the 01-30-new_and_improved_manifest.json_format branch from 70146d0 to 012ec09CompareFebruary 4, 2026 21:44
@TooTallNate
TooTallNateforce-pushed the 01-30-fix_discovery_of_serde_classes_to_detect_workflow_serialize_and_workflow_deserialize_computed_property_usage_in_bundled_code branch from 0a998ee to 697579aCompareFebruary 4, 2026 21:44
…[WORKFLOW_DESERIALIZE]` computed property usage in bundled code
Update comment to describe the preferred approach: adding 'use step'
directives to instance methods that rely on Node.js imports, allowing
those methods to be replaced with step proxy functions and the Node.js
imports to be dead code eliminated.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@TooTallNate@karthikscale3
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ' Fix discovery of serde classes to detect `[WORKFLOW_SERIALIZE]` and `[WORKFLOW_DESERIALIZE]` computed property usage in bundled code by TooTallNate · Pull Request #908 · vercel/workflow · GitHub
Skip to content

Fix discovery of serde classes to detect [WORKFLOW_SERIALIZE] and [WORKFLOW_DESERIALIZE] computed property usage in bundled code - #908

Merged
TooTallNate merged 2 commits into
mainfrom
01-30-fix_discovery_of_serde_classes_to_detect_workflow_serialize_and_workflow_deserialize_computed_property_usage_in_bundled_code
Feb 9, 2026
Merged

Fix discovery of serde classes to detect [WORKFLOW_SERIALIZE] and [WORKFLOW_DESERIALIZE] computed property usage in bundled code#908
TooTallNate merged 2 commits into
mainfrom
01-30-fix_discovery_of_serde_classes_to_detect_workflow_serialize_and_workflow_deserialize_computed_property_usage_in_bundled_code

Conversation

@TooTallNate

@TooTallNateTooTallNate commented Jan 30, 2026

Copy link
Copy Markdown
Member

Fix detection of serializable classes in bundled code by recognizing computed property usage of [WORKFLOW_SERIALIZE] and [WORKFLOW_DESERIALIZE].

What changed?

  • Added a new regex pattern workflowSerdeComputedPropertyPattern to detect computed property usage of WORKFLOW_SERIALIZE and WORKFLOW_DESERIALIZE symbols
  • Updated detectWorkflowPatterns to identify serializable classes based on this pattern
  • Modified the turbopackContentPattern to include the new pattern for content matching
  • Added serializable files to the bundle entries to ensure proper discovery
  • Fixed method invocation context in serialization by using call() to ensure the class constructor is the this value

How to test?

  1. Create a bundled package that uses WORKFLOW_SERIALIZE and WORKFLOW_DESERIALIZE as computed properties
  2. Verify that the builder correctly identifies these files as containing serializable classes
  3. Confirm that serialization and deserialization work correctly with the proper this context

Why make this change?

When third-party packages are bundled, the standard import pattern detection for @workflow/serde fails because imports are often from internal chunk files rather than directly from the package. This change ensures that serializable classes are properly detected even in bundled code by looking for the actual computed property usage pattern, improving compatibility with bundled dependencies.

@changeset-bot

changeset-botBot commented Jan 30, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 52c4669

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 14 packages
NameType
@workflow/buildersPatch
@workflow/astroPatch
@workflow/cliPatch
@workflow/nestPatch
@workflow/nextPatch
@workflow/nitroPatch
@workflow/rollupPatch
@workflow/sveltekitPatch
@workflow/vitePatch
workflowPatch
@workflow/world-testingPatch
@workflow/nuxtPatch
@workflow/corePatch
@workflow/web-sharedPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions

github-actionsBot commented Jan 30, 2026

Copy link
Copy Markdown
Contributor

🧪 E2E Test Results

Some tests failed

Summary

PassedFailedSkippedTotal
✅ ▲ Vercel Production490038528
✅ 💻 Local Development418062480
✅ 📦 Local Production418062480
✅ 🐘 Local Postgres418062480
✅ 🪟 Windows450348
❌ 🌍 Community Worlds3515712204
✅ 📋 Other123021144
Total19471572602364

❌ Failed Tests

🌍 Community Worlds (157 failed)

mongodb (37 failed):

  • addTenWorkflow
  • addTenWorkflow
  • should work with react rendering in step
  • promiseAllWorkflow
  • promiseRaceWorkflow
  • promiseAnyWorkflow
  • hookWorkflow
  • webhookWorkflow
  • sleepingWorkflow
  • nullByteWorkflow
  • workflowAndStepMetadataWorkflow
  • fetchWorkflow
  • promiseRaceStressTestWorkflow
  • error handling error propagation workflow errors nested function calls preserve message and stack trace
  • error handling error propagation workflow errors cross-file imports preserve message and stack trace
  • error handling error propagation step errors basic step error preserves message and stack trace
  • error handling error propagation step errors cross-file step error preserves message and function names in stack
  • error handling retry behavior regular Error retries until success
  • error handling retry behavior FatalError fails immediately without retries
  • error handling retry behavior RetryableError respects custom retryAfter delay
  • error handling retry behavior maxRetries=0 disables retries
  • error handling catchability FatalError can be caught and detected with FatalError.is()
  • hookCleanupTestWorkflow - hook token reuse after workflow completion
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously
  • stepFunctionPassingWorkflow - step function references can be passed as arguments (without closure vars)
  • stepFunctionWithClosureWorkflow - step function with closure variables passed as argument
  • closureVariableWorkflow - nested step functions with closure variables
  • spawnWorkflowFromStepWorkflow - spawning a child workflow using start() inside a step
  • pathsAliasWorkflow - TypeScript path aliases resolve correctly
  • Calculator.calculate - static workflow method using static step methods from another class
  • AllInOneService.processNumber - static workflow method using sibling static step methods
  • ChainableService.processWithThis - static step methods using this to reference the class
  • thisSerializationWorkflow - step function invoked with .call() and .apply()
  • customSerializationWorkflow - custom class serialization with WORKFLOW_SERIALIZE/WORKFLOW_DESERIALIZE
  • instanceMethodStepWorkflow - instance methods with "use step" directive
  • crossContextSerdeWorkflow - classes defined in step code are deserializable in workflow context
  • stepFunctionAsStartArgWorkflow - step function reference passed as start() argument

redis (37 failed):

  • addTenWorkflow
  • addTenWorkflow
  • should work with react rendering in step
  • promiseAllWorkflow
  • promiseRaceWorkflow
  • promiseAnyWorkflow
  • hookWorkflow
  • webhookWorkflow
  • sleepingWorkflow
  • nullByteWorkflow
  • workflowAndStepMetadataWorkflow
  • fetchWorkflow
  • promiseRaceStressTestWorkflow
  • error handling error propagation workflow errors nested function calls preserve message and stack trace
  • error handling error propagation workflow errors cross-file imports preserve message and stack trace
  • error handling error propagation step errors basic step error preserves message and stack trace
  • error handling error propagation step errors cross-file step error preserves message and function names in stack
  • error handling retry behavior regular Error retries until success
  • error handling retry behavior FatalError fails immediately without retries
  • error handling retry behavior RetryableError respects custom retryAfter delay
  • error handling retry behavior maxRetries=0 disables retries
  • error handling catchability FatalError can be caught and detected with FatalError.is()
  • hookCleanupTestWorkflow - hook token reuse after workflow completion
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously
  • stepFunctionPassingWorkflow - step function references can be passed as arguments (without closure vars)
  • stepFunctionWithClosureWorkflow - step function with closure variables passed as argument
  • closureVariableWorkflow - nested step functions with closure variables
  • spawnWorkflowFromStepWorkflow - spawning a child workflow using start() inside a step
  • pathsAliasWorkflow - TypeScript path aliases resolve correctly
  • Calculator.calculate - static workflow method using static step methods from another class
  • AllInOneService.processNumber - static workflow method using sibling static step methods
  • ChainableService.processWithThis - static step methods using this to reference the class
  • thisSerializationWorkflow - step function invoked with .call() and .apply()
  • customSerializationWorkflow - custom class serialization with WORKFLOW_SERIALIZE/WORKFLOW_DESERIALIZE
  • instanceMethodStepWorkflow - instance methods with "use step" directive
  • crossContextSerdeWorkflow - classes defined in step code are deserializable in workflow context
  • stepFunctionAsStartArgWorkflow - step function reference passed as start() argument

starter (42 failed):

  • addTenWorkflow
  • addTenWorkflow
  • should work with react rendering in step
  • promiseAllWorkflow
  • promiseRaceWorkflow
  • promiseAnyWorkflow
  • hookWorkflow
  • webhookWorkflow
  • sleepingWorkflow
  • nullByteWorkflow
  • workflowAndStepMetadataWorkflow
  • fetchWorkflow
  • promiseRaceStressTestWorkflow
  • error handling error propagation workflow errors nested function calls preserve message and stack trace
  • error handling error propagation workflow errors cross-file imports preserve message and stack trace
  • error handling error propagation step errors basic step error preserves message and stack trace
  • error handling error propagation step errors cross-file step error preserves message and function names in stack
  • error handling retry behavior regular Error retries until success
  • error handling retry behavior FatalError fails immediately without retries
  • error handling retry behavior RetryableError respects custom retryAfter delay
  • error handling retry behavior maxRetries=0 disables retries
  • error handling catchability FatalError can be caught and detected with FatalError.is()
  • hookCleanupTestWorkflow - hook token reuse after workflow completion
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously
  • stepFunctionPassingWorkflow - step function references can be passed as arguments (without closure vars)
  • stepFunctionWithClosureWorkflow - step function with closure variables passed as argument
  • closureVariableWorkflow - nested step functions with closure variables
  • spawnWorkflowFromStepWorkflow - spawning a child workflow using start() inside a step
  • health check (queue-based) - workflow and step endpoints respond to health check messages
  • health check (CLI) - workflow health command reports healthy endpoints
  • pathsAliasWorkflow - TypeScript path aliases resolve correctly
  • Calculator.calculate - static workflow method using static step methods from another class
  • AllInOneService.processNumber - static workflow method using sibling static step methods
  • ChainableService.processWithThis - static step methods using this to reference the class
  • thisSerializationWorkflow - step function invoked with .call() and .apply()
  • customSerializationWorkflow - custom class serialization with WORKFLOW_SERIALIZE/WORKFLOW_DESERIALIZE
  • instanceMethodStepWorkflow - instance methods with "use step" directive
  • crossContextSerdeWorkflow - classes defined in step code are deserializable in workflow context
  • stepFunctionAsStartArgWorkflow - step function reference passed as start() argument
  • pages router addTenWorkflow via pages router
  • pages router promiseAllWorkflow via pages router
  • pages router sleepingWorkflow via pages router

turso (41 failed):

  • addTenWorkflow
  • addTenWorkflow
  • should work with react rendering in step
  • promiseAllWorkflow
  • promiseRaceWorkflow
  • promiseAnyWorkflow
  • hookWorkflow
  • webhookWorkflow
  • sleepingWorkflow
  • nullByteWorkflow
  • workflowAndStepMetadataWorkflow
  • fetchWorkflow
  • promiseRaceStressTestWorkflow
  • error handling error propagation workflow errors nested function calls preserve message and stack trace
  • error handling error propagation workflow errors cross-file imports preserve message and stack trace
  • error handling error propagation step errors basic step error preserves message and stack trace
  • error handling error propagation step errors cross-file step error preserves message and function names in stack
  • error handling retry behavior regular Error retries until success
  • error handling retry behavior FatalError fails immediately without retries
  • error handling retry behavior RetryableError respects custom retryAfter delay
  • error handling retry behavior maxRetries=0 disables retries
  • error handling catchability FatalError can be caught and detected with FatalError.is()
  • hookCleanupTestWorkflow - hook token reuse after workflow completion
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously
  • stepFunctionPassingWorkflow - step function references can be passed as arguments (without closure vars)
  • stepFunctionWithClosureWorkflow - step function with closure variables passed as argument
  • closureVariableWorkflow - nested step functions with closure variables
  • spawnWorkflowFromStepWorkflow - spawning a child workflow using start() inside a step
  • health check (queue-based) - workflow and step endpoints respond to health check messages
  • pathsAliasWorkflow - TypeScript path aliases resolve correctly
  • Calculator.calculate - static workflow method using static step methods from another class
  • AllInOneService.processNumber - static workflow method using sibling static step methods
  • ChainableService.processWithThis - static step methods using this to reference the class
  • thisSerializationWorkflow - step function invoked with .call() and .apply()
  • customSerializationWorkflow - custom class serialization with WORKFLOW_SERIALIZE/WORKFLOW_DESERIALIZE
  • instanceMethodStepWorkflow - instance methods with "use step" directive
  • crossContextSerdeWorkflow - classes defined in step code are deserializable in workflow context
  • stepFunctionAsStartArgWorkflow - step function reference passed as start() argument
  • pages router addTenWorkflow via pages router
  • pages router promiseAllWorkflow via pages router
  • pages router sleepingWorkflow via pages router

Details by Category

✅ ▲ Vercel Production
AppPassedFailedSkipped
✅ astro4404
✅ example4404
✅ express4404
✅ fastify4404
✅ hono4404
✅ nextjs-turbopack4701
✅ nextjs-webpack4701
✅ nitro4404
✅ nuxt4404
✅ sveltekit4404
✅ vite4404
✅ 💻 Local Development
AppPassedFailedSkipped
✅ astro-stable4107
✅ express-stable4107
✅ fastify-stable4107
✅ hono-stable4107
✅ nextjs-turbopack-stable4503
✅ nextjs-webpack-stable4503
✅ nitro-stable4107
✅ nuxt-stable4107
✅ sveltekit-stable4107
✅ vite-stable4107
✅ 📦 Local Production
AppPassedFailedSkipped
✅ astro-stable4107
✅ express-stable4107
✅ fastify-stable4107
✅ hono-stable4107
✅ nextjs-turbopack-stable4503
✅ nextjs-webpack-stable4503
✅ nitro-stable4107
✅ nuxt-stable4107
✅ sveltekit-stable4107
✅ vite-stable4107
✅ 🐘 Local Postgres
AppPassedFailedSkipped
✅ astro-stable4107
✅ express-stable4107
✅ fastify-stable4107
✅ hono-stable4107
✅ nextjs-turbopack-stable4503
✅ nextjs-webpack-stable4503
✅ nitro-stable4107
✅ nuxt-stable4107
✅ sveltekit-stable4107
✅ vite-stable4107
✅ 🪟 Windows
AppPassedFailedSkipped
✅ nextjs-turbopack4503
❌ 🌍 Community Worlds
AppPassedFailedSkipped
✅ mongodb-dev300
❌ mongodb8373
✅ redis-dev300
❌ redis8373
✅ starter-dev300
❌ starter3423
✅ turso-dev300
❌ turso4413
✅ 📋 Other
AppPassedFailedSkipped
✅ e2e-local-dev-nest-stable4107
✅ e2e-local-postgres-nest-stable4107
✅ e2e-local-prod-nest-stable4107

📋 View full workflow run

@vercel

vercelBot commented Jan 30, 2026

Copy link
Copy Markdown
Contributor

@TooTallNateGraphite App

TooTallNate commented Jan 30, 2026

Copy link
Copy Markdown
MemberAuthor

@TooTallNate
TooTallNate marked this pull request as ready for review January 30, 2026 23:59
CopilotAI review requested due to automatic review settings January 30, 2026 23:59
@TooTallNate
TooTallNateforce-pushed the 01-30-fix_discovery_of_serde_classes_to_detect_workflow_serialize_and_workflow_deserialize_computed_property_usage_in_bundled_code branch from e8e5910 to 0a998eeCompareFebruary 3, 2026 08:13
@TooTallNate
TooTallNateforce-pushed the 01-30-new_and_improved_manifest.json_format branch from 70146d0 to 012ec09CompareFebruary 4, 2026 21:44
@TooTallNate
TooTallNateforce-pushed the 01-30-fix_discovery_of_serde_classes_to_detect_workflow_serialize_and_workflow_deserialize_computed_property_usage_in_bundled_code branch from 0a998ee to 697579aCompareFebruary 4, 2026 21:44
…[WORKFLOW_DESERIALIZE]` computed property usage in bundled code
Update comment to describe the preferred approach: adding 'use step'
directives to instance methods that rely on Node.js imports, allowing
those methods to be replaced with step proxy functions and the Node.js
imports to be dead code eliminated.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@TooTallNate@karthikscale3
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Fix discovery of serde classes to detect `[WORKFLOW_SERIALIZE]` and `[WORKFLOW_DESERIALIZE]` computed property usage in bundled code by TooTallNate · Pull Request #908 · vercel/workflow · GitHub
Skip to content

Fix discovery of serde classes to detect [WORKFLOW_SERIALIZE] and [WORKFLOW_DESERIALIZE] computed property usage in bundled code - #908

Merged
TooTallNate merged 2 commits into
mainfrom
01-30-fix_discovery_of_serde_classes_to_detect_workflow_serialize_and_workflow_deserialize_computed_property_usage_in_bundled_code
Feb 9, 2026
Merged

Fix discovery of serde classes to detect [WORKFLOW_SERIALIZE] and [WORKFLOW_DESERIALIZE] computed property usage in bundled code#908
TooTallNate merged 2 commits into
mainfrom
01-30-fix_discovery_of_serde_classes_to_detect_workflow_serialize_and_workflow_deserialize_computed_property_usage_in_bundled_code

Conversation

@TooTallNate

@TooTallNateTooTallNate commented Jan 30, 2026

Copy link
Copy Markdown
Member

Fix detection of serializable classes in bundled code by recognizing computed property usage of [WORKFLOW_SERIALIZE] and [WORKFLOW_DESERIALIZE].

What changed?

  • Added a new regex pattern workflowSerdeComputedPropertyPattern to detect computed property usage of WORKFLOW_SERIALIZE and WORKFLOW_DESERIALIZE symbols
  • Updated detectWorkflowPatterns to identify serializable classes based on this pattern
  • Modified the turbopackContentPattern to include the new pattern for content matching
  • Added serializable files to the bundle entries to ensure proper discovery
  • Fixed method invocation context in serialization by using call() to ensure the class constructor is the this value

How to test?

  1. Create a bundled package that uses WORKFLOW_SERIALIZE and WORKFLOW_DESERIALIZE as computed properties
  2. Verify that the builder correctly identifies these files as containing serializable classes
  3. Confirm that serialization and deserialization work correctly with the proper this context

Why make this change?

When third-party packages are bundled, the standard import pattern detection for @workflow/serde fails because imports are often from internal chunk files rather than directly from the package. This change ensures that serializable classes are properly detected even in bundled code by looking for the actual computed property usage pattern, improving compatibility with bundled dependencies.

@changeset-bot

changeset-botBot commented Jan 30, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 52c4669

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 14 packages
NameType
@workflow/buildersPatch
@workflow/astroPatch
@workflow/cliPatch
@workflow/nestPatch
@workflow/nextPatch
@workflow/nitroPatch
@workflow/rollupPatch
@workflow/sveltekitPatch
@workflow/vitePatch
workflowPatch
@workflow/world-testingPatch
@workflow/nuxtPatch
@workflow/corePatch
@workflow/web-sharedPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions

github-actionsBot commented Jan 30, 2026

Copy link
Copy Markdown
Contributor

🧪 E2E Test Results

Some tests failed

Summary

PassedFailedSkippedTotal
✅ ▲ Vercel Production490038528
✅ 💻 Local Development418062480
✅ 📦 Local Production418062480
✅ 🐘 Local Postgres418062480
✅ 🪟 Windows450348
❌ 🌍 Community Worlds3515712204
✅ 📋 Other123021144
Total19471572602364

❌ Failed Tests

🌍 Community Worlds (157 failed)

mongodb (37 failed):

  • addTenWorkflow
  • addTenWorkflow
  • should work with react rendering in step
  • promiseAllWorkflow
  • promiseRaceWorkflow
  • promiseAnyWorkflow
  • hookWorkflow
  • webhookWorkflow
  • sleepingWorkflow
  • nullByteWorkflow
  • workflowAndStepMetadataWorkflow
  • fetchWorkflow
  • promiseRaceStressTestWorkflow
  • error handling error propagation workflow errors nested function calls preserve message and stack trace
  • error handling error propagation workflow errors cross-file imports preserve message and stack trace
  • error handling error propagation step errors basic step error preserves message and stack trace
  • error handling error propagation step errors cross-file step error preserves message and function names in stack
  • error handling retry behavior regular Error retries until success
  • error handling retry behavior FatalError fails immediately without retries
  • error handling retry behavior RetryableError respects custom retryAfter delay
  • error handling retry behavior maxRetries=0 disables retries
  • error handling catchability FatalError can be caught and detected with FatalError.is()
  • hookCleanupTestWorkflow - hook token reuse after workflow completion
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously
  • stepFunctionPassingWorkflow - step function references can be passed as arguments (without closure vars)
  • stepFunctionWithClosureWorkflow - step function with closure variables passed as argument
  • closureVariableWorkflow - nested step functions with closure variables
  • spawnWorkflowFromStepWorkflow - spawning a child workflow using start() inside a step
  • pathsAliasWorkflow - TypeScript path aliases resolve correctly
  • Calculator.calculate - static workflow method using static step methods from another class
  • AllInOneService.processNumber - static workflow method using sibling static step methods
  • ChainableService.processWithThis - static step methods using this to reference the class
  • thisSerializationWorkflow - step function invoked with .call() and .apply()
  • customSerializationWorkflow - custom class serialization with WORKFLOW_SERIALIZE/WORKFLOW_DESERIALIZE
  • instanceMethodStepWorkflow - instance methods with "use step" directive
  • crossContextSerdeWorkflow - classes defined in step code are deserializable in workflow context
  • stepFunctionAsStartArgWorkflow - step function reference passed as start() argument

redis (37 failed):

  • addTenWorkflow
  • addTenWorkflow
  • should work with react rendering in step
  • promiseAllWorkflow
  • promiseRaceWorkflow
  • promiseAnyWorkflow
  • hookWorkflow
  • webhookWorkflow
  • sleepingWorkflow
  • nullByteWorkflow
  • workflowAndStepMetadataWorkflow
  • fetchWorkflow
  • promiseRaceStressTestWorkflow
  • error handling error propagation workflow errors nested function calls preserve message and stack trace
  • error handling error propagation workflow errors cross-file imports preserve message and stack trace
  • error handling error propagation step errors basic step error preserves message and stack trace
  • error handling error propagation step errors cross-file step error preserves message and function names in stack
  • error handling retry behavior regular Error retries until success
  • error handling retry behavior FatalError fails immediately without retries
  • error handling retry behavior RetryableError respects custom retryAfter delay
  • error handling retry behavior maxRetries=0 disables retries
  • error handling catchability FatalError can be caught and detected with FatalError.is()
  • hookCleanupTestWorkflow - hook token reuse after workflow completion
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously
  • stepFunctionPassingWorkflow - step function references can be passed as arguments (without closure vars)
  • stepFunctionWithClosureWorkflow - step function with closure variables passed as argument
  • closureVariableWorkflow - nested step functions with closure variables
  • spawnWorkflowFromStepWorkflow - spawning a child workflow using start() inside a step
  • pathsAliasWorkflow - TypeScript path aliases resolve correctly
  • Calculator.calculate - static workflow method using static step methods from another class
  • AllInOneService.processNumber - static workflow method using sibling static step methods
  • ChainableService.processWithThis - static step methods using this to reference the class
  • thisSerializationWorkflow - step function invoked with .call() and .apply()
  • customSerializationWorkflow - custom class serialization with WORKFLOW_SERIALIZE/WORKFLOW_DESERIALIZE
  • instanceMethodStepWorkflow - instance methods with "use step" directive
  • crossContextSerdeWorkflow - classes defined in step code are deserializable in workflow context
  • stepFunctionAsStartArgWorkflow - step function reference passed as start() argument

starter (42 failed):

  • addTenWorkflow
  • addTenWorkflow
  • should work with react rendering in step
  • promiseAllWorkflow
  • promiseRaceWorkflow
  • promiseAnyWorkflow
  • hookWorkflow
  • webhookWorkflow
  • sleepingWorkflow
  • nullByteWorkflow
  • workflowAndStepMetadataWorkflow
  • fetchWorkflow
  • promiseRaceStressTestWorkflow
  • error handling error propagation workflow errors nested function calls preserve message and stack trace
  • error handling error propagation workflow errors cross-file imports preserve message and stack trace
  • error handling error propagation step errors basic step error preserves message and stack trace
  • error handling error propagation step errors cross-file step error preserves message and function names in stack
  • error handling retry behavior regular Error retries until success
  • error handling retry behavior FatalError fails immediately without retries
  • error handling retry behavior RetryableError respects custom retryAfter delay
  • error handling retry behavior maxRetries=0 disables retries
  • error handling catchability FatalError can be caught and detected with FatalError.is()
  • hookCleanupTestWorkflow - hook token reuse after workflow completion
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously
  • stepFunctionPassingWorkflow - step function references can be passed as arguments (without closure vars)
  • stepFunctionWithClosureWorkflow - step function with closure variables passed as argument
  • closureVariableWorkflow - nested step functions with closure variables
  • spawnWorkflowFromStepWorkflow - spawning a child workflow using start() inside a step
  • health check (queue-based) - workflow and step endpoints respond to health check messages
  • health check (CLI) - workflow health command reports healthy endpoints
  • pathsAliasWorkflow - TypeScript path aliases resolve correctly
  • Calculator.calculate - static workflow method using static step methods from another class
  • AllInOneService.processNumber - static workflow method using sibling static step methods
  • ChainableService.processWithThis - static step methods using this to reference the class
  • thisSerializationWorkflow - step function invoked with .call() and .apply()
  • customSerializationWorkflow - custom class serialization with WORKFLOW_SERIALIZE/WORKFLOW_DESERIALIZE
  • instanceMethodStepWorkflow - instance methods with "use step" directive
  • crossContextSerdeWorkflow - classes defined in step code are deserializable in workflow context
  • stepFunctionAsStartArgWorkflow - step function reference passed as start() argument
  • pages router addTenWorkflow via pages router
  • pages router promiseAllWorkflow via pages router
  • pages router sleepingWorkflow via pages router

turso (41 failed):

  • addTenWorkflow
  • addTenWorkflow
  • should work with react rendering in step
  • promiseAllWorkflow
  • promiseRaceWorkflow
  • promiseAnyWorkflow
  • hookWorkflow
  • webhookWorkflow
  • sleepingWorkflow
  • nullByteWorkflow
  • workflowAndStepMetadataWorkflow
  • fetchWorkflow
  • promiseRaceStressTestWorkflow
  • error handling error propagation workflow errors nested function calls preserve message and stack trace
  • error handling error propagation workflow errors cross-file imports preserve message and stack trace
  • error handling error propagation step errors basic step error preserves message and stack trace
  • error handling error propagation step errors cross-file step error preserves message and function names in stack
  • error handling retry behavior regular Error retries until success
  • error handling retry behavior FatalError fails immediately without retries
  • error handling retry behavior RetryableError respects custom retryAfter delay
  • error handling retry behavior maxRetries=0 disables retries
  • error handling catchability FatalError can be caught and detected with FatalError.is()
  • hookCleanupTestWorkflow - hook token reuse after workflow completion
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously
  • stepFunctionPassingWorkflow - step function references can be passed as arguments (without closure vars)
  • stepFunctionWithClosureWorkflow - step function with closure variables passed as argument
  • closureVariableWorkflow - nested step functions with closure variables
  • spawnWorkflowFromStepWorkflow - spawning a child workflow using start() inside a step
  • health check (queue-based) - workflow and step endpoints respond to health check messages
  • pathsAliasWorkflow - TypeScript path aliases resolve correctly
  • Calculator.calculate - static workflow method using static step methods from another class
  • AllInOneService.processNumber - static workflow method using sibling static step methods
  • ChainableService.processWithThis - static step methods using this to reference the class
  • thisSerializationWorkflow - step function invoked with .call() and .apply()
  • customSerializationWorkflow - custom class serialization with WORKFLOW_SERIALIZE/WORKFLOW_DESERIALIZE
  • instanceMethodStepWorkflow - instance methods with "use step" directive
  • crossContextSerdeWorkflow - classes defined in step code are deserializable in workflow context
  • stepFunctionAsStartArgWorkflow - step function reference passed as start() argument
  • pages router addTenWorkflow via pages router
  • pages router promiseAllWorkflow via pages router
  • pages router sleepingWorkflow via pages router

Details by Category

✅ ▲ Vercel Production
AppPassedFailedSkipped
✅ astro4404
✅ example4404
✅ express4404
✅ fastify4404
✅ hono4404
✅ nextjs-turbopack4701
✅ nextjs-webpack4701
✅ nitro4404
✅ nuxt4404
✅ sveltekit4404
✅ vite4404
✅ 💻 Local Development
AppPassedFailedSkipped
✅ astro-stable4107
✅ express-stable4107
✅ fastify-stable4107
✅ hono-stable4107
✅ nextjs-turbopack-stable4503
✅ nextjs-webpack-stable4503
✅ nitro-stable4107
✅ nuxt-stable4107
✅ sveltekit-stable4107
✅ vite-stable4107
✅ 📦 Local Production
AppPassedFailedSkipped
✅ astro-stable4107
✅ express-stable4107
✅ fastify-stable4107
✅ hono-stable4107
✅ nextjs-turbopack-stable4503
✅ nextjs-webpack-stable4503
✅ nitro-stable4107
✅ nuxt-stable4107
✅ sveltekit-stable4107
✅ vite-stable4107
✅ 🐘 Local Postgres
AppPassedFailedSkipped
✅ astro-stable4107
✅ express-stable4107
✅ fastify-stable4107
✅ hono-stable4107
✅ nextjs-turbopack-stable4503
✅ nextjs-webpack-stable4503
✅ nitro-stable4107
✅ nuxt-stable4107
✅ sveltekit-stable4107
✅ vite-stable4107
✅ 🪟 Windows
AppPassedFailedSkipped
✅ nextjs-turbopack4503
❌ 🌍 Community Worlds
AppPassedFailedSkipped
✅ mongodb-dev300
❌ mongodb8373
✅ redis-dev300
❌ redis8373
✅ starter-dev300
❌ starter3423
✅ turso-dev300
❌ turso4413
✅ 📋 Other
AppPassedFailedSkipped
✅ e2e-local-dev-nest-stable4107
✅ e2e-local-postgres-nest-stable4107
✅ e2e-local-prod-nest-stable4107

📋 View full workflow run

@vercel

vercelBot commented Jan 30, 2026

Copy link
Copy Markdown
Contributor

@TooTallNateGraphite App

TooTallNate commented Jan 30, 2026

Copy link
Copy Markdown
MemberAuthor

@TooTallNate
TooTallNate marked this pull request as ready for review January 30, 2026 23:59
CopilotAI review requested due to automatic review settings January 30, 2026 23:59
@TooTallNate
TooTallNateforce-pushed the 01-30-fix_discovery_of_serde_classes_to_detect_workflow_serialize_and_workflow_deserialize_computed_property_usage_in_bundled_code branch from e8e5910 to 0a998eeCompareFebruary 3, 2026 08:13
@TooTallNate
TooTallNateforce-pushed the 01-30-new_and_improved_manifest.json_format branch from 70146d0 to 012ec09CompareFebruary 4, 2026 21:44
@TooTallNate
TooTallNateforce-pushed the 01-30-fix_discovery_of_serde_classes_to_detect_workflow_serialize_and_workflow_deserialize_computed_property_usage_in_bundled_code branch from 0a998ee to 697579aCompareFebruary 4, 2026 21:44
…[WORKFLOW_DESERIALIZE]` computed property usage in bundled code
Update comment to describe the preferred approach: adding 'use step'
directives to instance methods that rely on Node.js imports, allowing
those methods to be replaced with step proxy functions and the Node.js
imports to be dead code eliminated.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@TooTallNate@karthikscale3
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Fix discovery of serde classes to detect `[WORKFLOW_SERIALIZE]` and `[WORKFLOW_DESERIALIZE]` computed property usage in bundled code by TooTallNate · Pull Request #908 · vercel/workflow · GitHub
Skip to content

Fix discovery of serde classes to detect [WORKFLOW_SERIALIZE] and [WORKFLOW_DESERIALIZE] computed property usage in bundled code - #908

Merged
TooTallNate merged 2 commits into
mainfrom
01-30-fix_discovery_of_serde_classes_to_detect_workflow_serialize_and_workflow_deserialize_computed_property_usage_in_bundled_code
Feb 9, 2026
Merged

Fix discovery of serde classes to detect [WORKFLOW_SERIALIZE] and [WORKFLOW_DESERIALIZE] computed property usage in bundled code#908
TooTallNate merged 2 commits into
mainfrom
01-30-fix_discovery_of_serde_classes_to_detect_workflow_serialize_and_workflow_deserialize_computed_property_usage_in_bundled_code

Conversation

@TooTallNate

@TooTallNateTooTallNate commented Jan 30, 2026

Copy link
Copy Markdown
Member

Fix detection of serializable classes in bundled code by recognizing computed property usage of [WORKFLOW_SERIALIZE] and [WORKFLOW_DESERIALIZE].

What changed?

  • Added a new regex pattern workflowSerdeComputedPropertyPattern to detect computed property usage of WORKFLOW_SERIALIZE and WORKFLOW_DESERIALIZE symbols
  • Updated detectWorkflowPatterns to identify serializable classes based on this pattern
  • Modified the turbopackContentPattern to include the new pattern for content matching
  • Added serializable files to the bundle entries to ensure proper discovery
  • Fixed method invocation context in serialization by using call() to ensure the class constructor is the this value

How to test?

  1. Create a bundled package that uses WORKFLOW_SERIALIZE and WORKFLOW_DESERIALIZE as computed properties
  2. Verify that the builder correctly identifies these files as containing serializable classes
  3. Confirm that serialization and deserialization work correctly with the proper this context

Why make this change?

When third-party packages are bundled, the standard import pattern detection for @workflow/serde fails because imports are often from internal chunk files rather than directly from the package. This change ensures that serializable classes are properly detected even in bundled code by looking for the actual computed property usage pattern, improving compatibility with bundled dependencies.

@changeset-bot

changeset-botBot commented Jan 30, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 52c4669

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 14 packages
NameType
@workflow/buildersPatch
@workflow/astroPatch
@workflow/cliPatch
@workflow/nestPatch
@workflow/nextPatch
@workflow/nitroPatch
@workflow/rollupPatch
@workflow/sveltekitPatch
@workflow/vitePatch
workflowPatch
@workflow/world-testingPatch
@workflow/nuxtPatch
@workflow/corePatch
@workflow/web-sharedPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions

github-actionsBot commented Jan 30, 2026

Copy link
Copy Markdown
Contributor

🧪 E2E Test Results

Some tests failed

Summary

PassedFailedSkippedTotal
✅ ▲ Vercel Production490038528
✅ 💻 Local Development418062480
✅ 📦 Local Production418062480
✅ 🐘 Local Postgres418062480
✅ 🪟 Windows450348
❌ 🌍 Community Worlds3515712204
✅ 📋 Other123021144
Total19471572602364

❌ Failed Tests

🌍 Community Worlds (157 failed)

mongodb (37 failed):

  • addTenWorkflow
  • addTenWorkflow
  • should work with react rendering in step
  • promiseAllWorkflow
  • promiseRaceWorkflow
  • promiseAnyWorkflow
  • hookWorkflow
  • webhookWorkflow
  • sleepingWorkflow
  • nullByteWorkflow
  • workflowAndStepMetadataWorkflow
  • fetchWorkflow
  • promiseRaceStressTestWorkflow
  • error handling error propagation workflow errors nested function calls preserve message and stack trace
  • error handling error propagation workflow errors cross-file imports preserve message and stack trace
  • error handling error propagation step errors basic step error preserves message and stack trace
  • error handling error propagation step errors cross-file step error preserves message and function names in stack
  • error handling retry behavior regular Error retries until success
  • error handling retry behavior FatalError fails immediately without retries
  • error handling retry behavior RetryableError respects custom retryAfter delay
  • error handling retry behavior maxRetries=0 disables retries
  • error handling catchability FatalError can be caught and detected with FatalError.is()
  • hookCleanupTestWorkflow - hook token reuse after workflow completion
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously
  • stepFunctionPassingWorkflow - step function references can be passed as arguments (without closure vars)
  • stepFunctionWithClosureWorkflow - step function with closure variables passed as argument
  • closureVariableWorkflow - nested step functions with closure variables
  • spawnWorkflowFromStepWorkflow - spawning a child workflow using start() inside a step
  • pathsAliasWorkflow - TypeScript path aliases resolve correctly
  • Calculator.calculate - static workflow method using static step methods from another class
  • AllInOneService.processNumber - static workflow method using sibling static step methods
  • ChainableService.processWithThis - static step methods using this to reference the class
  • thisSerializationWorkflow - step function invoked with .call() and .apply()
  • customSerializationWorkflow - custom class serialization with WORKFLOW_SERIALIZE/WORKFLOW_DESERIALIZE
  • instanceMethodStepWorkflow - instance methods with "use step" directive
  • crossContextSerdeWorkflow - classes defined in step code are deserializable in workflow context
  • stepFunctionAsStartArgWorkflow - step function reference passed as start() argument

redis (37 failed):

  • addTenWorkflow
  • addTenWorkflow
  • should work with react rendering in step
  • promiseAllWorkflow
  • promiseRaceWorkflow
  • promiseAnyWorkflow
  • hookWorkflow
  • webhookWorkflow
  • sleepingWorkflow
  • nullByteWorkflow
  • workflowAndStepMetadataWorkflow
  • fetchWorkflow
  • promiseRaceStressTestWorkflow
  • error handling error propagation workflow errors nested function calls preserve message and stack trace
  • error handling error propagation workflow errors cross-file imports preserve message and stack trace
  • error handling error propagation step errors basic step error preserves message and stack trace
  • error handling error propagation step errors cross-file step error preserves message and function names in stack
  • error handling retry behavior regular Error retries until success
  • error handling retry behavior FatalError fails immediately without retries
  • error handling retry behavior RetryableError respects custom retryAfter delay
  • error handling retry behavior maxRetries=0 disables retries
  • error handling catchability FatalError can be caught and detected with FatalError.is()
  • hookCleanupTestWorkflow - hook token reuse after workflow completion
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously
  • stepFunctionPassingWorkflow - step function references can be passed as arguments (without closure vars)
  • stepFunctionWithClosureWorkflow - step function with closure variables passed as argument
  • closureVariableWorkflow - nested step functions with closure variables
  • spawnWorkflowFromStepWorkflow - spawning a child workflow using start() inside a step
  • pathsAliasWorkflow - TypeScript path aliases resolve correctly
  • Calculator.calculate - static workflow method using static step methods from another class
  • AllInOneService.processNumber - static workflow method using sibling static step methods
  • ChainableService.processWithThis - static step methods using this to reference the class
  • thisSerializationWorkflow - step function invoked with .call() and .apply()
  • customSerializationWorkflow - custom class serialization with WORKFLOW_SERIALIZE/WORKFLOW_DESERIALIZE
  • instanceMethodStepWorkflow - instance methods with "use step" directive
  • crossContextSerdeWorkflow - classes defined in step code are deserializable in workflow context
  • stepFunctionAsStartArgWorkflow - step function reference passed as start() argument

starter (42 failed):

  • addTenWorkflow
  • addTenWorkflow
  • should work with react rendering in step
  • promiseAllWorkflow
  • promiseRaceWorkflow
  • promiseAnyWorkflow
  • hookWorkflow
  • webhookWorkflow
  • sleepingWorkflow
  • nullByteWorkflow
  • workflowAndStepMetadataWorkflow
  • fetchWorkflow
  • promiseRaceStressTestWorkflow
  • error handling error propagation workflow errors nested function calls preserve message and stack trace
  • error handling error propagation workflow errors cross-file imports preserve message and stack trace
  • error handling error propagation step errors basic step error preserves message and stack trace
  • error handling error propagation step errors cross-file step error preserves message and function names in stack
  • error handling retry behavior regular Error retries until success
  • error handling retry behavior FatalError fails immediately without retries
  • error handling retry behavior RetryableError respects custom retryAfter delay
  • error handling retry behavior maxRetries=0 disables retries
  • error handling catchability FatalError can be caught and detected with FatalError.is()
  • hookCleanupTestWorkflow - hook token reuse after workflow completion
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously
  • stepFunctionPassingWorkflow - step function references can be passed as arguments (without closure vars)
  • stepFunctionWithClosureWorkflow - step function with closure variables passed as argument
  • closureVariableWorkflow - nested step functions with closure variables
  • spawnWorkflowFromStepWorkflow - spawning a child workflow using start() inside a step
  • health check (queue-based) - workflow and step endpoints respond to health check messages
  • health check (CLI) - workflow health command reports healthy endpoints
  • pathsAliasWorkflow - TypeScript path aliases resolve correctly
  • Calculator.calculate - static workflow method using static step methods from another class
  • AllInOneService.processNumber - static workflow method using sibling static step methods
  • ChainableService.processWithThis - static step methods using this to reference the class
  • thisSerializationWorkflow - step function invoked with .call() and .apply()
  • customSerializationWorkflow - custom class serialization with WORKFLOW_SERIALIZE/WORKFLOW_DESERIALIZE
  • instanceMethodStepWorkflow - instance methods with "use step" directive
  • crossContextSerdeWorkflow - classes defined in step code are deserializable in workflow context
  • stepFunctionAsStartArgWorkflow - step function reference passed as start() argument
  • pages router addTenWorkflow via pages router
  • pages router promiseAllWorkflow via pages router
  • pages router sleepingWorkflow via pages router

turso (41 failed):

  • addTenWorkflow
  • addTenWorkflow
  • should work with react rendering in step
  • promiseAllWorkflow
  • promiseRaceWorkflow
  • promiseAnyWorkflow
  • hookWorkflow
  • webhookWorkflow
  • sleepingWorkflow
  • nullByteWorkflow
  • workflowAndStepMetadataWorkflow
  • fetchWorkflow
  • promiseRaceStressTestWorkflow
  • error handling error propagation workflow errors nested function calls preserve message and stack trace
  • error handling error propagation workflow errors cross-file imports preserve message and stack trace
  • error handling error propagation step errors basic step error preserves message and stack trace
  • error handling error propagation step errors cross-file step error preserves message and function names in stack
  • error handling retry behavior regular Error retries until success
  • error handling retry behavior FatalError fails immediately without retries
  • error handling retry behavior RetryableError respects custom retryAfter delay
  • error handling retry behavior maxRetries=0 disables retries
  • error handling catchability FatalError can be caught and detected with FatalError.is()
  • hookCleanupTestWorkflow - hook token reuse after workflow completion
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously
  • stepFunctionPassingWorkflow - step function references can be passed as arguments (without closure vars)
  • stepFunctionWithClosureWorkflow - step function with closure variables passed as argument
  • closureVariableWorkflow - nested step functions with closure variables
  • spawnWorkflowFromStepWorkflow - spawning a child workflow using start() inside a step
  • health check (queue-based) - workflow and step endpoints respond to health check messages
  • pathsAliasWorkflow - TypeScript path aliases resolve correctly
  • Calculator.calculate - static workflow method using static step methods from another class
  • AllInOneService.processNumber - static workflow method using sibling static step methods
  • ChainableService.processWithThis - static step methods using this to reference the class
  • thisSerializationWorkflow - step function invoked with .call() and .apply()
  • customSerializationWorkflow - custom class serialization with WORKFLOW_SERIALIZE/WORKFLOW_DESERIALIZE
  • instanceMethodStepWorkflow - instance methods with "use step" directive
  • crossContextSerdeWorkflow - classes defined in step code are deserializable in workflow context
  • stepFunctionAsStartArgWorkflow - step function reference passed as start() argument
  • pages router addTenWorkflow via pages router
  • pages router promiseAllWorkflow via pages router
  • pages router sleepingWorkflow via pages router

Details by Category

✅ ▲ Vercel Production
AppPassedFailedSkipped
✅ astro4404
✅ example4404
✅ express4404
✅ fastify4404
✅ hono4404
✅ nextjs-turbopack4701
✅ nextjs-webpack4701
✅ nitro4404
✅ nuxt4404
✅ sveltekit4404
✅ vite4404
✅ 💻 Local Development
AppPassedFailedSkipped
✅ astro-stable4107
✅ express-stable4107
✅ fastify-stable4107
✅ hono-stable4107
✅ nextjs-turbopack-stable4503
✅ nextjs-webpack-stable4503
✅ nitro-stable4107
✅ nuxt-stable4107
✅ sveltekit-stable4107
✅ vite-stable4107
✅ 📦 Local Production
AppPassedFailedSkipped
✅ astro-stable4107
✅ express-stable4107
✅ fastify-stable4107
✅ hono-stable4107
✅ nextjs-turbopack-stable4503
✅ nextjs-webpack-stable4503
✅ nitro-stable4107
✅ nuxt-stable4107
✅ sveltekit-stable4107
✅ vite-stable4107
✅ 🐘 Local Postgres
AppPassedFailedSkipped
✅ astro-stable4107
✅ express-stable4107
✅ fastify-stable4107
✅ hono-stable4107
✅ nextjs-turbopack-stable4503
✅ nextjs-webpack-stable4503
✅ nitro-stable4107
✅ nuxt-stable4107
✅ sveltekit-stable4107
✅ vite-stable4107
✅ 🪟 Windows
AppPassedFailedSkipped
✅ nextjs-turbopack4503
❌ 🌍 Community Worlds
AppPassedFailedSkipped
✅ mongodb-dev300
❌ mongodb8373
✅ redis-dev300
❌ redis8373
✅ starter-dev300
❌ starter3423
✅ turso-dev300
❌ turso4413
✅ 📋 Other
AppPassedFailedSkipped
✅ e2e-local-dev-nest-stable4107
✅ e2e-local-postgres-nest-stable4107
✅ e2e-local-prod-nest-stable4107

📋 View full workflow run

@vercel

vercelBot commented Jan 30, 2026

Copy link
Copy Markdown
Contributor

@TooTallNateGraphite App

TooTallNate commented Jan 30, 2026

Copy link
Copy Markdown
MemberAuthor

@TooTallNate
TooTallNate marked this pull request as ready for review January 30, 2026 23:59
CopilotAI review requested due to automatic review settings January 30, 2026 23:59
@TooTallNate
TooTallNateforce-pushed the 01-30-fix_discovery_of_serde_classes_to_detect_workflow_serialize_and_workflow_deserialize_computed_property_usage_in_bundled_code branch from e8e5910 to 0a998eeCompareFebruary 3, 2026 08:13
@TooTallNate
TooTallNateforce-pushed the 01-30-new_and_improved_manifest.json_format branch from 70146d0 to 012ec09CompareFebruary 4, 2026 21:44
@TooTallNate
TooTallNateforce-pushed the 01-30-fix_discovery_of_serde_classes_to_detect_workflow_serialize_and_workflow_deserialize_computed_property_usage_in_bundled_code branch from 0a998ee to 697579aCompareFebruary 4, 2026 21:44
…[WORKFLOW_DESERIALIZE]` computed property usage in bundled code
Update comment to describe the preferred approach: adding 'use step'
directives to instance methods that rely on Node.js imports, allowing
those methods to be replaced with step proxy functions and the Node.js
imports to be dead code eliminated.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@TooTallNate@karthikscale3
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })(); Fix discovery of serde classes to detect `[WORKFLOW_SERIALIZE]` and `[WORKFLOW_DESERIALIZE]` computed property usage in bundled code by TooTallNate · Pull Request #908 · vercel/workflow · GitHub
Skip to content

Fix discovery of serde classes to detect [WORKFLOW_SERIALIZE] and [WORKFLOW_DESERIALIZE] computed property usage in bundled code - #908

Merged
TooTallNate merged 2 commits into
mainfrom
01-30-fix_discovery_of_serde_classes_to_detect_workflow_serialize_and_workflow_deserialize_computed_property_usage_in_bundled_code
Feb 9, 2026
Merged

Fix discovery of serde classes to detect [WORKFLOW_SERIALIZE] and [WORKFLOW_DESERIALIZE] computed property usage in bundled code#908
TooTallNate merged 2 commits into
mainfrom
01-30-fix_discovery_of_serde_classes_to_detect_workflow_serialize_and_workflow_deserialize_computed_property_usage_in_bundled_code

Conversation

@TooTallNate

@TooTallNateTooTallNate commented Jan 30, 2026

Copy link
Copy Markdown
Member

Fix detection of serializable classes in bundled code by recognizing computed property usage of [WORKFLOW_SERIALIZE] and [WORKFLOW_DESERIALIZE].

What changed?

  • Added a new regex pattern workflowSerdeComputedPropertyPattern to detect computed property usage of WORKFLOW_SERIALIZE and WORKFLOW_DESERIALIZE symbols
  • Updated detectWorkflowPatterns to identify serializable classes based on this pattern
  • Modified the turbopackContentPattern to include the new pattern for content matching
  • Added serializable files to the bundle entries to ensure proper discovery
  • Fixed method invocation context in serialization by using call() to ensure the class constructor is the this value

How to test?

  1. Create a bundled package that uses WORKFLOW_SERIALIZE and WORKFLOW_DESERIALIZE as computed properties
  2. Verify that the builder correctly identifies these files as containing serializable classes
  3. Confirm that serialization and deserialization work correctly with the proper this context

Why make this change?

When third-party packages are bundled, the standard import pattern detection for @workflow/serde fails because imports are often from internal chunk files rather than directly from the package. This change ensures that serializable classes are properly detected even in bundled code by looking for the actual computed property usage pattern, improving compatibility with bundled dependencies.

@changeset-bot

changeset-botBot commented Jan 30, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 52c4669

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 14 packages
NameType
@workflow/buildersPatch
@workflow/astroPatch
@workflow/cliPatch
@workflow/nestPatch
@workflow/nextPatch
@workflow/nitroPatch
@workflow/rollupPatch
@workflow/sveltekitPatch
@workflow/vitePatch
workflowPatch
@workflow/world-testingPatch
@workflow/nuxtPatch
@workflow/corePatch
@workflow/web-sharedPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions

github-actionsBot commented Jan 30, 2026

Copy link
Copy Markdown
Contributor

🧪 E2E Test Results

Some tests failed

Summary

PassedFailedSkippedTotal
✅ ▲ Vercel Production490038528
✅ 💻 Local Development418062480
✅ 📦 Local Production418062480
✅ 🐘 Local Postgres418062480
✅ 🪟 Windows450348
❌ 🌍 Community Worlds3515712204
✅ 📋 Other123021144
Total19471572602364

❌ Failed Tests

🌍 Community Worlds (157 failed)

mongodb (37 failed):

  • addTenWorkflow
  • addTenWorkflow
  • should work with react rendering in step
  • promiseAllWorkflow
  • promiseRaceWorkflow
  • promiseAnyWorkflow
  • hookWorkflow
  • webhookWorkflow
  • sleepingWorkflow
  • nullByteWorkflow
  • workflowAndStepMetadataWorkflow
  • fetchWorkflow
  • promiseRaceStressTestWorkflow
  • error handling error propagation workflow errors nested function calls preserve message and stack trace
  • error handling error propagation workflow errors cross-file imports preserve message and stack trace
  • error handling error propagation step errors basic step error preserves message and stack trace
  • error handling error propagation step errors cross-file step error preserves message and function names in stack
  • error handling retry behavior regular Error retries until success
  • error handling retry behavior FatalError fails immediately without retries
  • error handling retry behavior RetryableError respects custom retryAfter delay
  • error handling retry behavior maxRetries=0 disables retries
  • error handling catchability FatalError can be caught and detected with FatalError.is()
  • hookCleanupTestWorkflow - hook token reuse after workflow completion
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously
  • stepFunctionPassingWorkflow - step function references can be passed as arguments (without closure vars)
  • stepFunctionWithClosureWorkflow - step function with closure variables passed as argument
  • closureVariableWorkflow - nested step functions with closure variables
  • spawnWorkflowFromStepWorkflow - spawning a child workflow using start() inside a step
  • pathsAliasWorkflow - TypeScript path aliases resolve correctly
  • Calculator.calculate - static workflow method using static step methods from another class
  • AllInOneService.processNumber - static workflow method using sibling static step methods
  • ChainableService.processWithThis - static step methods using this to reference the class
  • thisSerializationWorkflow - step function invoked with .call() and .apply()
  • customSerializationWorkflow - custom class serialization with WORKFLOW_SERIALIZE/WORKFLOW_DESERIALIZE
  • instanceMethodStepWorkflow - instance methods with "use step" directive
  • crossContextSerdeWorkflow - classes defined in step code are deserializable in workflow context
  • stepFunctionAsStartArgWorkflow - step function reference passed as start() argument

redis (37 failed):

  • addTenWorkflow
  • addTenWorkflow
  • should work with react rendering in step
  • promiseAllWorkflow
  • promiseRaceWorkflow
  • promiseAnyWorkflow
  • hookWorkflow
  • webhookWorkflow
  • sleepingWorkflow
  • nullByteWorkflow
  • workflowAndStepMetadataWorkflow
  • fetchWorkflow
  • promiseRaceStressTestWorkflow
  • error handling error propagation workflow errors nested function calls preserve message and stack trace
  • error handling error propagation workflow errors cross-file imports preserve message and stack trace
  • error handling error propagation step errors basic step error preserves message and stack trace
  • error handling error propagation step errors cross-file step error preserves message and function names in stack
  • error handling retry behavior regular Error retries until success
  • error handling retry behavior FatalError fails immediately without retries
  • error handling retry behavior RetryableError respects custom retryAfter delay
  • error handling retry behavior maxRetries=0 disables retries
  • error handling catchability FatalError can be caught and detected with FatalError.is()
  • hookCleanupTestWorkflow - hook token reuse after workflow completion
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously
  • stepFunctionPassingWorkflow - step function references can be passed as arguments (without closure vars)
  • stepFunctionWithClosureWorkflow - step function with closure variables passed as argument
  • closureVariableWorkflow - nested step functions with closure variables
  • spawnWorkflowFromStepWorkflow - spawning a child workflow using start() inside a step
  • pathsAliasWorkflow - TypeScript path aliases resolve correctly
  • Calculator.calculate - static workflow method using static step methods from another class
  • AllInOneService.processNumber - static workflow method using sibling static step methods
  • ChainableService.processWithThis - static step methods using this to reference the class
  • thisSerializationWorkflow - step function invoked with .call() and .apply()
  • customSerializationWorkflow - custom class serialization with WORKFLOW_SERIALIZE/WORKFLOW_DESERIALIZE
  • instanceMethodStepWorkflow - instance methods with "use step" directive
  • crossContextSerdeWorkflow - classes defined in step code are deserializable in workflow context
  • stepFunctionAsStartArgWorkflow - step function reference passed as start() argument

starter (42 failed):

  • addTenWorkflow
  • addTenWorkflow
  • should work with react rendering in step
  • promiseAllWorkflow
  • promiseRaceWorkflow
  • promiseAnyWorkflow
  • hookWorkflow
  • webhookWorkflow
  • sleepingWorkflow
  • nullByteWorkflow
  • workflowAndStepMetadataWorkflow
  • fetchWorkflow
  • promiseRaceStressTestWorkflow
  • error handling error propagation workflow errors nested function calls preserve message and stack trace
  • error handling error propagation workflow errors cross-file imports preserve message and stack trace
  • error handling error propagation step errors basic step error preserves message and stack trace
  • error handling error propagation step errors cross-file step error preserves message and function names in stack
  • error handling retry behavior regular Error retries until success
  • error handling retry behavior FatalError fails immediately without retries
  • error handling retry behavior RetryableError respects custom retryAfter delay
  • error handling retry behavior maxRetries=0 disables retries
  • error handling catchability FatalError can be caught and detected with FatalError.is()
  • hookCleanupTestWorkflow - hook token reuse after workflow completion
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously
  • stepFunctionPassingWorkflow - step function references can be passed as arguments (without closure vars)
  • stepFunctionWithClosureWorkflow - step function with closure variables passed as argument
  • closureVariableWorkflow - nested step functions with closure variables
  • spawnWorkflowFromStepWorkflow - spawning a child workflow using start() inside a step
  • health check (queue-based) - workflow and step endpoints respond to health check messages
  • health check (CLI) - workflow health command reports healthy endpoints
  • pathsAliasWorkflow - TypeScript path aliases resolve correctly
  • Calculator.calculate - static workflow method using static step methods from another class
  • AllInOneService.processNumber - static workflow method using sibling static step methods
  • ChainableService.processWithThis - static step methods using this to reference the class
  • thisSerializationWorkflow - step function invoked with .call() and .apply()
  • customSerializationWorkflow - custom class serialization with WORKFLOW_SERIALIZE/WORKFLOW_DESERIALIZE
  • instanceMethodStepWorkflow - instance methods with "use step" directive
  • crossContextSerdeWorkflow - classes defined in step code are deserializable in workflow context
  • stepFunctionAsStartArgWorkflow - step function reference passed as start() argument
  • pages router addTenWorkflow via pages router
  • pages router promiseAllWorkflow via pages router
  • pages router sleepingWorkflow via pages router

turso (41 failed):

  • addTenWorkflow
  • addTenWorkflow
  • should work with react rendering in step
  • promiseAllWorkflow
  • promiseRaceWorkflow
  • promiseAnyWorkflow
  • hookWorkflow
  • webhookWorkflow
  • sleepingWorkflow
  • nullByteWorkflow
  • workflowAndStepMetadataWorkflow
  • fetchWorkflow
  • promiseRaceStressTestWorkflow
  • error handling error propagation workflow errors nested function calls preserve message and stack trace
  • error handling error propagation workflow errors cross-file imports preserve message and stack trace
  • error handling error propagation step errors basic step error preserves message and stack trace
  • error handling error propagation step errors cross-file step error preserves message and function names in stack
  • error handling retry behavior regular Error retries until success
  • error handling retry behavior FatalError fails immediately without retries
  • error handling retry behavior RetryableError respects custom retryAfter delay
  • error handling retry behavior maxRetries=0 disables retries
  • error handling catchability FatalError can be caught and detected with FatalError.is()
  • hookCleanupTestWorkflow - hook token reuse after workflow completion
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously
  • stepFunctionPassingWorkflow - step function references can be passed as arguments (without closure vars)
  • stepFunctionWithClosureWorkflow - step function with closure variables passed as argument
  • closureVariableWorkflow - nested step functions with closure variables
  • spawnWorkflowFromStepWorkflow - spawning a child workflow using start() inside a step
  • health check (queue-based) - workflow and step endpoints respond to health check messages
  • pathsAliasWorkflow - TypeScript path aliases resolve correctly
  • Calculator.calculate - static workflow method using static step methods from another class
  • AllInOneService.processNumber - static workflow method using sibling static step methods
  • ChainableService.processWithThis - static step methods using this to reference the class
  • thisSerializationWorkflow - step function invoked with .call() and .apply()
  • customSerializationWorkflow - custom class serialization with WORKFLOW_SERIALIZE/WORKFLOW_DESERIALIZE
  • instanceMethodStepWorkflow - instance methods with "use step" directive
  • crossContextSerdeWorkflow - classes defined in step code are deserializable in workflow context
  • stepFunctionAsStartArgWorkflow - step function reference passed as start() argument
  • pages router addTenWorkflow via pages router
  • pages router promiseAllWorkflow via pages router
  • pages router sleepingWorkflow via pages router

Details by Category

✅ ▲ Vercel Production
AppPassedFailedSkipped
✅ astro4404
✅ example4404
✅ express4404
✅ fastify4404
✅ hono4404
✅ nextjs-turbopack4701
✅ nextjs-webpack4701
✅ nitro4404
✅ nuxt4404
✅ sveltekit4404
✅ vite4404
✅ 💻 Local Development
AppPassedFailedSkipped
✅ astro-stable4107
✅ express-stable4107
✅ fastify-stable4107
✅ hono-stable4107
✅ nextjs-turbopack-stable4503
✅ nextjs-webpack-stable4503
✅ nitro-stable4107
✅ nuxt-stable4107
✅ sveltekit-stable4107
✅ vite-stable4107
✅ 📦 Local Production
AppPassedFailedSkipped
✅ astro-stable4107
✅ express-stable4107
✅ fastify-stable4107
✅ hono-stable4107
✅ nextjs-turbopack-stable4503
✅ nextjs-webpack-stable4503
✅ nitro-stable4107
✅ nuxt-stable4107
✅ sveltekit-stable4107
✅ vite-stable4107
✅ 🐘 Local Postgres
AppPassedFailedSkipped
✅ astro-stable4107
✅ express-stable4107
✅ fastify-stable4107
✅ hono-stable4107
✅ nextjs-turbopack-stable4503
✅ nextjs-webpack-stable4503
✅ nitro-stable4107
✅ nuxt-stable4107
✅ sveltekit-stable4107
✅ vite-stable4107
✅ 🪟 Windows
AppPassedFailedSkipped
✅ nextjs-turbopack4503
❌ 🌍 Community Worlds
AppPassedFailedSkipped
✅ mongodb-dev300
❌ mongodb8373
✅ redis-dev300
❌ redis8373
✅ starter-dev300
❌ starter3423
✅ turso-dev300
❌ turso4413
✅ 📋 Other
AppPassedFailedSkipped
✅ e2e-local-dev-nest-stable4107
✅ e2e-local-postgres-nest-stable4107
✅ e2e-local-prod-nest-stable4107

📋 View full workflow run

@vercel

vercelBot commented Jan 30, 2026

Copy link
Copy Markdown
Contributor

@TooTallNateGraphite App

TooTallNate commented Jan 30, 2026

Copy link
Copy Markdown
MemberAuthor

@TooTallNate
TooTallNate marked this pull request as ready for review January 30, 2026 23:59
CopilotAI review requested due to automatic review settings January 30, 2026 23:59
@TooTallNate
TooTallNateforce-pushed the 01-30-fix_discovery_of_serde_classes_to_detect_workflow_serialize_and_workflow_deserialize_computed_property_usage_in_bundled_code branch from e8e5910 to 0a998eeCompareFebruary 3, 2026 08:13
@TooTallNate
TooTallNateforce-pushed the 01-30-new_and_improved_manifest.json_format branch from 70146d0 to 012ec09CompareFebruary 4, 2026 21:44
@TooTallNate
TooTallNateforce-pushed the 01-30-fix_discovery_of_serde_classes_to_detect_workflow_serialize_and_workflow_deserialize_computed_property_usage_in_bundled_code branch from 0a998ee to 697579aCompareFebruary 4, 2026 21:44
…[WORKFLOW_DESERIALIZE]` computed property usage in bundled code
Update comment to describe the preferred approach: adding 'use step'
directives to instance methods that rely on Node.js imports, allowing
those methods to be replaced with step proxy functions and the Node.js
imports to be dead code eliminated.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@TooTallNate@karthikscale3