Skip to content

New progress bar for unknown amount of iterations in advance - #26

Open
farchy wants to merge 6 commits into
verigak:masterfrom
farchy:adding_adapting_infinite_bar
Open

New progress bar for unknown amount of iterations in advance#26
farchy wants to merge 6 commits into
verigak:masterfrom
farchy:adding_adapting_infinite_bar

Conversation

@farchy

Copy link
Copy Markdown

Added a new progress bar for infinite (unknown max) iterations.
Added a test for it in test_progress.py

  • edited relevant README.rst section

@verigak

Copy link
Copy Markdown
Owner

Hi, this is very interesting, but the implementation can be simplified a lot. You can implement an AdaptiveMixin that overrides percent and progress. Then AdaptiveBar can become a one liner:

classAdaptiveBar(AdaptiveMixin, IncrementalBar): pass

That way you can make any of the existing bars become adaptive.

@farchy

Copy link
Copy Markdown
Author

ACK, will change the implementation...
Would you prefer that as a new PR or keep working on this?

@verigak

Copy link
Copy Markdown
Owner

Let's keep working on this one for now and see if we can squash the commits in the end.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@farchy@verigak