Implement fast-pagination - #48
Closed
ryanmaxwell wants to merge 1 commit into
Closed
Conversation
|
I also stumbled over this shortcoming and would like to see this fixed! 👍 |
|
Yes this is a problem for me too. A deal-breaker IMO. |
|
Yes, it's a big improvement on UX. Thanks! |
|
Great pull request. Reader is a great library, but unfortnently the fast scrolling issue makes it hard to ship in a public app. Please take a look at this and consider merging it to master @vfr |
Owner
|
Fixed in v2.8.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi - nice project. I have been using this library within a project I am working on and it has been great. One thing that I felt needed improvement was the pagination. When you reached the end of the preloaded pages (3 by default), you will get a "bounce" and have to wait until the scroll view decelerates until you can continue.
This made it rather difficult to scroll quickly through several pages quickly. I have adjusted the behaviour in this feature branch to fix that annoyance.
I have made several other customisations to the project, I will likely publish them as separate branches and do pull requests when I think they are ready (and if you'd like them), however I feel this patch is beneficial to almost everyone as it improves user experience.
Cheers!