docs: show a commerce screen, not just dashboards - #210
Merged
Conversation
The v2.1.0 headline is commerce fluency, and every screenshot in the README was a dashboard. Adds a checkout to the "What an agent actually ships" section, built end to end against the published 2.1.0 package rather than the working tree — so it demonstrates what a user installing framesmith today actually gets. One generate_design_system call (#A24B1E on the "soft" personality), the settings page scaffold adapted into a two-column checkout, a stamped form-field, and real radio/checkbox/input controls. Stamped with the new commerce genre so the line prices and total read as the design rather than as fabricated data. It cleared the same bar as the two dashboards above it: 100/100, zero blocking issues, canvas_stress CLEAN across all five perturbations, and correct in both themes — plus designed empty-basket and loading states, which the coverage check required before it would call the screen done. The canvases themselves stay local, matching how .framesmith/ui/ has always been treated: only the curated pattern library and design system are checked in, so a new user still starts with an empty store.
The discoverability guard requires any passage that offers one honest-content genre to offer all of them, so a reader learns the full set rather than half of it. The caption named `commerce` while "dashboard" appeared only as prose, which the guard correctly did not count as naming the genre. Rewritten to name `dashboard` as the transactional counterpart, which is more useful to a reader than the original phrasing was.
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v2.1.0 headline is commerce fluency, and every screenshot in the README was a dashboard. This adds a checkout to the "What an agent actually ships" section.
It was built against the published 2.1.0 package, not the working tree — the MCP server runs
npx -y framesmith, so this demonstrates what someone installing framesmith today actually gets, rather than what is on master.How it was built
One
generate_design_systemcall (#A24B1Eon thesoftpersonality) for the whole design language, thesettingspage scaffold adapted into a two-column checkout, a stampedform-field, and realradio/checkbox/ input controls rather than frames pretending to be them. Stamped with the newcommercegenre, which is the point: the evaluator reads the line prices and the total as the design instead of as fabricated data.It cleared the same bar as the two dashboards above it — 100/100, zero blocking issues,
canvas_stressCLEAN across all five perturbations, correct in both themes — plus designed empty-basket and loading states, which the coverage check demanded before it would call the screen done.Three things the build surfaced
These are findings, not blockers for this pull request, and none of them are fixed here.
apply_structuresilently wipes a genre stamp. I calledcanvas_set_genrewithcommercefirst, then stamped the page scaffold. Stamping records provenance and overwrote the wholeprovenanceobject, so the genre went with it — the next evaluation reportedgenre.active: nulland flagged all six money figures as fabricated. Re-stamping afterwards fixed it and reportedprevious: null, confirming the stamp was gone rather than replaced. Stamping should merge into provenance instead of replacing it, orapply_structureshould preserve an existing preset.exporthas nofullPage. Slice E of Phase 29 addedfullPagetoscreenshotbut not toexport, so exporting a design taller than its artboard still needs the height passed by hand. The two tools should agree.The eyebrow-rhythm tell counts form-field labels. It fires on text at or below the
labelrole size that is uppercase or letter-spaced — and thesoftpersonality'slabelrole carriesletterSpacing: 0.25, so every small label in the design inherited eyebrow tracking and eleven ordinary form labels were counted as eyebrows. Setting the canvas'slabelrole toletterSpacing: 0fixed it and is the right call for a form-heavy screen anyway, but the tell probably should not count a label that sits directly above an input.What is and is not committed
Only the image and the README change. The canvases stay local, matching how
.framesmith/ui/has always been treated — just the curated pattern library and design system are checked in, so a new user still starts with an empty store.