Skip to content

Fix vint errors - #136

Merged
tyru merged 8 commits into
masterfrom
run-vint-on-travis
Aug 6, 2019
Merged

Fix vint errors#136
tyru merged 8 commits into
masterfrom
run-vint-on-travis

Conversation

@tyru

@tyrutyru commented Aug 1, 2019

Copy link
Copy Markdown
Member

Fix#111

@tyru
tyruforce-pushed the run-vint-on-travis branch from 6662c36 to d94a282CompareAugust 1, 2019 15:23
@tyru

tyru commented Aug 1, 2019

Copy link
Copy Markdown
MemberAuthor

travis checks are not showed... wtf?
image
but build seems working.
https://travis-ci.org/vim-jp/vim-vimlparser/builds/566529436

@blueyed do you know something about this...? ;)

@tyru

tyru commented Aug 1, 2019

Copy link
Copy Markdown
MemberAuthor

@blueyed and can you review this?

tyru
tyru commented Aug 1, 2019
View reviewed changes
Comment threadautoload/vimlparser.vim Outdated
function! s:numtoname(num) abort
let sig = printf("function('%s')", a:num)
for k in keys(s:)
if type(s:[k]) == type({})

@tyrutyruAug 1, 2019

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why vint does not show error about this? 🤔

@tyru

tyru commented Aug 1, 2019

Copy link
Copy Markdown
MemberAuthor

image
now I figured out organization grant was revoked... (why?)
granted permission and now travis appears, but codecov disappered!? 🤣
image

@tyru
tyruforce-pushed the run-vint-on-travis branch from 07ea28e to d94a282CompareAugust 1, 2019 16:07
@tyru
== -> ==#
b0018dc
vint didn't complain about these cases...
@tyru

tyru commented Aug 2, 2019

Copy link
Copy Markdown
MemberAuthor

Fixed == to ==#. b0018dc
I don't know why vint did not show the errors about this though.

@tyru
tyru requested a review from blueyedAugust 2, 2019 10:38
@tyru

tyru commented Aug 2, 2019

Copy link
Copy Markdown
MemberAuthor

@blueyed review please 🙏

@tyru
tyruforce-pushed the run-vint-on-travis branch from 5873f0e to 40f21cbCompareAugust 2, 2019 11:25
@tyrutyru mentioned this pull request Aug 2, 2019
Open
@blueyedblueyed mentioned this pull request Aug 3, 2019
Merged
@blueyed

blueyed commented Aug 3, 2019

Copy link
Copy Markdown
Contributor

Trying a different approach in #139.

@blueyed

blueyed commented Aug 3, 2019

Copy link
Copy Markdown
Contributor

I think #139 is slightly better by using "checkvim".
It uses the master branch to fix installation issues - I should really find some time to fix vint / release 0.4..

@blueyed

blueyed commented Aug 3, 2019

Copy link
Copy Markdown
Contributor

We can pick your fixed into it - or the other way around.

@tyrutyru changed the title Run vint on travisFix vint errorsAug 6, 2019
@tyru
tyru merged commit 847601a into masterAug 6, 2019
@tyru
tyru deleted the run-vint-on-travis branch August 6, 2019 23:07
@tyrutyru mentioned this pull request Aug 6, 2019
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blueyedblueyedAwaiting requested review from blueyed

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Run vint on CI

2 participants

@tyru@blueyed