Skip to content

added custom color palette e2e tests - #2124

Open
noahonyejese wants to merge 18 commits into
mainfrom
test/custom-color-palette-e2e
Open

added custom color palette e2e tests#2124
noahonyejese wants to merge 18 commits into
mainfrom
test/custom-color-palette-e2e

Conversation

@noahonyejese

Copy link
Copy Markdown
Contributor

This PR adds an e2e test for custom color palettes on the profile page.

  • Add a CHANGELOG entry

@vercel

vercelBot commented Feb 19, 2025

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for Git ↗︎

NameStatusPreviewCommentsUpdated (UTC)
visualization-tool✅ Ready (Inspect)Visit Preview💬 Add feedbackFeb 28, 2025 0:22am

@noahonyejesenoahonyejese changed the title chore: adjusted test scriptsadded custom color palette e2e testsFeb 20, 2025

@bprusinowskibprusinowski left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @noahonyejese 🙇‍♂️ Only one question on removing the palettes :)

Comment threade2e/custom-color-palette.spec.ts
Comment threade2e/custom-color-palette.spec.ts
@noahonyejese

Copy link
Copy Markdown
ContributorAuthor

@bprusinowski not sure why one of the tests is failing - do you maybe know?

@bprusinowski

Copy link
Copy Markdown
Member

@noahonyejese I checked the blob report from the failed test, and it looks like we have a "Error: locator.isVisible: Error: strict mode violation: getByText('Categorical Palette') resolved to 2 elements" error.

Looking at Argos screenshot, in fact there are two palette names that contain this string – I think you'd need to try to match by exact text, not only by checking if an element "contains text"?

@noahonyejese

Copy link
Copy Markdown
ContributorAuthor

@noahonyejese I checked the blob report from the failed test, and it looks like we have a "Error: locator.isVisible: Error: strict mode violation: getByText('Categorical Palette') resolved to 2 elements" error.

Looking at Argos screenshot, in fact there are two palette names that contain this string – I think you'd need to try to match by exact text, not only by checking if an element "contains text"?

Not sure because it was working on local

@bprusinowski

Copy link
Copy Markdown
Member

@noahonyejese yes, but here the user had a TEST CATEGORICAL PALETTE added, coming from a database, that you probably didn't have on local 🤔

@noahonyejese

Copy link
Copy Markdown
ContributorAuthor

@noahonyejese yes, but here the user had a TEST CATEGORICAL PALETTE added, coming from a database, that you probably didn't have on local 🤔

I mean adjusted it now it should use the approach you mentioned but it still doesn't seem to work - I will get back to this PR once completing the higher priority stuff. @bprusinowski

@noahonyejese

Copy link
Copy Markdown
ContributorAuthor

@bprusinowski where can I get the blob report?

@bprusinowski

Copy link
Copy Markdown
Member

@noahonyejese it looks like something's still off with setting the custom color palettes in end-to-end tests, see the screenshot of failed action there: https://app.argos-ci.com/interactive-things/visualization-tool/builds/452/140680285

It looks like a palette with this name already exists 🤔

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@noahonyejese@bprusinowski