feat(vitest): support vi.waitFor method - #4113
Merged
Merged
Conversation
commented
Sep 12, 2023
|
|
✅ Deploy Preview for fastidious-cascaron-4ded94 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
sheremet-va
requested changes
Sep 12, 2023
AriPerkkio
reviewed
Sep 12, 2023
Dunqing
commented
Sep 12, 2023
added 2 commits
September 12, 2023 19:03
sheremet-va
reviewed
Sep 13, 2023
sheremet-va
requested changes
Sep 13, 2023
sheremet-va
requested changes
Sep 13, 2023
Co-authored-by: Vladimir <sleuths.slews0s@icloud.com>
Co-authored-by: Vladimir <sleuths.slews0s@icloud.com>
Co-authored-by: Vladimir <sleuths.slews0s@icloud.com>
sheremet-va
approved these changes
Sep 13, 2023
commented
Sep 13, 2023
Member
|
I would assume |
commented
Sep 13, 2023
Member
Author
Yes. Do we still need it? Looks like |
commented
Sep 13, 2023
Member
Yes, we still need both. |
This was referenced Sep 29, 2023
1 task
Merged
10 tasks
24 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Partial closes - #4061
The
waitForfunction was inspired by testing-library/web-testing-library#2.Currently only supports
timeoutandintervaloptions. I think this is enough, Let me know if you need to add any other options!Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.