Vp lint ignores nested package `ignorePattern`

[rajzik]

Describe the bug

The nested vite-plus config in packages/some-package/vite.config.ts defines ignorePatterns: ["tests/fixtures/**/*"] to exclude test fixtures from linting. The root vite.config.ts defines lint rules including import/no-commonjs. When vite-plus merges these configs, it applies the root's import/no-commonjs rule to the sub-package but does not respect the sub-package's ignorePatterns. As a result, tests/fixtures/should-ignore-this.cjs gets linted and fails with an import/no-commonjs error, even though it should be ignored.

Expected: Files matching ignorePatterns in the nested config are excluded from linting.

Actual: ignorePatterns from the nested config is not applied (or is overridden during config merging), causing fixture files to be linted against inherited rules.

Reproduction

https://github.com/rajzik/vite-plus-repro

Steps to reproduce

1. Create a monorepo with vite-plus and turbo as dev dependencies.
2. Define a root vite.config.ts with a lint rule:

import { defineConfig } from "vite-plus";
export default defineConfig({
 lint: {
 plugins: ["import"],
 rules: {
 "import/no-commonjs": "error",
 },
 },
});

3. Create a nested package at packages/some-package/ with its own vite.config.ts that sets ignorePatterns:

import { defineConfig } from "vite-plus";
export default defineConfig({
 lint: {
 options: {
 denyWarnings: true,
 reportUnusedDisableDirectives: "error",
 typeAware: true,
 typeCheck: true,
 },
 ignorePatterns: ["tests/fixtures/**/*"],
 },
});

4. Add a CommonJS fixture file at packages/some-package/tests/fixtures/should-ignore-this.cjs that uses module.exports.
5. Run pnpm install.
6. Run pnpm run lint.

System Info

VITE+ - The Unified Toolchain for the Web

Environment:
 Version 24.14.0
 Source lts

Tool Paths:
 node /Users/jansilhan/.vite-plus/js_runtime/node/24.14.0/bin/node
 npm /Users/jansilhan/.vite-plus/js_runtime/node/24.14.0/bin/npm
 npx /Users/jansilhan/.vite-plus/js_runtime/node/24.14.0/bin/npx

vp v0.1.12

Local vite-plus:
 vite-plus v0.1.12

Tools:
 vite v8.0.0
 rolldown v1.0.0-rc.9
 vitest v4.1.0
 oxfmt v0.40.0
 oxlint v1.55.0
 oxlint-tsgolint v0.17.0
 tsdown v0.21.3

Environment:
 Package manager pnpm v10.32.1
 Node.js Not found

Used Package Manager

pnpm

Logs

Validations

• Read the Contributing Guidelines.
• Check that there isn't already an issue for the same bug.
• Confirm this is a Vite+ issue and not an upstream issue (Vite, Vitest, tsdown, Rolldown, or Oxc).
• The provided reproduction is a minimal reproducible example.

[leaysgur]

NOTE:

• AFAIK, Oxlint and also Oxfmt do not handle nested vite.config.ts for the first place now
• And both should not refer their config in Vite+ project, should only refer vite.config.ts

[uncvrd]

For what it's worth, sharing what I posted in Discord

---

yea so nested configs werent possible with oxfmt (although i think there is a ticket to allow it)

but this is how i had it set up for oxlint in my monorepo (using .json)

├── oxc/
│ └── lint/
│ ├── base.json
│ └── react.json
├── packages/
│ └── ui/
│ └── .oxlintrc.json
└── .oxlintrc.json

Where my .oxlintrc.json

{
 "$schema": "./node_modules/oxlint/configuration_schema.json",
 "extends": ["./oxc/lint/base.json"]
}

Any my packages/ui/.oxlintrc.json

{
 "extends": ["../../oxc/lint/base.json", "../../oxc/lint/react.json"]
}

and then in .zed/settings.json

"oxlint": {
 "initialization_options": {
 "settings": {
 "configPath": null, // important! if you set a path here it disables nested configs
 "run": "onType",
 "disableNestedConfig": false,
 "fixKind": "safe_fix",
 "typeAware": true,
 "unusedDisableDirectives": "deny",
 },
 },
},

This setup lets me define react specific linting settings for packages that need it. Hope that helps a little bit!

[liangmiQwQ]

According to #1535 (comment), Vite+ does not support nested config while Oxlint and Oxfmt do. And the current behavior is temporary solution and hope to get more feedback.

Reference https://discord.com/channels/1475973262193459293/1518875219597463632

In Oxlint and Oxfmt, nested config and overrides have different semantic and designed for different use. overrides merges the config with root config, while nested config does not. So they should not be treated as a replacement to each other, they are actually complementary. Imagining you need to enable a Oxlint plugin in workspace, and disable in a certain sub-package, since we don't have nested config support, we need to disable all the rules manually, which is really messy.

In modern projects, nested config is more friendly to config preset. Providing ability to put all project specific config together (Just like pack) is also help organize configure.

In addition, both Oxlint and Oxfmt have already supported nested config very well, so supporting it in Vite+ creates a more unified mental model.

So in my opinion, I'd like to agree on supporting nested config, even if it may bring breaking change. We don't need to make too many changes either, because Oxlint and Oxfmt have basically handled everything. I believe it can improve UX a lot.

[fengmk2]

@liangmiQwQ #1769 (comment) Can this example solve the problem you mentioned?

[liangmiQwQ]

Thanks but it might be not, this issue might have some misunderstanding, and the problem seems not the same. I'll post a reproduction repo later to explain my example.

[liangmiQwQ]

I'll post a reproduction repo later to explain my example.

Here is: https://github.com/liang-demos/vp-monorepo-demo/tree/case-1 @fengmk2