test(snap): add pnpm v11 snap tests for command adaptation coverage by fengmk2 · Pull Request #1289 · voidzero-dev/vite-plus

fengmk2 · 2026-04-03T15:11:09Z

Add 26 snap test cases for pnpm@11.0.6 (latest stable v11), mirroring the existing pnpm10 test suite, to validate vp's command-adaptation layer against pnpm v11.

Coverage

New snap-tests-global/*-pnpm11 fixtures for: add, cache, config, dedupe, dlx, link, list, outdated, owner, pack, prune, publish, remove, unlink, update, view, vpx, why, dev-engines-runtime — plus workspace variants for add/list/outdated/pack/remove/update/why.

pnpm v11 compatibility findings

cache,dlx,owner,view,vpx — output identical to pnpm v10.
add,install,link — now report packageManagerDependencies (@pnpm/exe, pnpm) as part of install output; captured in snapshots.
why — output format restructured from tree-based to flat; captured in snapshots.
publish --dry-run — pnpm v11 no longer delegates to npm; minor output diff captured.
unlink(workaround applied) — pnpm v11 now runs a reconciling install after removing the override from pnpm-workspace.yaml. Under CI=true this defaults to --frozen-lockfile and fails with ERR_PNPM_LOCKFILE_CONFIG_MISMATCH. Fix: snap tests pass -- --no-frozen-lockfile to vp unlink.
configat project scope (workaround applied) — pnpm v11 moved project config from .npmrc into pnpm-workspace.yaml, which only accepts camelCase keys. Test key renamed to vitePlusPmConfigTestKey.
dev-engines-runtime — bumped pinned Node.js to 22.22.2 to satisfy vp's current minimum (^20.19.0 || >=22.12.0).
prune — skipped on win32 (platform-specific output instability, matches other tests).

Global install is not affected — vp install -g already forces npm.

RFC updates

pnpm v11 is now stable, so the support matrix in 7 RFCs (add-remove, dedupe, install, link-unlink, outdated, update, why) lists pnpm@11.x as supported (no WIP marker). The link-unlink entry retains the -- --no-frozen-lockfile note for CI usage.

Test plan

pnpm -F vite-plus snap-test-global pnpm11 — all 26 cases pass with clean exit codes
cargo test -p vite_install --lib commands::unlink — unit tests still pass
CI green on all platforms

netlify · 2026-04-03T15:11:15Z

✅ Deploy Preview for viteplus-preview canceled.

Name	Link
🔨 Latest commit	`899bf25`
🔍 Latest deploy log	https://app.netlify.com/projects/viteplus-preview/deploys/69faaee8208f500008ce6d12

fengmk2 · 2026-04-03T15:11:23Z

test(snap): add pnpm v11 snap tests for command adaptation coverage #1289 👈 (View in Graphite)
main

How to use the Graphite Merge Queue

Add the label auto-merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.}_{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

fengmk2 · 2026-04-23T05:52:17Z

https://github.com/pnpm/pnpm/releases/tag/v11.0.0-rc.5

fengmk2 · 2026-04-23T06:05:26Z

@cursor review

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit c4e9579. Configure here.}

graphite-app · 2026-05-06T02:59:39Z

Merge activity

May 6, 2:59 AM UTC: fengmk2 added this pull request to the Graphite merge queue.
May 6, 3:17 AM UTC: Merged by the Graphite merge queue.

…1289) Add 26 snap test cases for `pnpm@11.0.6` (latest stable v11), mirroring the existing pnpm10 test suite, to validate `vp`'s command-adaptation layer against pnpm v11. ## Coverage New `snap-tests-global/*-pnpm11` fixtures for: add, cache, config, dedupe, dlx, link, list, outdated, owner, pack, prune, publish, remove, unlink, update, view, vpx, why, dev-engines-runtime — plus workspace variants for add/list/outdated/pack/remove/update/why. ## pnpm v11 compatibility findings - **`cache`,** **`dlx`,** **`owner`,** **`view`,** **`vpx`** — output identical to pnpm v10. - **`add`,** **`install`,** **`link`** — now report `packageManagerDependencies` (`@pnpm/exe`, `pnpm`) as part of install output; captured in snapshots. - **`why`** — output format restructured from tree-based to flat; captured in snapshots. - **`publish --dry-run`** — pnpm v11 no longer delegates to npm; minor output diff captured. - **`unlink`** **(workaround applied)** — pnpm v11 now runs a reconciling install after removing the override from `pnpm-workspace.yaml`. Under `CI=true` this defaults to `--frozen-lockfile` and fails with `ERR_PNPM_LOCKFILE_CONFIG_MISMATCH`. Fix: snap tests pass `-- --no-frozen-lockfile` to `vp unlink`. - **`config`** **at project scope (workaround applied)** — pnpm v11 moved project config from `.npmrc` into `pnpm-workspace.yaml`, which only accepts camelCase keys. Test key renamed to `vitePlusPmConfigTestKey`. - **`dev-engines-runtime`** — bumped pinned Node.js to `22.22.2` to satisfy vp's current minimum (`^20.19.0 || >=22.12.0`). - **`prune`** — skipped on `win32` (platform-specific output instability, matches other tests). Global install is not affected — `vp install -g` already forces npm. ## RFC updates pnpm v11 is now stable, so the support matrix in 7 RFCs (`add-remove`, `dedupe`, `install`, `link-unlink`, `outdated`, `update`, `why`) lists `pnpm@11.x` as supported (no WIP marker). The `link-unlink` entry retains the `-- --no-frozen-lockfile` note for CI usage. ## Test plan - [x] `pnpm -F vite-plus snap-test-global pnpm11` — all 26 cases pass with clean exit codes - [x] `cargo test -p vite_install --lib commands::unlink` — unit tests still pass - [x] CI green on all platforms

… Node version (#2390) Since 2026-08-08 the Windows PTY snapshot leg fails intermittently on `dev_engines_runtime_pnpm11`: the `vp dlx -s print-current-version` step times out after 60s with empty output (13+ runs across branches, main included, e.g. [run 31302523708](https://github.com/voidzero-dev/vite-plus/actions/runs/31302523708)). The fixture pinned devEngines node `22.22.2`, the only pin in the suite that the CI runtime seed does not carry, so the step had to download Node.js from nodejs.org inside its 60s budget. Connections from the Windows runner to nodejs.org stall intermittently, and the shared HTTP client's 2-minute request timeout (see #2386) outlives the step budget, so a stalled attempt can neither fail nor retry in time. The sibling `dev_engines_runtime_pnpm10` pins the seeded default `22.18.0` and passed in ~2s in the same failed runs, which clears the npm registry path and isolates the stall to nodejs.org. Pin the pnpm11 fixture to `22.18.0` as well. The `22.22.2` pin carried no assertion value: #1289 picked it as the then-latest 22.x above vp's minimum, and the snapshot redacts the printed version to `<version>`. The case still verifies that vp honors `devEngines.runtime` under pnpm 11. Verified with `cargo test -p vp_cli_snapshots --test cli_snapshots -- dev_engines_runtime_pnpm11` (passes in 6s, no snapshot drift).

fengmk2 self-assigned this Apr 3, 2026

fengmk2 force-pushed the pnpm-v11-snap-tests branch from 155a35d to 733d977Compare April 23, 2026 05:49

cursorBot reviewed Apr 23, 2026
View reviewed changes

Comment threadpackages/cli/snap-tests-global/command-add-pnpm11/snap.txt Outdated

fengmk2 force-pushed the pnpm-v11-snap-tests branch from c0f9791 to c130058Compare May 6, 2026 02:31

fengmk2 marked this pull request as ready for review May 6, 2026 02:36

fengmk2 requested review from cpojer and wan9chi May 6, 2026 02:36

cpojer approved these changes May 6, 2026
View reviewed changes

fengmk2 force-pushed the pnpm-v11-snap-tests branch from 8dd7d2c to d4c90b7Compare May 6, 2026 02:53

graphite-appBotforce-pushed the pnpm-v11-snap-tests branch from d4c90b7 to 899bf25Compare May 6, 2026 03:00

graphite-appBot merged commit 899bf25 into mainMay 6, 2026
39 checks passed

graphite-appBot deleted the pnpm-v11-snap-tests branch May 6, 2026 03:17

BrewTestBot mentioned this pull request May 13, 2026
vite-plus 0.1.21 Homebrew/homebrew-core#282507
Merged

fengmk2 mentioned this pull request Aug 9, 2026
test(snapshots): pin dev_engines_runtime_pnpm11 to the seeded default Node version #2390
Merged

Navigation Menu

Uh oh!

test(snap): add pnpm v11 snap tests for command adaptation coverage - #1289

test(snap): add pnpm v11 snap tests for command adaptation coverage#1289
graphite-app[bot] merged 1 commit into
mainfrom
pnpm-v11-snap-tests

fengmk2 commented Apr 3, 2026•
edited
Loading

Uh oh!

netlifyBot commented Apr 3, 2026•
edited
Loading

Uh oh!

fengmk2 commented Apr 3, 2026

Uh oh!

fengmk2 commented Apr 23, 2026

Uh oh!

fengmk2 commented Apr 23, 2026

Uh oh!

cursorBot left a comment

Uh oh!

Uh oh!

graphite-appBot commented May 6, 2026•
edited
Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

fengmk2 commented Apr 3, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage

pnpm v11 compatibility findings

RFC updates

Test plan

Uh oh!

netlifyBot commented Apr 3, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for viteplus-preview canceled.

Uh oh!

fengmk2 commented Apr 3, 2026

How to use the Graphite Merge Queue

Uh oh!

fengmk2 commented Apr 23, 2026

Uh oh!

fengmk2 commented Apr 23, 2026

Uh oh!

cursorBot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

graphite-appBot commented May 6, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

fengmk2 commented Apr 3, 2026•
edited
Loading

netlifyBot commented Apr 3, 2026•
edited
Loading

graphite-appBot commented May 6, 2026•
edited
Loading