feat(cli): spawn npm for global installation in parallel and refine output by liangmiQwQ · Pull Request #1597 · voidzero-dev/vite-plus

liangmiQwQ · 2026-05-16T05:38:41Z

This PR introduced parallel installation to for global packages installation and updates to improve installation speed.

It used futures::stream::FuturesUnordered to manage parallel tasks, it also added --concurrency option (5 as default) for vp add, vp install, vp update with --global.

In order to suit the parallel installation, this PR modified output format for these commands, with a progress bar and more format on the final results. It’s a pretty big change, but since it’s tightly coupled with the parallel logic, I’m not sure if it belongs in a separate PR.

2026-05-16.17-33-10.mov

🤖 Generated with OpenAI Codex

netlify · 2026-05-16T05:38:45Z

✅ Deploy Preview for viteplus-preview ready!

Name	Link
🔨 Latest commit	`6487314`
🔍 Latest deploy log	https://app.netlify.com/projects/viteplus-preview/deploys/6a0bd7f2c55bee0008de3ba5
😎 Deploy Preview	https://deploy-preview-1597--viteplus-preview.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
🤖 Make changes	Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

liangmiQwQ · 2026-05-16T06:28:33Z

It seems that installation speed has significantly improved! (22 packages)

% sh test.sh
Parallel execution: 18 seconds
Current execution: 69 seconds

# pnpm bootstrap-cli > /dev/null 2>&1# vp install -g (your packages there...)
pnpm install-global-cli > /dev/null 2>&1
vp update -g > /dev/null 2>&1# Cache clean
npm cache clean --force > /dev/null 2>&1
start=$(date +%s)
vp update -g > /dev/null 2>&1
end=$(date +%s)
duration=$(( ($end-$start) ))echo"Parallel execution: $duration seconds"# Use the current vp
vp upgrade > /dev/null 2>&1
npm cache clean --force > /dev/null 2>&1
start_current=$(date +%s)
vp update -g > /dev/null 2>&1
end_current=$(date +%s)
duration_current=$(( ($end_current-$start_current) ))echo"Current execution: $duration_current seconds"

liangmiQwQ · 2026-05-17T03:00:17Z

@codex

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:c9b7f50ea9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

fengmk2 · 2026-05-17T12:46:12Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:7aa981a350

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

liangmiQwQ · 2026-05-17T13:50:04Z

Considering this PR has conflicting part with #1596, I recommend merging #1596 first, and resolve them on my side because this PR's diff is larger. Also, finishing the discussion in #1598 can make it easier and reduce future rework.

…m-for-global-installation # Conflicts: # crates/vite_global_cli/src/cli.rs

fengmk2 · 2026-05-18T14:00:44Z

@codex review

fengmk2

LGTM! @liangmiQwQ Thanks again!

liangmiQwQ · 2026-05-18T14:03:32Z

Please wait a moment before merging, I have a few commits for simplifying the code for the integration of updating logic

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:e457fdacd4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

liangmiQwQ · 2026-05-18T14:18:06Z

@codex

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:520e587d9d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

liangmiQwQ · 2026-05-18T14:21:19Z

Done! To simplify code and according to #1598, I regress some logic so that vp update -g now still uses resolved Node.js version for updating.

@liangmiQwQ

Release vite-plus v0.1.22: Security Patch, Parallel Global Install & Scaffold Polish A critical Vitest browser-mode security fix, parallel `vp add -g` installs, a built-in oxlint rule to prefer `vite-plus` imports, and a new `--git` switch for `vp create`. ### Highlights - **Security**: bundled `vitest` bumped to `4.1.6` to address [GHSA-2h32-95rg-cppp](GHSA-2h32-95rg-cppp) (Critical, CVSS 9.6), an XSS to RCE chain via the `otelCarrier` query parameter in Vitest browser mode ([#1633](#1633)) - **Parallel global install**: `vp add/install/update -g` now installs packages concurrently with a progress bar and a `--concurrency` flag (default 5) ([#1597](#1597)) - **Prefer vite-plus imports**: new bundled oxlint rule rewrites `vite`/`vitest` imports to `vite-plus`, enabled by default in generated and migrated `lint` configs ([#1408](#1408)) - **Git init on scaffold**: `vp create` learns `--git`/`--no-git` (interactive prompt; auto-commits "Initial commit from Vite+") ([#1484](#1484)) ### Features - Spawn npm for global installation in parallel with a progress bar and a `--concurrency` option ([#1597](#1597)), by @liangmiQwQ - Add bundled oxlint rule to prefer `vite-plus` imports over `vite`/`vitest` ([#1408](#1408)), by @Han5991 - `vp create`: initialize a git repository and create an initial commit on scaffold ([#1484](#1484)), by @ryohidaka - `vp create`: rename underscore-prefixed files (`_gitignore`, `_npmrc`, `_yarnrc.yml`) to dotfiles for `@org/create` bundled templates ([#1574](#1574)), by @jong-kyung - Add `VP_PR_VERSION` env var to install unreleased PR builds via pkg.pr.new ([#1578](#1578)), by @fengmk2 ### Fixes & Enhancements - Skip merging standalone `.oxfmtrc`/`.oxlintrc` config when the `fmt:`/`lint:` key is already declared in `vite.config.ts` (fixes duplicate-block regression in `vp create fate`) ([#1601](#1601)), by @fengmk2 - Suppress the `VITE+ - The Unified Toolchain for the Web` banner for `vp lint --lsp`, `vp fmt --lsp`, and `vp fmt --stdin-filepath` so stdout stays a pure LSP / formatter stream ([#1619](#1619)), by @fengmk2 - `vp create`: detect output directory when running in the current directory ([#1606](#1606)), by @jong-kyung - `vp update -g`: skip installs when the recorded global package version already matches the npm-resolved version, and tolerate string/array outputs from `npm view ... version --json` ([#1596](#1596)), by @leno23 - `vp create`: preserve single-segment project path in `updateWorkspaceConfig` ([#1582](#1582)), by @jong-kyung - `vp env use`: keep the change session-scoped on Windows ([#1577](#1577)), by @fengmk2 - `vp rebuild`: accept positional package names ([#1564](#1564)), by @fengmk2 - Adopt the new vite-task error formatter; errors now print as `error: <top-level>` plus `* <source>` chain lines, with bold-red highlight on a TTY ([vite-task#390](voidzero-dev/vite-task#390)), by @branchseer - vite-task: forward `LOCALAPPDATA` so Node's compile cache stays outside the workspace on Windows ([vite-task#389](voidzero-dev/vite-task#389)), by @branchseer - Bump vite-task to `c945cc0` ([#1628](#1628)), by @branchseer ### Refactor - Revert `vp pm plugin` command (per discussion in #1038) ([#1623](#1623)), by @jong-kyung ### Docs - Add `vitepress-plugin-llms` to the docs site so the published docs include LLM-friendly outputs (`/llms.txt`) ([#1625](#1625)), by @jong-kyung - Refresh home stats for oxlint, vite, and vitest ([#1512](#1512)), by @nozomee - Mention `vp env doctor` in agent instructions ([#1603](#1603)), by @leno23 ### Chore - Consolidate the upstream build chain into a single `pnpm build` script (justfile recipe now just calls `pnpm build`) ([#1626](#1626)), by @fengmk2 - Fix bootstrap-cli on Windows ([#1583](#1583)), by @fengmk2 - Refresh trusted stack stats ([#1573](#1573), [#1616](#1616)), by @voidzero-guard[bot] - Update GitHub Actions ([#1611](#1611), [#1612](#1612)), by @renovate[bot] - Address zizmor findings in composite actions and the release workflow; drop unused `actions-cool/issues-helper` ([#1630](#1630)), by @Boshen - Switch plain checkouts to `taiki-e/checkout-action` ([#1620](#1620)), by @Boshen - Switch release to a version-bump PR + push trigger flow ([#1575](#1575)), by @Boshen - Gate release publish on environment approval with a Discord notice ([#1571](#1571)), by @Boshen - Enable `cargo clippy` with `-D warnings` ([#1579](#1579)), by @Boshen - Drop unused `setup-node` from the version-check job ([#1600](#1600)), by @fengmk2 - Add Void deploy workflows for the docs site ([#1590](#1590)), by @fengmk2 - Add `--help` case to config snap tests for npm10/yarn1/yarn4 ([#1585](#1585)), by @jong-kyung - Add `--help` case to publish snap tests for npm10/yarn1/yarn4 ([#1584](#1584)), by @jong-kyung - Verify `.gitignore` and `.yarnrc.yml` in the new-vite-monorepo snap ([#1576](#1576)), by @jong-kyung - vite-task: bump pnpm to `11.1.2` ([vite-task#383](voidzero-dev/vite-task#383)), by @branchseer - vite-task: update lint-staged to v17 ([vite-task#385](voidzero-dev/vite-task#385)), by @renovate[bot] ### Bundled Versions | Tool | Version | Source | | --- | --- | --- | | vite | `8.0.11` | [`66f3194`](vitejs/vite@66f3194) | | rolldown | `1.0.0` | [`ac5c710`](rolldown/rolldown@ac5c710) | | tsdown | `0.22.0` | [npm](https://npmx.dev/package/tsdown/v/0.22.0) | | vitest | `4.1.6` | [npm](https://npmx.dev/package/vitest/v/4.1.6) | | oxlint | `1.63.0` | [npm](https://npmx.dev/package/oxlint/v/1.63.0) | | oxlint-tsgolint | `0.22.1` | [npm](https://npmx.dev/package/oxlint-tsgolint/v/0.22.1) | | oxfmt | `0.48.0` | [npm](https://npmx.dev/package/oxfmt/v/0.48.0) | ### New Contributors Welcome to all new contributors! 🎉 @nozomee, @ryohidaka, @leno23 **Full Changelog**: v0.1.21...v0.1.22 --- Merging this PR will trigger the release workflow. --------- Co-authored-by: voidzero-guard[bot] <278573678+voidzero-guard[bot]@users.noreply.github.com> Co-authored-by: MK <fengmk2@gmail.com>

liangmiQwQ added 2 commits May 16, 2026 13:10

feat
4edac2a

adjust
e07669b

update output
fb74f66

liangmiQwQ changed the title ~~feat(cli): parllel run npm for global installation~~feat(cli): spawn npm for global installation in parallel and refine outputMay 16, 2026

liangmiQwQ added 2 commits May 16, 2026 16:37

refine output
fd72647

clean up
a486d26

liangmiQwQ marked this pull request as ready for review May 16, 2026 09:06

liangmiQwQ added 2 commits May 16, 2026 17:06

Merge branch 'main' into feat/parllel-run-npm-for-global-installation
798ce3a

fix ci
c9b7f50

chatgpt-codex-connectorBot reviewed May 17, 2026
View reviewed changes

Comment threadcrates/vite_global_cli/src/commands/env/global_install.rs
Comment threadcrates/vite_global_cli/src/commands/env/global_install.rs Outdated

liangmiQwQ added 8 commits May 17, 2026 11:24

clean up
c6ee202

fix up
1dfee76

refactor
1aeecd3

refactor
022e106

perf
a99a075

adjust
ba4d342

refactor
e87563a

snapshots
7aa981a

chatgpt-codex-connectorBot reviewed May 17, 2026
View reviewed changes

Comment threadcrates/vite_global_cli/src/commands/env/global_install.rs Outdated
Comment threadcrates/vite_global_cli/src/commands/env/global_install.rs
Comment threadcrates/vite_global_cli/src/commands/env/global_install.rs Outdated

liangmiQwQ added 2 commits May 17, 2026 21:39

adjust
0e5cf4c

Merge branch 'main' into feat/parllel-run-npm-for-global-installation
8b09602

fengmk2 self-assigned this May 18, 2026

Merge remote-tracking branch 'upstream/main' into feat/parllel-run-np…
e457fda
…m-for-global-installation # Conflicts: # crates/vite_global_cli/src/cli.rs

fengmk2 approved these changes May 18, 2026
View reviewed changes

liangmiQwQ marked this pull request as draft May 18, 2026 14:05

chatgpt-codex-connectorBot reviewed May 18, 2026
View reviewed changes

Comment threadcrates/vite_global_cli/src/commands/env/global_install.rs
Comment threadcrates/vite_global_cli/src/commands/env/global_install.rs

liangmiQwQ added 2 commits May 18, 2026 22:10

refactor
a7eb41c

fix up
520e587

liangmiQwQ marked this pull request as ready for review May 18, 2026 14:17

chatgpt-codex-connectorBot reviewed May 18, 2026
View reviewed changes

Comment threadcrates/vite_global_cli/src/cli.rs

liangmiQwQand others added 2 commits May 18, 2026 22:25

Merge branch 'main' into feat/parllel-run-npm-for-global-installation
f8c580b

Merge branch 'main' into feat/parllel-run-npm-for-global-installation
6487314

fengmk2 merged commit f0ae621 into voidzero-dev:mainMay 19, 2026
39 checks passed

liangmiQwQ deleted the feat/parllel-run-npm-for-global-installation branch May 19, 2026 12:55

fengmk2 mentioned this pull request May 19, 2026
release: v0.1.22: Security Patch, Parallel Global Install & Scaffold Polish #1637
Merged

BrewTestBot mentioned this pull request May 20, 2026
vite-plus 0.1.22 Homebrew/homebrew-core#283685
Merged

Uh oh!

Conversation

liangmiQwQ commented May 16, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

netlifyBot commented May 16, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for viteplus-preview ready!

Uh oh!

liangmiQwQ commented May 16, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

liangmiQwQ commented May 17, 2026

Uh oh!

chatgpt-codex-connectorBot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

fengmk2 commented May 17, 2026

Uh oh!

chatgpt-codex-connectorBot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

liangmiQwQ commented May 17, 2026

Uh oh!

fengmk2 commented May 18, 2026

Uh oh!

fengmk2 left a comment

Choose a reason for hiding this comment

Uh oh!

liangmiQwQ commented May 18, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chatgpt-codex-connectorBot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

liangmiQwQ commented May 18, 2026

Uh oh!

chatgpt-codex-connectorBot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

liangmiQwQ commented May 18, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

liangmiQwQ commented May 16, 2026•
edited
Loading

netlifyBot commented May 16, 2026•
edited
Loading

liangmiQwQ commented May 16, 2026•
edited
Loading

liangmiQwQ commented May 18, 2026•
edited
Loading