Uh oh!
There was an error while loading. Please reload this page.
feat(lint): add pnpm vite alias oxlint rule - #1736
Draft
fengmk2 wants to merge 1 commit into
Draft
Conversation
✅ Deploy Preview for viteplus-preview canceled.
|
fengmk2force-pushed
the
codex/pnpm-vite-alias-oxlint-rule
branch
from
June 1, 2026 09:18
bc77362 to
81c7565Comparefengmk2
commented
Jun 1, 2026
Uh oh!
There was an error while loading. Please reload this page.
fengmk2force-pushed
the
codex/pnpm-vite-alias-oxlint-rule
branch
from
June 1, 2026 09:26
81c7565 to
76d3a9dCompareContributor
✅ Staging deployment successful! Preview: https://viteplus-staging.void.app/ |
fengmk2force-pushed
the
codex/pnpm-vite-alias-oxlint-rule
branch
3 times, most recently
from
June 1, 2026 10:06
c352ce0 to
0d2d55dComparefengmk2
commented
Jun 1, 2026
Uh oh!
There was an error while loading. Please reload this page.
fengmk2force-pushed
the
codex/pnpm-vite-alias-oxlint-rule
branch
from
June 1, 2026 10:10
0d2d55d to
cdab1ecComparefengmk2force-pushed
the
codex/pnpm-vite-alias-oxlint-rule
branch
from
June 1, 2026 10:13
cdab1ec to
526bf1bComparefengmk2
commented
Jun 3, 2026
| return false; | ||
| } | ||
| const packageJsonPath = path.join(path.dirname(filename), 'package.json'); |
MemberAuthor
Contributor
There was a problem hiding this comment.
Does oxlint plan to support json files?
yes - it should work via a plugin once oxc-project/oxc#21936 has shipped
Contributor
There was a problem hiding this comment.
in the interim, maybe only check the json files when linting vite.config.ts?
MemberAuthor
There was a problem hiding this comment.
Yes, this is how it is currently implemented, but the error message points to the vite.config.ts file, which is not user-friendly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
vite-plus/require-pnpm-vite-aliasto the Vite+ Oxlint plugin.Why
PR #1728 fixed a pnpm monorepo issue where removing the direct aliased
vitedependency from an application package made the workspace override appear ineffective. This lint rule catches that class of configuration drift in Vite+ application packages.Validation
pnpm exec tsc --noEmit --pretty falsevp fmt --check packages/cli/src/oxlint-plugin.ts packages/cli/src/oxlint-plugin-config.ts packages/cli/src/__tests__/oxlint-plugin.spec.tsvp lint packages/cli/src/oxlint-plugin.ts packages/cli/src/oxlint-plugin-config.ts packages/cli/src/__tests__/oxlint-plugin.spec.tsvp test packages/cli/src/__tests__/oxlint-plugin.spec.tsgit diff --checkNote:
pnpm -F vite-plus snap-test-global new-vite-monorepowas skipped on Windows by the snap-test runner.