fix(core): resolve Rolldown bindings via platform packages by jong-kyung · Pull Request #2067 · voidzero-dev/vite-plus

jong-kyung · 2026-07-06T11:12:08Z

Summary

Fixes#2054.

This updates @voidzero-dev/vite-plus-core release builds so bundled Rolldown no longer resolves native bindings through vite-plus/binding.

Instead, supported Rolldown native package specifiers are rewritten from:

@rolldown/binding-<platform>

to the matching Vite+ native platform package:

@voidzero-dev/vite-plus-<platform>

vite-plus/binding remains available as a compatibility export.

Why

With pnpm enable-global-virtual-store, core can run from pnpm's global store realpath. In that layout, core cannot
reliably resolve undeclared vite-plus/binding.

This avoids the circular package graph:

vite-plus -> @voidzero-dev/vite-plus-core -> vite-plus/binding

and makes core's native binding resolution use declared optional dependencies instead.

Changes

Document the new native binding resolution model in:
- packages/cli/BUNDLING.md
- packages/core/BUNDLING.md
Map CLI napi.targets to Vite+ native platform package names
Add the generated Vite+ native platform packages to core optionalDependencies
Rewrite only supported Rolldown native binding specifiers to declared Vite+ platform packages
- unsupported/fallback Rolldown bindings such as WASI are left unchanged
Add tests for:
- NAPI target -> platform package mapping
- core optional dependency metadata
Pin core native optional dependency versions during release after native addons are published

netlify · 2026-07-06T11:12:13Z

✅ Deploy Preview for viteplus-preview canceled.

Name	Link
🔨 Latest commit	`f5f08a0`
🔍 Latest deploy log	https://app.netlify.com/projects/viteplus-preview/deploys/6a59e291cc164400088f61d1

jong-kyung · 2026-07-06T11:12:18Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:33d915dd59

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-07-06T11:22:33Z

 }
 },
 "optionalDependencies": {
+ "@voidzero-dev/vite-plus-darwin-arm64": "0.2.2",


Keep native optional deps in the version bump
When the release prep workflow bumps versions, it only rewrites the top-level version field in packages/core/package.json (.github/workflows/prepare_release.yml:55-56), leaving these newly added native optional dependency pins at the previous release. The new artifact test also requires each Vite+ native optional dependency to equal corePkgJson.version (packages/core/__tests__/build-artifacts.spec.ts:57), so the next release: v... PR will fail as soon as core is bumped unless the bump path updates these pins too.
Useful? React with 👍 / 👎.

I'm not sure what the preferred fix is for this release-flow issue. I avoided updating these pins in prepare_release.yml because the new native packages are not published yet at that point, so resolving exact versions during release prep seemed unsafe.
@fengmk2 Could you advise which approach you'd prefer?

It shouldn't be added here. The napi binary dependency is automatically added by napi-rs/cli during the publishing process in packages/cli/publish-native-addons.ts, so it doesn't need to be depended on at the code level. However, currently it doesn't support automatically adding this dependency configuration to 2 packages. Need @Brooooooklyn to help review whether our approach is correct. I have a feeling something is wrong.

jong-kyung · 2026-07-06T11:41:38Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:9a4307d07a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

jong-kyung · 2026-07-06T12:05:33Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:ed475572ba

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

jong-kyung · 2026-07-06T12:23:49Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:cf5b76793b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

jong-kyung · 2026-07-06T12:43:32Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:986885258c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-07-06T12:53:14Z

 };

- const { code, errors } = await format(destPkgPath, JSON.stringify(destPkg, null, 2) + '\n', {
+ destPkg.optionalDependencies = { ...destPkg.optionalDependencies };


Update native deps during version bumps
When the next release PR is created, .github/workflows/prepare_release.yml only bumps the top-level version fields, leaving these newly hard-coded native optional dependency specs at the previous release. The CI build then runs mergePackageJson(), which rewrites them to destPkg.version, so the post-build dirty-tree check in .github/workflows/ci.yml fails; after merge, main would also keep @voidzero-dev/vite-plus-core out of sync with the native packages until the ephemeral publish step patches it. Please update the release-prep path (or stop source builds from rewriting these specs) so the committed package.json stays consistent across version bumps.
Useful? React with 👍 / 👎.

jong-kyung · 2026-07-07T05:18:40Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:fcfaca56bc

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

fengmk2 · 2026-07-07T05:32:47Z

This change is a bit complex, so I won't merge it in this week's release. I'll review it after today's release is done.

jong-kyung · 2026-07-07T05:37:46Z

This change is a bit complex, so I won't merge it in this week's release. I'll review it after today's release is done.

I agree. I’ll review and address your feedback when you take a look later.

socket-security · 2026-07-08T08:26:04Z

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	npm/@voidzero-dev/vite-plus-darwin-arm64@0.2.2
	npm/@voidzero-dev/vite-plus-linux-arm64-gnu@0.2.2
	npm/@voidzero-dev/vite-plus-linux-x64-gnu@0.2.2
	npm/@voidzero-dev/vite-plus-win32-x64-msvc@0.2.2
	npm/@voidzero-dev/vite-plus-darwin-x64@0.2.2
	npm/@voidzero-dev/vite-plus-linux-arm64-musl@0.2.2
	npm/@voidzero-dev/vite-plus-linux-x64-musl@0.2.2
	npm/@voidzero-dev/vite-plus-win32-arm64-msvc@0.2.2

View full report

Signed-off-by: JongKyung Lee <jongkyung0413@gmail.com>

fengmk2 · 2026-08-03T16:09:55Z

@jong-kyung Let me take over this issue, I need to write a RFC first.

Release-built core resolves bundled Rolldown's native binding through vite-plus/binding, an export of a package core never declares, which breaks pnpm enable-global-virtual-store, Yarn PnP, and standalone core installs. The RFC keeps the per-platform rewrite direction from PR #2067 but moves the platform optionalDependencies pins out of the committed package.json and into the publish pipeline, mirroring how napi-rs injects the same packages into vite-plus.

jong-kyung added 5 commits July 6, 2026 19:59

docs: document platform binding resolution
07f1387

test(core): map native platform packages
94aad06

fix(core): declare native platform packages
d7d86b2

fix(core): rewrite rolldown native packages
7081cb3

ci: refresh native package release versions
33d915d

jong-kyung self-assigned this Jul 6, 2026

refactor(core): simplify native dependency generation
614f67b

chatgpt-codex-connectorBot reviewed Jul 6, 2026
View reviewed changes

jong-kyung added 2 commits July 6, 2026 20:28

style: format binding resolution changes
0cdd0fe

test(tools): pack host native package locally
9a4307d

chatgpt-codex-connectorBot reviewed Jul 6, 2026
View reviewed changes

Comment threadpackages/core/build.ts Outdated
Comment threadpackages/core/build.ts

fix(core): preserve bundled rolldown version
ed47557

chatgpt-codex-connectorBot reviewed Jul 6, 2026
View reviewed changes

Comment threadpackages/core/build.ts
Comment threadpackages/core/package.json

chatgpt-codex-connectorBot reviewed Jul 6, 2026
View reviewed changes

Comment threadpackages/core/build.ts
Comment threadpackages/core/package.json

fix(core): match single-quoted binding guards
9868852

jong-kyung force-pushed the fix/core-platform-binding-resolution branch from feff11d to 9868852Compare July 6, 2026 12:40

chatgpt-codex-connectorBot reviewed Jul 6, 2026
View reviewed changes

jong-kyungand others added 3 commits July 7, 2026 09:27

Merge branch 'main' into fix/core-platform-binding-resolution
adb2ca8

style: format binding resolution changes
7da14ed

Merge branch 'main' into fix/core-platform-binding-resolution
8db6239

jong-kyung marked this pull request as ready for review July 7, 2026 02:36

jong-kyung marked this pull request as draft July 7, 2026 02:36

Merge branch 'main' into fix/core-platform-binding-resolution
ed2773b

jong-kyung marked this pull request as ready for review July 7, 2026 04:57

fix(core): rewrite double-quoted binding guards
fadda42

Merge branch 'main' into fix/core-platform-binding-resolution
fcfaca5

chatgpt-codex-connectorBot reviewed Jul 7, 2026
View reviewed changes

Comment threadpackages/core/build.ts

jong-kyungand others added 4 commits July 7, 2026 14:52

Merge branch 'main' into fix/core-platform-binding-resolution
b04bd10

Merge branch 'main' into fix/core-platform-binding-resolution
735312b

Merge branch 'main' into fix/core-platform-binding-resolution
e551cf8

Merge branch 'main' into fix/core-platform-binding-resolution
1879811

jong-kyungand others added 12 commits July 8, 2026 17:43

Merge branch 'main' into fix/core-platform-binding-resolution
0f26155

Merge branch 'main' into fix/core-platform-binding-resolution
637386d

Merge branch 'main' into fix/core-platform-binding-resolution
3d0b156

Merge branch 'main' into fix/core-platform-binding-resolution
5004c2e

Merge branch 'main' into fix/core-platform-binding-resolution
a9f30f7

Merge branch 'main' into fix/core-platform-binding-resolution
8829649

Merge branch 'main' into fix/core-platform-binding-resolution
3751a9d

Merge branch 'main' into fix/core-platform-binding-resolution
fdbed44

Merge branch 'main' into fix/core-platform-binding-resolution
e0b9779
Signed-off-by: JongKyung Lee <jongkyung0413@gmail.com>

Merge branch 'main' into fix/core-platform-binding-resolution
0e5dcd3

Merge branch 'main' into fix/core-platform-binding-resolution
596fb5f

Merge branch 'main' into fix/core-platform-binding-resolution
f5f08a0

fengmk2 closed this Aug 3, 2026

jong-kyung deleted the fix/core-platform-binding-resolution branch August 3, 2026 22:24

fengmk2 mentioned this pull request Aug 4, 2026
fix(core): resolve bundled Rolldown bindings via platform packages #2313
Merged

Uh oh!

Conversation

jong-kyung commented Jul 6, 2026

Summary

Why

Changes

Uh oh!

netlifyBot commented Jul 6, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for viteplus-preview canceled.

Uh oh!

jong-kyung commented Jul 6, 2026

Uh oh!

chatgpt-codex-connectorBot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connectorBotJul 6, 2026

Choose a reason for hiding this comment

Uh oh!

jong-kyungJul 6, 2026

Choose a reason for hiding this comment

Uh oh!

fengmk2Jul 8, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jong-kyung commented Jul 6, 2026

Uh oh!

chatgpt-codex-connectorBot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

jong-kyung commented Jul 6, 2026

Uh oh!

chatgpt-codex-connectorBot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

jong-kyung commented Jul 6, 2026

Uh oh!

chatgpt-codex-connectorBot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

jong-kyung commented Jul 6, 2026

Uh oh!

chatgpt-codex-connectorBot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connectorBotJul 6, 2026

Choose a reason for hiding this comment

Uh oh!

jong-kyung commented Jul 7, 2026

Uh oh!

chatgpt-codex-connectorBot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

fengmk2 commented Jul 7, 2026

Uh oh!

jong-kyung commented Jul 7, 2026

Uh oh!

socket-securityBot commented Jul 8, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fengmk2 commented Aug 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

netlifyBot commented Jul 6, 2026•
edited
Loading

socket-securityBot commented Jul 8, 2026•
edited
Loading