Skip to content

chore(cli): restore to run snap-test parallel - #251

Merged
fengmk2 merged 1 commit into
mainfrom
10-24-chore_cli_restore_to_run_snap-test_parallel
Oct 25, 2025
Merged

chore(cli): restore to run snap-test parallel#251
fengmk2 merged 1 commit into
mainfrom
10-24-chore_cli_restore_to_run_snap-test_parallel

Conversation

@fengmk2

@fengmk2fengmk2 commented Oct 24, 2025

Copy link
Copy Markdown
Member

I re-ran it 10 times locally and it hasn't failed again

@fengmk2Graphite App

fengmk2 commented Oct 24, 2025

Copy link
Copy Markdown
MemberAuthor

This stack of pull requests is managed by Graphite. Learn more about stacking.

@fengmk2fengmk2 self-assigned this Oct 24, 2025
@fengmk2
fengmk2 marked this pull request as ready for review October 24, 2025 01:26
CopilotAI review requested due to automatic review settings October 24, 2025 01:26

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR restores parallel execution of snap tests by uncommenting the code that was previously disabled due to a "Broken pipe" error. The author has verified through local testing that the issue no longer occurs.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment threadpackages/tools/src/snap-test.ts Outdated
@graphite-app

graphite-appBot commented Oct 24, 2025

Copy link
Copy Markdown

Merge activity

  • Oct 24, 9:30 AM UTC: This pull request can not be added to the Graphite merge queue. Please try rebasing and resubmitting to merge when ready.
  • Oct 24, 9:30 AM UTC: Graphite disabled "merge when ready" on this PR due to: a merge conflict with the target branch; resolve the conflict and try again..
  • Oct 25, 9:47 AM UTC: @fengmk2 merged this pull request with Graphite.

@fengmk2
fengmk2force-pushed the 10-24-chore_cli_restore_to_run_snap-test_parallel branch from b3e6551 to e8eda57CompareOctober 25, 2025 09:37
@fengmk2Graphite App

Copy link
Copy Markdown
MemberAuthor

panicked gone now! @branchseer great job!

@wan9chiGraphite App

Copy link
Copy Markdown
Member

panicked gone now! @branchseer great job!

wtf? What did I do? ???

@fengmk2
fengmk2 merged commit 0ed9bbd into mainOct 25, 2025
19 checks passed
@fengmk2
fengmk2 deleted the 10-24-chore_cli_restore_to_run_snap-test_parallel branch October 25, 2025 09:47
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@fengmk2@wan9chi