Skip to content

refactor: move run_command to vite_command crate - #309

Merged
fengmk2 merged 1 commit into
mainfrom
11-15-refactor_use_vite_command_to_run_command
Nov 21, 2025
Merged

refactor: move run_command to vite_command crate#309
fengmk2 merged 1 commit into
mainfrom
11-15-refactor_use_vite_command_to_run_command

Conversation

@fengmk2

@fengmk2fengmk2 commented Nov 15, 2025

Copy link
Copy Markdown
Member

TL;DR

Moved run_command function from vite_install to a dedicated vite_command crate.

What changed?

  • Removed the run_command function from vite_install/src/package_manager.rs
  • Added a dependency on the vite_command crate in vite_install
  • Updated all command modules to import run_command from vite_command instead
  • Removed the nix dependency as it's no longer needed in vite_install
  • Removed the associated tests for run_command from vite_install

How to test?

  • Run the test suite to ensure all package manager commands still work correctly
  • Verify that commands like add, remove, update, etc. still function properly
  • Check that the command execution behavior remains consistent across platforms

Why make this change?

This refactoring improves code organization by moving the command execution functionality to a dedicated crate. This makes the code more modular and allows the command execution logic to be reused across different parts of the project without duplicating code. The run_command function is a general utility that deserves its own crate rather than being embedded in the package manager implementation.

@fengmk2Graphite App

fengmk2 commented Nov 15, 2025

Copy link
Copy Markdown
MemberAuthor

@fengmk2fengmk2 changed the title refactor: use vite_command to run commandrefactor: move run_command to vite_command crateNov 15, 2025
@fengmk2
fengmk2force-pushed the 11-15-refactor_use_vite_command_to_run_command branch 2 times, most recently from accc41e to d0cbf3fCompareNovember 15, 2025 08:43
@fengmk2fengmk2 self-assigned this Nov 15, 2025
@fengmk2
fengmk2 marked this pull request as ready for review November 15, 2025 08:44
@fengmk2
fengmk2force-pushed the 11-15-refactor_use_vite_command_to_run_command branch from d0cbf3f to d13454fCompareNovember 15, 2025 09:51
@fengmk2
fengmk2force-pushed the 11-11-feat_run_command_with_fspy branch from 06cf754 to 21916a3CompareNovember 15, 2025 09:51
@fengmk2
fengmk2force-pushed the 11-15-refactor_use_vite_command_to_run_command branch from d13454f to 04a551bCompareNovember 15, 2025 09:57
@fengmk2
fengmk2force-pushed the 11-11-feat_run_command_with_fspy branch from 21916a3 to 1db7b58CompareNovember 15, 2025 09:57
@fengmk2
fengmk2force-pushed the 11-11-feat_run_command_with_fspy branch from 1db7b58 to f3cb301CompareNovember 19, 2025 06:27
@fengmk2
fengmk2force-pushed the 11-15-refactor_use_vite_command_to_run_command branch 2 times, most recently from 08cdddb to 74f5fb9CompareNovember 19, 2025 06:53
@fengmk2
fengmk2force-pushed the 11-11-feat_run_command_with_fspy branch from f3cb301 to c315cb6CompareNovember 19, 2025 06:53
@fengmk2
fengmk2 changed the base branch from 11-11-feat_run_command_with_fspy to graphite-base/309November 19, 2025 07:04
@fengmk2
fengmk2force-pushed the 11-15-refactor_use_vite_command_to_run_command branch from 74f5fb9 to fee0c4dCompareNovember 19, 2025 07:09
@fengmk2
fengmk2 changed the base branch from graphite-base/309 to 11-11-feat_run_command_with_fspyNovember 19, 2025 07:10
@fengmk2
fengmk2 changed the base branch from 11-11-feat_run_command_with_fspy to graphite-base/309November 19, 2025 08:21
@fengmk2
fengmk2force-pushed the 11-15-refactor_use_vite_command_to_run_command branch from fee0c4d to a79f950CompareNovember 19, 2025 08:24
@fengmk2
fengmk2 changed the base branch from graphite-base/309 to 11-11-feat_run_command_with_fspyNovember 19, 2025 08:25
@fengmk2
fengmk2force-pushed the 11-11-feat_run_command_with_fspy branch from bc1410d to d258eb1CompareNovember 19, 2025 09:00
@fengmk2
fengmk2force-pushed the 11-15-refactor_use_vite_command_to_run_command branch 2 times, most recently from 6f86bf0 to 3cf23baCompareNovember 19, 2025 09:49
@fengmk2
fengmk2 changed the base branch from 11-11-feat_run_command_with_fspy to graphite-base/309November 19, 2025 10:03
@graphite-app

graphite-appBot commented Nov 20, 2025

Copy link
Copy Markdown

Merge activity

  • Nov 20, 7:10 AM UTC: This pull request can not be added to the Graphite merge queue. Please try rebasing and resubmitting to merge when ready.
  • Nov 20, 7:10 AM UTC: Graphite disabled "merge when ready" on this PR due to: a merge conflict with the target branch; resolve the conflict and try again..
  • Nov 21, 3:28 AM UTC: @fengmk2 merged this pull request with Graphite.

@fengmk2
fengmk2force-pushed the 11-15-refactor_use_vite_command_to_run_command branch from 3cf23ba to 5bf1ebfCompareNovember 20, 2025 07:12
@fengmk2
fengmk2 changed the base branch from graphite-base/309 to mainNovember 20, 2025 07:12
@fengmk2
fengmk2 merged commit 1d8097b into mainNov 21, 2025
15 of 21 checks passed
@fengmk2
fengmk2 deleted the 11-15-refactor_use_vite_command_to_run_command branch November 21, 2025 03:28
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@fengmk2@Brooooooklyn