Uh oh!
There was an error while loading. Please reload this page.
refactor: consolidate get_cache_dir logic via vite_shared crate - #509
Merged
Conversation
MemberAuthor
This stack of pull requests is managed by Graphite. Learn more about stacking. |
fengmk2force-pushed
the
vite_shared
branch
4 times, most recently
from
January 27, 2026 02:39
f3d3769 to
70c38feComparefengmk2force-pushed
the
nodejs-version-manager
branch
2 times, most recently
from
January 27, 2026 02:40
d71ed84 to
58a0450Comparefengmk2force-pushed
the
vite_shared
branch
3 times, most recently
from
January 27, 2026 03:20
16de800 to
f3bb37eComparefengmk2force-pushed
the
nodejs-version-manager
branch
from
January 27, 2026 03:20
6e4df5c to
b064bbfComparefengmk2force-pushed
the
vite_shared
branch
4 times, most recently
from
January 27, 2026 09:02
a0436c9 to
d914c1aComparefengmk2
marked this pull request as ready for review
January 27, 2026 09:16
fengmk2force-pushed
the
nodejs-version-manager
branch
from
January 27, 2026 09:23
d4885e8 to
8922738CompareBrooooooklyn
commented
Jan 27, 2026
Member
cursor review |
fengmk2force-pushed
the
nodejs-version-manager
branch
from
January 28, 2026 02:11
8922738 to
a6745a0Compare3 tasks
Brooooooklyn
approved these changes
Jan 29, 2026
fengmk2
changed the base branch from
nodejs-version-manager
to
graphite-base/509January 29, 2026 08:23
- Add `get_cache_dir()` to vite_shared for centralized cache path management
- Create `cache.rs` module in vite_js_runtime with `get_cache_dir()` helper
- Replace repeated `vite_shared::get_cache_dir()?.join("js_runtime")` patternAdd platform-specific path documentation for Linux, macOS, and Windows.
Deploying vite-plus with |
| Latest commit: | c6a1f1e |
| Status: | ⚡️ Build in progress... |
Uh oh!
There was an error while loading. Please reload this page.
fengmk2
commented
Jan 29, 2026
MemberAuthor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create a new vite_shared crate to hold common utilities shared across
vite-plus crates. Move duplicate get_cache_dir() implementations from
vite_install and vite_js_runtime into this shared location.
Note
Consolidates duplicated cache directory logic into a new shared crate.
vite_sharedwithget_cache_dir()(crates/vite_shared), including testsvite_installandvite_js_runtimeto usevite_shared::get_cache_dir(); remove local implementations and related testsvite_js_runtime::cachemodule and route runtime caching throughcrate::cache::get_cache_dir()(now$CACHE_DIR/vite/js_runtime)vite_sharedto workspace and affected crates; drop directdirectoriesdeps where no longer neededWritten by Cursor Bugbot for commit 6cf4de2. This will update automatically on new commits. Configure here.