Uh oh!
There was an error while loading. Please reload this page.
feat(cli): fall back to package manager for vp run without vite-plus dependency - #549
Merged
Conversation
MemberAuthor
fengmk2force-pushed
the
vp-run-without-vite-plus-deps
branch
from
February 6, 2026 11:15
bb1129f to
db31aafComparefengmk2force-pushed
the
vp-run-without-vite-plus-deps
branch
2 times, most recently
from
February 6, 2026 11:37
e7684f8 to
35d02fbComparefengmk2force-pushed
the
vp-run-without-vite-plus-deps
branch
from
February 6, 2026 11:49
35d02fb to
fd8ca6fComparefengmk2force-pushed
the
vp-run-without-vite-plus-deps
branch
from
February 6, 2026 12:12
fd8ca6f to
af16771Comparefengmk2force-pushed
the
vp-run-without-vite-plus-deps
branch
3 times, most recently
from
February 7, 2026 06:25
ed80484 to
b356849CompareBrooooooklyn
approved these changes
Feb 7, 2026
fengmk2force-pushed
the
vp-run-without-vite-plus-deps
branch
from
February 7, 2026 07:42
b356849 to
8d32710Comparefengmk2
marked this pull request as ready for review
February 7, 2026 07:46
fengmk2force-pushed
the
vp-run-without-vite-plus-deps
branch
from
February 7, 2026 08:24
8d32710 to
3eade84Comparefengmk2force-pushed
the
vp-run-without-vite-plus-deps
branch
from
February 7, 2026 09:27
3eade84 to
57b8c2aComparefengmk2force-pushed
the
self-upgrade
branch
2 times, most recently
from
February 7, 2026 09:29
2bfd7d9 to
324d4edComparefengmk2force-pushed
the
vp-run-without-vite-plus-deps
branch
2 times, most recently
from
February 7, 2026 09:31
fe7925e to
3a04378Comparefengmk2force-pushed
the
vp-run-without-vite-plus-deps
branch
2 times, most recently
from
February 7, 2026 10:21
4bc40f8 to
8e1e691Comparefengmk2force-pushed
the
vp-run-without-vite-plus-deps
branch
from
February 7, 2026 10:24
8e1e691 to
3656c22Comparefengmk2force-pushed
the
vp-run-without-vite-plus-deps
branch
from
February 7, 2026 10:43
3656c22 to
133cdebComparefengmk2force-pushed
the
graphite-base/549
branch
from
February 7, 2026 10:43
4b5143d to
d44848fCompare…s dependency When `vp run <script>` is executed in a project without `vite-plus` in dependencies or devDependencies, fall back to `<pm> run <script>` directly from the Rust layer instead of entering the JS delegation flow. This avoids unnecessary overhead of downloading Node.js runtime and prompting users to install vite-plus. - Add `has_vite_plus_dependency()` utility that walks up from cwd to find the nearest package.json and checks for vite-plus - Add `run_script_command()` / `resolve_run_script_command()` on PackageManager for executing `<pm> run <args>` - Add `run_or_delegate` module that checks dependency before routing - Add unit tests for dependency detection and command resolution - Add snap test verifying fallback behavior with pnpm
fengmk2force-pushed
the
vp-run-without-vite-plus-deps
branch
from
February 7, 2026 10:44
133cdeb to
367f25eCompareUh oh!
There was an error while loading. Please reload this page.
fengmk2
commented
Feb 7, 2026
MemberAuthor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
vp run <script>is executed in a project withoutvite-plusindependencies or devDependencies, fall back to
<pm> run <script>directlyfrom the Rust layer instead of entering the JS delegation flow. This avoids
unnecessary overhead of downloading Node.js runtime and prompting users to
install vite-plus.
has_vite_plus_dependency()utility that walks up from cwd to findthe nearest package.json and checks for vite-plus
run_script_command()/resolve_run_script_command()onPackageManager for executing
<pm> run <args>run_or_delegatemodule that checks dependency before routing