refactor: move typeAware/typeCheck from CLI flags to vite.config.ts by fengmk2 · Pull Request #739 · voidzero-dev/vite-plus

fengmk2 · 2026-03-09T08:31:58Z

oxlint natively reads options.typeAware and options.typeCheck from
its config file, so there's no need for vp check to inject these as
CLI flags when calling vp lint.

Remove --no-type-aware / --no-type-check flags from vp check
Add options: { typeAware: true, typeCheck: true } defaults in
vp lint --init, vp migrate, and project root vite.config.ts
Strip --type-aware / --type-check from migrated scripts
Remove oxc.typeAware from VS Code settings (extension reads from
config automatically)
Add OxlintOptions type with typeAware and typeCheck fields

netlify · 2026-03-09T08:32:03Z

✅ Deploy Preview for viteplus-staging canceled.

Name	Link
🔨 Latest commit	`69220fb`
🔍 Latest deploy log	https://app.netlify.com/projects/viteplus-staging/deploys/69aef54fce7ba500082dfe2e

fengmk2 · 2026-03-09T08:32:12Z

This stack of pull requests is managed by Graphite. Learn more about stacking.

Remove the 874-line hand-written oxlint-config.ts and import OxlintConfig directly from the oxlint package, which already exports the same type. Clean up related lint overrides and typos exclusions for the deleted file.

oxlint's TypeScript checker (tsgolint) does not support baseUrl in tsconfig.json, causing lint failures after migration. Guard both migration and lint --init paths to omit typeAware/typeCheck defaults when baseUrl is present.

When tsconfig.json has baseUrl and we skip injecting typeAware/typeCheck, log a warning with actionable advice to run `npx @andrewbranch/ts5to6 --fixBaseUrl .` to remove baseUrl. Added warning in both migration and lint --init paths. Updated snap test fixture with .oxlintrc.json to capture the warning output.

…hed package The static import of init-config.js in bin.ts transitively loads detect-indent (a devDependency), causing ERR_MODULE_NOT_FOUND when vite-plus is installed as a dependency. Change to dynamic import so it's only loaded for local commands that actually need it. Fixes frm-stack E2E test failure.

The previous lazy-import fix was insufficient — init-config.js is still loaded for all non-global commands. The actual root cause is that these packages were in devDependencies but are imported at runtime by tsc-compiled dist/utils/json.js. Move them to dependencies so they're available when vite-plus is installed in other projects.

…t-indent dependency chain Move hasBaseUrlInTsconfig from utils/json.ts (which imports detect-indent) to a new utils/tsconfig.ts that uses only Node.js builtins. This breaks the transitive dependency chain from init-config.ts → json.ts → detect-indent, allowing detect-indent/detect-newline to remain devDependencies since they are only used by rolldown-bundled global CLI code.

…nto vite.config.ts The $schema annotation in .oxlintrc.json/.oxfmtrc.json causes TS2769 type errors when merged into vite.config.ts because it's not part of OxlintConfig/OxfmtConfig types. Strip it before merging.

fengmk2 · 2026-03-09T17:04:16Z

Merge activity

Mar 9, 5:04 PM UTC: A user started a stack merge that includes this pull request via Graphite.
Mar 9, 5:04 PM UTC: @fengmk2 merged this pull request with Graphite.

The `--no-type-check` flag was removed from `vp check` in voidzero-dev#739, but the help examples section still referenced it. Replace with `--no-lint` which is a valid flag. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

…#875) ## Summary - The `--no-type-check` flag was removed from `vp check` in #739, but the help examples section still referenced it - Replace with `--no-lint` which is a valid flag Fixes#879 One-line change in `crates/vite_global_cli/src/help.rs`. ## Context The Options section was correctly cleaned up in #739, but the Examples block ~18 lines below it was missed: ```diff - vp check --no-type-check src/index.ts + vp check --no-lint src/index.ts ``` --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Co-authored-by: MK <fengmk2@gmail.com>

If tsconfig has comments, JSON.parse fails and we can't detect nor remove baseUrl! This PR resolves this. Related: #739

fengmk2 self-assigned this Mar 9, 2026

fengmk2 changed the base branch from main to graphite-base/739March 9, 2026 08:48

fengmk2 force-pushed the improve-vp-check branch from 81de613 to aec26b4Compare March 9, 2026 08:48

fengmk2 force-pushed the graphite-base/739 branch from 94d6f7b to 82abaa7Compare March 9, 2026 08:48

fengmk2 changed the base branch from graphite-base/739 to export-lint-and-fmt-typesMarch 9, 2026 08:48

fengmk2 mentioned this pull request Mar 9, 2026
refactor: replace custom OxlintConfig with oxlint package export #740
Merged

fengmk2 force-pushed the export-lint-and-fmt-types branch from 82abaa7 to 2d8a8dbCompare March 9, 2026 08:56

fengmk2 force-pushed the improve-vp-check branch from aec26b4 to a764269Compare March 9, 2026 08:56

fengmk2 marked this pull request as ready for review March 9, 2026 08:58

fengmk2 requested review from cpojer and leaysgur March 9, 2026 08:59

fengmk2 commented Mar 9, 2026
View reviewed changes

Comment threadpackages/cli/src/utils/editor.ts

leaysgur requested a review from camc314 March 9, 2026 09:07

cpojer approved these changes Mar 9, 2026
View reviewed changes

fengmk2 changed the base branch from export-lint-and-fmt-types to graphite-base/739March 9, 2026 11:11

fengmk2 force-pushed the improve-vp-check branch from a764269 to 268e38eCompare March 9, 2026 11:28

fengmk2 force-pushed the graphite-base/739 branch 2 times, most recently from 9c62ad8 to 9121608Compare March 9, 2026 11:42

fengmk2 force-pushed the improve-vp-check branch from 268e38e to a2d52fdCompare March 9, 2026 11:42

graphite-appBot changed the base branch from graphite-base/739 to mainMarch 9, 2026 11:42

fengmk2 force-pushed the improve-vp-check branch from a2d52fd to 157d592Compare March 9, 2026 11:42

refactor: replace custom OxlintConfig with oxlint package export
6d509ca
Remove the 874-line hand-written oxlint-config.ts and import OxlintConfig directly from the oxlint package, which already exports the same type. Clean up related lint overrides and typos exclusions for the deleted file.

fengmk2 force-pushed the improve-vp-check branch from 157d592 to 6d509caCompare March 9, 2026 11:57

fengmk2 added the test: e2e Auto run e2e tests label Mar 9, 2026

fengmk2 mentioned this pull request Mar 9, 2026
feat(migrate): Prettier → Oxfmt migration via vp fmt --migrate=prettier #742
Merged

camc314 reviewed Mar 9, 2026
View reviewed changes

Comment threadrfcs/migration-command.md Outdated

fengmk2 force-pushed the improve-vp-check branch from 5a4c483 to 6237268Compare March 9, 2026 13:58

fengmk2 mentioned this pull request Mar 9, 2026
feat(migrate): auto-fix tsconfig baseUrl to enable typeAware/typeCheck by default #743
Closed

fengmk2 commented Mar 9, 2026
View reviewed changes

Comment threadpackages/cli/snap-tests-global/migration-baseurl-tsconfig/snap.txt

fengmk2 force-pushed the improve-vp-check branch from 4b5b347 to 56dfed9Compare March 9, 2026 14:29

fengmk2 added 2 commits March 9, 2026 23:04

fengmk2 mentioned this pull request Mar 9, 2026
refactor: migrate packages/cli build from tsc+rolldown to tsdown #744
Closed

fengmk2 commented Mar 9, 2026
View reviewed changes

Comment threadpackages/cli/package.json Outdated

fengmk2 added 3 commits March 9, 2026 23:46

chore: update vue-mini e2e project hash to latest
69220fb

fengmk2 commented Mar 9, 2026
View reviewed changes

Comment threadcrates/vite_migration/src/vite_config.rs

fengmk2 merged commit 189d2b3 into mainMar 9, 2026
38 checks passed

fengmk2 deleted the improve-vp-check branch March 9, 2026 17:04

This was referenced Mar 14, 2026
fix(help): replace stale --no-type-check example in vp check help #875
Merged
fix(help): stale --no-type-check example in vp check help #879
Closed

TheAlexLichter mentioned this pull request May 26, 2026
fix(cli): parse tsconfig as jsonc #1688
Merged

fengmk2 pushed a commit that referenced this pull request May 27, 2026
fix(cli): parse tsconfig as jsonc (#1688)
bd10024
If tsconfig has comments, JSON.parse fails and we can't detect nor remove baseUrl! This PR resolves this. Related: #739

coderabbitaiBot mentioned this pull request Aug 4, 2026
docs: TypeScript 7 / Vite+ / Oxlint / Oxfmt clean cut-over plan bitflight-devops/github-action-readme-generator#613
Merged
21 tasks

coderabbitaiBot mentioned this pull request Aug 20, 2026
Adopt Vite+ for project tooling FantechLabs/skills#10
Merged
11 tasks

Navigation Menu

Uh oh!

refactor: move typeAware/typeCheck from CLI flags to vite.config.ts - #739

refactor: move typeAware/typeCheck from CLI flags to vite.config.ts#739
fengmk2 merged 8 commits into
mainfrom
improve-vp-check

fengmk2 commented Mar 9, 2026

Uh oh!

netlifyBot commented Mar 9, 2026•
edited
Loading

Uh oh!

fengmk2 commented Mar 9, 2026•
edited
Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fengmk2 commented Mar 9, 2026•
edited
Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

fengmk2 commented Mar 9, 2026

Uh oh!

netlifyBot commented Mar 9, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for viteplus-staging canceled.

Uh oh!

fengmk2 commented Mar 9, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fengmk2 commented Mar 9, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

netlifyBot commented Mar 9, 2026•
edited
Loading

fengmk2 commented Mar 9, 2026•
edited
Loading

fengmk2 commented Mar 9, 2026•
edited
Loading