Uh oh!
There was an error while loading. Please reload this page.
feat: merge synthetic task's input config in inherited cache path - #292
Closed
fengmk2 wants to merge 2 commits into
Closed
feat: merge synthetic task's input config in inherited cache path#292fengmk2 wants to merge 2 commits into
fengmk2 wants to merge 2 commits into
Conversation
When a synthetic task (e.g., vp pack, vp build) runs inside a parent script task, the parent's cache config is inherited. Previously, only env and untracked_env were merged from the synthetic — the input config was silently dropped, causing negative glob exclusions to be ignored. Now the synthetic's input globs are resolved relative to the workspace root and merged into the parent's input_config. This allows callers to pass negative globs (e.g., !node_modules/.vite-temp/**) that correctly exclude paths from fspy tracking. Closesvoidzero-dev/vite-plus#1095
fengmk2
marked this pull request as draft
March 25, 2026 03:09
fengmk2
marked this pull request as ready for review
March 25, 2026 03:31
Merged
3 tasks
fengmk2
commented
Mar 25, 2026
MemberAuthor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
inputconfig into parent'sinput_configin theInheritedcache pathWhen a synthetic task (e.g.,
vp pack,vp build) runs inside a parent script task, the parent's cache config is inherited. Previously, onlyenvanduntracked_envwere merged from the synthetic — theinputconfig was silently dropped, causing negative glob exclusions to be ignored.Now the synthetic's input globs are resolved relative to the workspace root and merged into the parent's
input_config. This allows callers (like vite-plus) to pass negative globs (e.g.,!node_modules/.vite-temp/**) that correctly exclude paths from fspy tracking.Test plan
cache-negative-input-glob: verifies cache hit despite.vite-tempwrite when negative glob is configuredcache-negative-input-glob: verifies real source changes still cause cache missvite_task_plantests pass (25 unit + plan snapshots)Closesvoidzero-dev/vite-plus#1095
🤖 Generated with Claude Code