Uh oh!
There was an error while loading. Please reload this page.
test(cache): real-vite integration fixtures + playground - #408
Closed
wan9chi wants to merge 1 commit into
Closed
Conversation
This was referenced May 28, 2026
MemberAuthor
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced May 28, 2026
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit:c32f92dba9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| # Track the vite PR #22453 build until @voidzero-dev/vite-task-client is | ||
| # published to npm and the integration ships in a real vite release. Pinned | ||
| # to a commit-specific pkg.pr.new URL so bumps require updating this line. | ||
| vite: https://pkg.pr.new/vite@23ded7bb458062c028d7a52019133c9cfd51b105 |
There was a problem hiding this comment.
This adds a catalog entry for Vite, but catalog entries do not install packages by themselves. The e2e harness resolves these new ignored fixtures by putting packages/tools/node_modules/.bin on PATH and symlinking packages/tools/node_modules/vite; since packages/tools/package.json still does not depend on vite, a clean pnpm install will not create that binary and vt run --cache build in this fixture fails before exercising the cache behavior. Please add vite: "catalog:" to the installed toolchain package (and update the lockfile) or otherwise make the fixture install it.
Useful? React with 👍 / 👎.
wan9chiforce-pushed
the
feat/runner-vite-e2e
branch
from
May 28, 2026 08:02
c32f92d to
aefe784Comparewan9chiforce-pushed
the
feat/runner-cache-integration
branch
2 times, most recently
from
May 28, 2026 08:05
1ba9f54 to
d2b5429Comparewan9chiforce-pushed
the
feat/runner-vite-e2e
branch
2 times, most recently
from
May 28, 2026 08:09
3516a20 to
26d0762Comparewan9chiforce-pushed
the
feat/runner-cache-integration
branch
from
May 28, 2026 08:09
d2b5429 to
3c2c82dComparewan9chiforce-pushed
the
feat/runner-vite-e2e
branch
from
May 28, 2026 08:29
26d0762 to
56935f9Comparewan9chiforce-pushed
the
feat/runner-cache-integration
branch
from
May 28, 2026 08:29
3c2c82d to
1d4b087Comparewan9chiforce-pushed
the
feat/runner-cache-integration
branch
from
May 28, 2026 09:07
1d4b087 to
fa9255dComparewan9chiforce-pushed
the
feat/runner-vite-e2e
branch
2 times, most recently
from
May 28, 2026 09:09
7a80c90 to
a1025cdComparewan9chiforce-pushed
the
feat/runner-cache-integration
branch
2 times, most recently
from
May 28, 2026 09:11
2858cb8 to
a587cedComparewan9chiforce-pushed
the
feat/runner-vite-e2e
branch
2 times, most recently
from
May 28, 2026 09:57
12641eb to
e8f68ddComparewan9chiforce-pushed
the
feat/runner-cache-integration
branch
2 times, most recently
from
May 28, 2026 10:13
8c46da5 to
a5cc208Comparewan9chiforce-pushed
the
feat/runner-vite-e2e
branch
2 times, most recently
from
May 28, 2026 10:43
40d9dc4 to
d5d2cb5Comparewan9chiforce-pushed
the
feat/runner-cache-integration
branch
from
May 28, 2026 10:43
a5cc208 to
4a3e31dCompareAdds the real-vite e2e coverage: `vite_build_cache` exercises runner-aware cache behaviour through `vite build` against the companion vite PR (NODE_ENV-change invalidation, `envPrefix`-driven tracked-env set, `dist/` write restoration on cache hit), and `vite_dev_disable_cache` verifies `disableCache()` short-circuits the dev server's run from the cache. Wires the rest of the consumer-side bits needed for vite (consumed via the `github:` spec for vite-task-client) to install cleanly: - Adds `vite: catalog:` to `packages/tools/package.json` so `pnpm install` materialises `packages/tools/node_modules/.bin/vite` for the harness's `link_tools_packages(stage, ["vite"])` symlink setup. - Pins root `packageManager` to `pnpm@10.33.4` matching the vite PR's pnpm, removing a per-install version switch that produced an outer-vs-inner lockfile-settings mismatch when vite consumed vite-task as a git dep. - Drops the root `prepare: husky` so pnpm's git-dep flow doesn't invoke `pnpm pack`, which had been producing a lockfile `resolution` entry without the `path:` field — pnpm then extracted the *entire* vite-task monorepo into `node_modules/@voidzero-dev/vite-task-client/` instead of the subpath. - Pins the vite catalog entry to a commit-specific `pkg.pr.new` URL so future bumps require updating this line. - Sets `blockExoticSubdeps: false` so pnpm 11 doesn't reject the transitive `github:` spec. Refreshes the playground to use the published vite + the runner- aware tools. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
wan9chiforce-pushed
the
feat/runner-vite-e2e
branch
from
May 28, 2026 11:46
d5d2cb5 to
e051931Comparewan9chiforce-pushed
the
feat/runner-cache-integration
branch
from
May 28, 2026 11:46
4a3e31d to
9db3dd2Comparewan9chi
commented
May 28, 2026
MemberAuthor
Superseded by restructured 2-PR stack:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the real-vite e2e coverage:
vite_build_cacheexercisesrunner-aware cache behaviour through
vite buildagainst thecompanion vite PR (NODE_ENV-change invalidation,
envPrefix-driventracked-env set,
dist/write restoration on cache hit), andvite_dev_disable_cacheverifiesdisableCache()short-circuitsthe dev server's run from the cache.
Wires the rest of the consumer-side bits needed for vite (consumed
via the
github:spec for vite-task-client) to install cleanly:packageManagertopnpm@10.33.4matching the vitePR's pnpm, removing a per-install version switch that produced
an outer-vs-inner lockfile-settings mismatch when vite consumed
vite-task as a git dep.
prepare: huskyso pnpm's git-dep flow doesn'tinvoke
pnpm pack, which had been producing a lockfileresolutionentry without thepath:field — pnpm thenextracted the entire vite-task monorepo into
node_modules/@voidzero-dev/vite-task-client/instead of thesubpath.
pkg.pr.newURL so future bumps require updating this line.
blockExoticSubdeps: falseso pnpm 11 doesn't reject thetransitive
github:spec.Refreshes the playground to use the published vite + the runner-
aware tools.
Co-Authored-By: Claude Opus 4.7 (1M context) noreply@anthropic.com