Skip to content

feat(task-graph): materialize object dependsOn edges - #475

Closed
wan9chi wants to merge 4 commits into
mainfrom
codex/global-object-dependson
Closed

feat(task-graph): materialize object dependsOn edges#475
wan9chi wants to merge 4 commits into
mainfrom
codex/global-object-dependson

Conversation

@wan9chi

@wan9chiwan9chi commented Jun 18, 2026

Copy link
Copy Markdown
Member

Motivation

Object-form dependsOn rules currently behave like query-time expansion rules, so the global task graph does not show edges for entries such as { "task": "build", "from": "dependencies" }. This PR resets the prior query-time implementation, then reintroduces object-form dependsOn by materializing direct package dependency selections as task graph edges during graph loading.

@wan9chiGraphite App

Copy link
Copy Markdown
MemberAuthor

This stack of pull requests is managed by Graphite. Learn more about stacking.

@wan9chiwan9chi changed the title Revert "fix(task-graph): limit package dependsOn to direct deps (#469)"feat(task-graph): materialize object dependsOn edgesJun 18, 2026

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:46ddbb1e8e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadcrates/vite_task_graph/src/lib.rs
wan9chiand others added 4 commits June 20, 2026 15:54
This reverts commit ed454ce.
Co-authored-by: GPT-5 Codex <codex@openai.com>
This reverts commit 6296ffa.
Co-authored-by: GPT-5 Codex <codex@openai.com>
Co-authored-by: GPT-5 Codex <codex@openai.com>
Co-authored-by: GPT-5 Codex <codex@openai.com>
@wan9chi
wan9chiforce-pushed the codex/global-object-dependson branch from 9a42352 to af6c356CompareJune 20, 2026 07:57
@wan9chiClaude

Copy link
Copy Markdown
MemberAuthor

Superseded by a Graphite stack that splits this into two reviewable PRs:

The per-case plan snapshots were also trimmed: since the edges now live in the global graph, task_graph.md covers the structural cases, leaving only the --ignore-depends-on case (the one query-time behavior the static graph can't express).

Closing in favor of the stack.


Generated by Claude Code

@wan9chiwan9chi closed this Jun 20, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@wan9chi