Skip to content

RFC for support of .node-version file - #54

Open
andreassjoberg wants to merge 5 commits into
volta-cli:mainfrom
andreassjoberg:dot-node-version-file-support
Open

RFC for support of .node-version file#54
andreassjoberg wants to merge 5 commits into
volta-cli:mainfrom
andreassjoberg:dot-node-version-file-support

Conversation

@andreassjoberg

@andreassjobergandreassjoberg commented Mar 4, 2025

Copy link
Copy Markdown

No description provided.

@andreassjobergandreassjoberg mentioned this pull request Mar 4, 2025
Closed
rwjblue
rwjblue requested changes Mar 4, 2025
View reviewed changes
Comment threadtext/0000-dot-node-version-file-support.md Outdated
Comment threadtext/0000-dot-node-version-file-support.md
Comment threadtext/0000-dot-node-version-file-support.md Outdated
Comment threadtext/0000-dot-node-version-file-support.md Outdated
Comment threadtext/0000-dot-node-version-file-support.md Outdated
Comment threadtext/0000-dot-node-version-file-support.md
@andreassjoberg

andreassjoberg commented Mar 5, 2025

Copy link
Copy Markdown
Author

@rwjblue Thank you for very good comments!

I have updated the RFC. Please have another look and let me know if anything needs clarification.

rwjblue
rwjblue reviewed Mar 5, 2025
View reviewed changes

@rwjbluerwjblue left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are great updates, thank you!

Comment threadtext/0000-dot-node-version-file-support.md
rwjblue
rwjblue reviewed Mar 5, 2025
View reviewed changes
Comment threadtext/0000-dot-node-version-file-support.md
@andreassjoberg

andreassjoberg commented Mar 5, 2025

Copy link
Copy Markdown
Author

Thanks again @rwjblue! I've updated the file once again. 👍

This was referenced Mar 5, 2025
Open
Open
rwjblue
rwjblue approved these changes Mar 7, 2025
View reviewed changes

@rwjbluerwjblue left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking really good! Thank you for working on it @andreassjoberg!

Comment threadtext/0000-dot-node-version-file-support.md Outdated
@mb21mb21 mentioned this pull request Oct 14, 2025
Open
@yvbeek

yvbeek commented Jan 24, 2026

Copy link
Copy Markdown

This looks great, could we have this merged in?

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rwjbluerwjbluerwjblue approved these changes
+1 more reviewer
@mb21mb21mb21 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@andreassjoberg@yvbeek@rwjblue@mb21