Uh oh!
There was an error while loading. Please reload this page.
datafusion 48 - #3560
Merged
Merged
Conversation
AdamGS
reviewed
Jun 18, 2025
| log::debug!("DataFusion expression can't be pushed down: {expr:?}"); | ||
| false | ||
| } | ||
| fn can_be_pushed_down(expr: &PhysicalExprRef, schema: &Schema) -> bool { |
Contributor
There was a problem hiding this comment.
was just thinking last night due we support new things here? We have In now too right? (@joseph-isaacs?)
Contributor
There was a problem hiding this comment.
But its a pretty slow rn, what type would it run over?
Contributor
There was a problem hiding this comment.
whatever is available I guess? if its not a perf win right now we can add that later
AdamGS
approved these changes
Jun 18, 2025
AdamGS
commented
Jun 18, 2025
Contributor
I think the tests fails because datafusion used to default to |
Contributor
Benchmarks: TPC-H on NVMETable of Results
|
Contributor
Benchmarks: TPC-H on S3Table of Results
|
Contributor
Benchmarks: Clickbench on NVMETable of Results
|
Contributor
IDK what happened to query 6, but we're 20x worse and parquet is 25x worse. There were a bunch of changes to statistics and repartitioning recently and I wonder if that's the issue there, the query is: SELECTMIN("EventDate"), MAX("EventDate") FROM hits; |
robert3005
commented
Jun 18, 2025
Contributor
Wonder if they no longer correctly prune on file level statistics when they added partition group statistics |
Contributor
@robert3005 thats my suspicion, parts of that were already in v47 but v48 has at least one more big change around that |
onursatici
commented
Jun 18, 2025
ContributorAuthor
I am also curious, will have a look, query 0 is also 10x @ parquet and 3x @ vortex |
robert3005
commented
Jun 18, 2025
Contributor
I filed an issue upstream apache/datafusion#16444 |
AdamGS
commented
Jun 19, 2025
Contributor
I think this fine to merge, we can re-enable the datafusion config (+ #3569) and once apache/datafusion#16447 is released it'll be the default behavior again. |
onursatici
enabled auto-merge (squash)
June 19, 2025 10:56
Signed-off-by: Onur Satici <onur@spiraldb.com>
This is required for apache/datafusion#16447 to take effect (once its merged). By default datafusion will take care of that if you use the SQL interface (and do all the session state setup). Signed-off-by: Adam Gutglick <adam@spiraldb.com>
mwlon pushed a commit
to mwlon/vortex
that referenced
this pull request
Jul 4, 2025
Signed-off-by: Onur Satici <onur@spiraldb.com> Signed-off-by: Adam Gutglick <adam@spiraldb.com> Co-authored-by: Adam Gutglick <adam@spiraldb.com> Signed-off-by: mwlon <m.w.loncaric@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.