Uh oh!
There was an error while loading. Please reload this page.
feat: use VarBinView as the new canonical string type - #757
Closed
a10y wants to merge 6 commits into
Closed
Conversation
robert3005
commented
Sep 6, 2024
Contributor
I think apache/arrow-rs#6366 is going to make python tests fail |
a10y
commented
Sep 6, 2024
ContributorAuthor
Yea, even bumping PyArrow from 15 -> 17 (latest) did not seem to change that |
a10y
commented
Sep 6, 2024
ContributorAuthor
Blocked on apache/arrow-rs#6368 |
a10y
marked this pull request as draft
October 4, 2024 14:05
a10y
commented
Oct 4, 2024
ContributorAuthor
Converting back to draft while this is blocked |
robert3005
commented
Oct 6, 2024
Contributor
I think with arrow 53.1.0 this is no longer blocked |
a10y
commented
Oct 17, 2024
ContributorAuthor
 Time for a take3 PR 🥲 |
robert3005
commented
Oct 17, 2024
Contributor
git cli is a lot smarter than github ui but probably still hard |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supplants #476.
VarBinView is the new canonical representation for string types across the repo. There are still many places that natively use VarBin arrays internally, we can replace those over time.
Canonical::VarBin->Canonical::VarBinView