Skip to content

PR to track HOL changes, don't merge - #822

Open
mezpusz wants to merge 221 commits into
masterfrom
ahmed-new-hol
Open

PR to track HOL changes, don't merge#822
mezpusz wants to merge 221 commits into
masterfrom
ahmed-new-hol

Conversation

@mezpusz

Copy link
Copy Markdown
Contributor

No description provided.

ibnyusufand others added 30 commits July 19, 2022 12:07
Comment threadShell/Property.cpp
Comment threadShell/NewCNF.cpp

GenClause::Iterator lit = gc->genLiterals();
while (lit.hasNext()) {
GenLit gl = lit.next();
Formula* g = formula(gl);

// This can happen when the problem is pseudo-higher-order

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO check why

Comment threadShell/Preprocess.cpp
Comment threadShell/Property.hpp
// for use by polymorphic unit tests
// have to force the type con arity to avoid
// running KBOforEPR
void forceMaxTypeConArity() { _maxTypeConArity = 1; }

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No KBOforEPR anymore, so this is obsolete.

Comment threadShell/Skolem.cpp
Comment threadSAT/Z3Interfacing.cpp
}
} else {
symb = env.signature->getFunction(trm->functor());
range_sort = SortHelper::getResultSort(trm);

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO check what these do

if (env.options->FOOLParamodulation()) {
if (env.options->FOOLParamodulation()
#if VHOL
|| env.options->cases() || env.options->casesSimp() || env.property->higherOrder()

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The last disjunct is questionable, as by default nothing handles FOOL exhaustiveness in the HOL branch, losing some problems.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@mezpusz@ibnyusuf@joe-hauns@quickbeam123@bhayat-quantinuum