Skip to content

Modernize CI - #594

Merged
ariesclark merged 17 commits into
mainfrom
ci/modernise
Aug 9, 2026
Merged

Modernize CI#594
ariesclark merged 17 commits into
mainfrom
ci/modernise

Conversation

@ariesclark

Copy link
Copy Markdown
Member

No description provided.

CopilotAI lite review requested due to automatic review settings August 9, 2026 08:53
@ariesclarkariesclark changed the title Ci/moderniseModernize CIAug 9, 2026

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR modernises the repository’s CI/release workflow and introduces a couple of reusable composite actions, while also pinning the project’s package manager to pnpm 11.

Changes:

  • Update CI workflow actions/steps (checkout, pnpm/bun setup, artifact upload/download) and add downstream reusable workflow jobs for SDK builds.
  • Add packageManager pin and include @actions/artifact as a devDependency for artifact uploads.
  • Add composite actions for installing OpenAPI Generator and downloading the bundled spec.

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
FileDescription
pnpm-lock.yamlLockfile update to include @actions/artifact and its transitive dependencies.
package.jsonPins pnpm version and adds @actions/artifact to devDependencies.
.github/workflows/ci.yamlRefactors CI jobs and introduces reusable workflow fan-out for downstream builds.
.github/actions/setup-generator/action.ymlNew composite action to cache and install a pinned openapi-generator jar.
.github/actions/download/action.ymlNew composite action to fetch a bundle from artifacts (in-repo) or latest release (external).
Files not reviewed (1)
  • pnpm-lock.yaml: Generated file
Suppressed comments (2)

.github/workflows/ci.yaml:83

  • pnpm/setup@v2 does not exist and the bundle job currently never installs dependencies, so bun --bun run bundle and the subsequent require('@actions/artifact') in github-script will fail. Use a valid pnpm setup action and run an install step before bundling/uploading artifacts.
 - uses: pnpm/setup@v2
with:
runtime: bun@latest
cache: true

.github/workflows/ci.yaml:155

  • The release job uses pnpm (e.g., pnpm semver) but the current setup step references pnpm/setup@v2 (nonexistent) and does not ensure a Node version compatible with pnpm 11. Pin Node >=22 and use a valid pnpm setup action so release version computation is reliable.
 - uses: pnpm/setup@v2
with:
runtime: bun@latest
cache: true

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread.github/workflows/ci.yaml
Comment threadpackage.json
ariesclarkand others added 2 commits August 9, 2026 04:58
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@pkg-pr-new

pkg-pr-newBot commented Aug 9, 2026

Copy link
Copy Markdown
pnpm add https://pkg.pr.new/vrchatapi/specification/vrchat@ae182d3

commit: ae182d3

@github-actions

This comment was marked as outdated.

@ariesclark
ariesclark added this pull request to the merge queueAug 9, 2026
Merged via the queue into main with commit ccd6353Aug 9, 2026
111 of 118 checks passed
@ariesclark
ariesclark deleted the ci/modernise branch August 9, 2026 11:03
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@ariesclark