Uh oh!
There was an error while loading. Please reload this page.
Ci/modernise actions - #38
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR modernizes the repository’s generation and CI pipeline by removing the Node-based OpenAPI generator dependency and shifting generation/build steps to a reusable tooling setup, with updated GitHub Actions versions.
Changes:
- Removed
package.json/package-lock.jsonused to install@openapitools/openapi-generator-cli. - Updated
generate.shto invokeopenapi-generatordirectly instead of the Node CLI wrapper. - Refactored
.github/workflows/ci.yamlintogenerate→build→publishjobs using artifacts, and updated action versions in workflows.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Removed Node dependency previously used for OpenAPI generator CLI. |
| package-lock.json | Removed lockfile associated with the removed Node dependency. |
| openapitools.json | Removed schema path that depended on node_modules/ being present. |
| generate.sh | Switched generator invocation from node_modules script to openapi-generator command. |
| .github/workflows/realtime-ci.yml | Updated action versions used for the realtime SDK build/publish workflow. |
| .github/workflows/ci.yaml | Reworked CI into generator/build/publish stages, added push/PR triggers, and switched to reusable generator setup + artifact passing. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+39
to
+42
| - uses: actions/checkout@v7 | ||
| with: | ||
| node-version: 22 | ||
| repository: vrchatapi/vrchatapi-csharp | ||
| ref: ${{ inputs.ref || github.ref }} |
Comment on lines
+29
to
+31
| env: | ||
| PASSED_VERSION: ${{ (github.event_name == 'repository_dispatch' && github.event.client_payload || fromJSON(inputs.json || '{}'))['version'] }} | ||
| VERSION_POSTPEND: ${{ github.event_name == 'workflow_dispatch' && inputs.version_postfix || '' }} |
Comment on lines
+44
to
+48
| - uses: vrchatapi/specification/.github/actions/setup-generator@main | ||
| - uses: actions/checkout@v4 | ||
| - name: 'Cache node_modules' | ||
| uses: actions/cache@v4 | ||
| - uses: vrchatapi/specification/.github/actions/download@main | ||
| with: | ||
| path: node_modules | ||
| key: ${{ runner.os }}-node-v22-${{ hashFiles('**/generate.sh') }} | ||
| restore-keys: | | ||
| ${{ runner.os }}-node-v22 | ||
| bundle: openapi-legacy.yaml |
Comment on lines
9
to
12
| rm src docs *.nupkg *.snupkg -rf | ||
| ./node_modules/\@openapitools/openapi-generator-cli/main.js generate \ | ||
| openapi-generator generate \ | ||
| -g csharp \ |
Comment on lines
+65
to
+69
| - uses: actions/upload-artifact@v7 | ||
| with: | ||
| name: csharp-generated | ||
| path: . | ||
| include-hidden-files: true |
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.