Uh oh!
There was an error while loading. Please reload this page.
Ci/modernise actions - #12
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR modernizes the repository’s CI/release automation by removing the Node-based OpenAPI Generator CLI dependency and restructuring GitHub Actions workflows to generate, test, and publish the Java SDK using a dedicated generator setup action.
Changes:
- Remove
package.json/package-lock.json(drop vendored Node OpenAPI Generator CLI dependency). - Switch
generate.shfrom invokingnode_modules/@openapitools/openapi-generator-clito theopenapi-generatorexecutable. - Replace the previous Maven workflow and refactor
.github/workflows/ci.yamlto include generate/test/publish jobs and add push/pull_request triggers.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Removed Node dependency for OpenAPI Generator CLI. |
| package-lock.json | Removed lockfile since Node deps are no longer used. |
| openapitools.json | Removes schema path that depended on node_modules; keeps generator version pin. |
| generate.sh | Uses openapi-generator on PATH instead of Node CLI. |
| .github/workflows/maven.yml | Deleted legacy Maven CI workflow. |
| .github/workflows/ci.yaml | New consolidated CI workflow with generate/test/publish and updated triggers/actions. |
Suppressed comments (1)
.github/workflows/ci.yaml:41
ref: ${{ inputs.ref || github.ref }}will break onpush/pull_requestbecause theinputscontext only exists forworkflow_dispatch/workflow_call. Split this into two checkout steps so only theworkflow_callpath referencesinputs.ref.
- uses: actions/checkout@v7
with:
repository: vrchatapi/vrchatapi-java
ref: ${{ inputs.ref || github.ref }}
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| rm src/main/java/io/github/vrchatapi/model -rf | ||
| ./node_modules/\@openapitools/openapi-generator-cli/main.js generate \ | ||
| openapi-generator generate \ |
Comment on lines
+29
to
+31
| env: | ||
| PASSED_VERSION: ${{ (github.event_name == 'repository_dispatch' && github.event.client_payload || fromJSON(inputs.json || '{}'))['version'] }} | ||
| VERSION_POSTPEND: ${{ github.event_name == 'workflow_dispatch' && inputs.version_postfix || '' }} |
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.