Uh oh!
There was an error while loading. Please reload this page.
Ci/modernise actions - #36
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR modernizes the repository’s CI pipeline for generating/building/publishing the Python SDK and removes the Node-based OpenAPI Generator CLI dependency in favor of invoking an openapi-generator binary (provisioned by CI via shared actions).
Changes:
- Removed
package.json/package-lock.jsonthat previously pinned@openapitools/openapi-generator-cli. - Updated
generate.shto callopenapi-generator generateinstead of the Node CLI entrypoint. - Refactored
.github/workflows/ci.yamlinto generate/build/install/publish jobs, addedpush/pull_requesttriggers, and switched to shared actions for generator setup/spec download.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Removed Node dependency previously used to run OpenAPI Generator. |
| package-lock.json | Removed lockfile corresponding to the removed Node dependency. |
| openapitools.json | Removed schema reference that depended on node_modules. |
| generate.sh | Switched generator invocation from Node CLI path to openapi-generator on PATH. |
| .github/workflows/ci.yaml | Major CI refactor: new triggers, shared generator setup/download actions, split build/install/publish jobs, and updated action usage. |
Suppressed comments (1)
.github/workflows/ci.yaml:42
ref: ${{ inputs.ref || github.ref }}will also fail onpush/pull_requestbecause theinputscontext is not defined for those events. Useinputs.refonly forworkflow_call(orworkflow_dispatch), and default togithub.refotherwise.
with:
repository: vrchatapi/vrchatapi-python
ref: ${{ inputs.ref || github.ref }}
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+29
to
+31
| env: | ||
| PASSED_VERSION: ${{ (github.event_name == 'repository_dispatch' && github.event.client_payload || fromJSON(inputs.json || '{}'))['version'] }} | ||
| VERSION_POSTPEND: ${{ github.event_name == 'workflow_dispatch' && inputs.version_postfix || '' }} |
Comment on lines
8
to
+10
| rm vrchatapi docs -rf | ||
| ./node_modules/\@openapitools/openapi-generator-cli/main.js generate \ | ||
| openapi-generator generate \ |
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.