Skip to content

feat(types): Better typescript support for emit events - #2164

Open
pikax wants to merge 16 commits into
vuejs:minorfrom
pikax:types/string_type_inference
Open

pikax wants to merge 16 commits into
vuejs:minorfrom
pikax:types/string_type_inference

Conversation

@pikax

@pikax pikax commented Sep 19, 2020

Copy link
Copy Markdown
Member

Requires typescript@4.1

NOTE: There's some build errors when updating to typescript@4.1, this PR is not meant to fix those errors, only to implement string type inference

image
image
image
image

@yyx990803 yyx990803 added the 🍰 p2-nice-to-have Priority 2: this is not breaking anything but nice to have it addressed. label Dec 4, 2020
@pikax
pikax marked this pull request as ready for review December 19, 2020 13:17
@pikax

pikax commented Dec 19, 2020

Copy link
Copy Markdown
Member Author

I believe the build is failing because of usage of Typescript ^4.1.x with @microsoft/api-extractor

@yyx990803

Copy link
Copy Markdown
Member

@pikax mind rebasing on latest 3.2 branch?

@yyx990803
yyx990803 changed the base branch from master to 3.2 July 16, 2021 14:00
pikax added 2 commits July 16, 2021 15:41
# Conflicts:
#	packages/runtime-core/src/component.ts
#	packages/runtime-core/src/componentOptions.ts
#	packages/runtime-core/src/componentProps.ts
@edison1105
edison1105 changed the base branch from 3.2 to minor September 9, 2024 08:35
@edison1105

Copy link
Copy Markdown
Member

Could you please resolve those conflicts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🍰 p2-nice-to-have Priority 2: this is not breaking anything but nice to have it addressed. scope: types version: minor

Projects

Status: Needs Review

Development

Successfully merging this pull request may close these issues.

[TypeScript] Type error when passing SetupContext to a composable function which expects a partial of the EmitsOptions

4 participants