Skip to content

fix(VDialog): remove console error on escape keypress - #7030

Merged
MajesticPotatoe merged 4 commits into
vuetifyjs:masterfrom
kuromoka:fix/dialog-console
Apr 22, 2019
Merged

fix(VDialog): remove console error on escape keypress#7030
MajesticPotatoe merged 4 commits into
vuetifyjs:masterfrom
kuromoka:fix/dialog-console

Conversation

@kuromoka

Copy link
Copy Markdown
Contributor

Description

removed [Vuetify] No activator found error on escape keypress when dialog is active.

Motivation and Context

fixes #7008

How Has This Been Tested?

visually

Markup:

Details
<template>
  <v-app>
    <v-content>
      <v-layout row justify-center>
        <v-btn
          color="primary"
          dark
          @click.stop="dialog = true"
        >
          Open Dialog
        </v-btn>
        <v-dialog
          v-model="dialog"
          max-width="290"
        >
          <v-card>
            <v-card-title class="headline">Use Google's location service?</v-card-title>
            <v-card-text>
              Let Google help apps determine location. This means sending anonymous location data to Google, even when no apps are running.
            </v-card-text>
            <v-card-actions>
              <v-spacer />
              <v-btn
                color="green darken-1"
                flat="flat"
                @click="dialog = false"
              >
                Disagree
              </v-btn>
              <v-btn
                color="green darken-1"
                flat="flat"
                @click="dialog = false"
              >
                Agree
              </v-btn>
            </v-card-actions>
          </v-card>
        </v-dialog>
      </v-layout>
    </v-content>
  </v-app>
</template>

<script>
  export default {
    data () {
      return {
        dialog: false
      }
    }
  }
</script>

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any feature but make things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and breaking changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)

@codecov

codecov Bot commented Apr 20, 2019

Copy link
Copy Markdown

Codecov Report

Merging #7030 into master will increase coverage by 0.12%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7030      +/-   ##
==========================================
+ Coverage    85.3%   85.43%   +0.12%     
==========================================
  Files         298      298              
  Lines        7221     7221              
  Branches     1804     1804              
==========================================
+ Hits         6160     6169       +9     
+ Misses        960      956       -4     
+ Partials      101       96       -5
Impacted Files Coverage Δ
packages/vuetify/src/components/VDialog/VDialog.js 71.28% <100%> (+7.92%) ⬆️
packages/vuetify/src/mixins/overlayable.ts 41.05% <0%> (+1.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 415f8ca...7f7414d. Read the comment docs.

Comment thread packages/vuetify/src/components/VDialog/VDialog.js Outdated

@dsseng dsseng left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@dsseng
dsseng requested a review from KaelWD April 22, 2019 13:46
@MajesticPotatoe
MajesticPotatoe merged commit f2303f1 into vuetifyjs:master Apr 22, 2019
@lock lock Bot locked as resolved and limited conversation to collaborators May 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug Report] VDialog - "[Vuetify] No activator found" error on escape keypress

4 participants