fix(VDialog): remove console error on escape keypress - #7030
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7030 +/- ##
==========================================
+ Coverage 85.3% 85.43% +0.12%
==========================================
Files 298 298
Lines 7221 7221
Branches 1804 1804
==========================================
+ Hits 6160 6169 +9
+ Misses 960 956 -4
+ Partials 101 96 -5
Continue to review full report at Codecov.
|
KaelWD
reviewed
Apr 20, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
removed
[Vuetify] No activator founderror on escape keypress when dialog is active.Motivation and Context
fixes #7008
How Has This Been Tested?
visually
Markup:
Details
Types of changes
Checklist:
masterfor bug fixes and documentation updates,devfor new features and breaking changes).