Skip to content

fix(VSelect): update selected color - #7079

Merged
dsseng merged 5 commits into
vuetifyjs:masterfrom
FAKER-A:dev
Apr 27, 2019
Merged

fix(VSelect): update selected color#7079
dsseng merged 5 commits into
vuetifyjs:masterfrom
FAKER-A:dev

Conversation

@FAKER-A

@FAKER-A FAKER-A commented Apr 26, 2019

Copy link
Copy Markdown
Contributor

Description

When color is set to a value of type #123456, the selected color will not change.
The purpose of this submission is to fix the above problem.

Motivation and Context

Fixes #6685
https://codepen.io/peterhpchen/pen/RdKzKP?editors=1010

How Has This Been Tested?

none

Markup:

Details
<template>
  <v-app>
    <v-autocomplete v-model="model" color="#FF66FF" :items="items"></v-autocomplete>
    <v-autocomplete v-model="model" color="red" :items="items"></v-autocomplete>
  </v-app>
</template>

<script>
  export default {
    data: () => ({
      model: 1,
      items: Array.from(new Array(60).keys(), (value, index) => index + 1)
    })
  }
</script>

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any feature but make things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and breaking changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)

@TravisBuddy

TravisBuddy commented Apr 26, 2019

Copy link
Copy Markdown

Hey @FAKER-A,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 0c640df0-68d4-11e9-a1ab-3f769e34a7d0

@codecov

codecov Bot commented Apr 26, 2019

Copy link
Copy Markdown

Codecov Report

Merging #7079 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7079   +/-   ##
=======================================
  Coverage   85.43%   85.43%           
=======================================
  Files         298      298           
  Lines        7221     7221           
  Branches     1804     1804           
=======================================
  Hits         6169     6169           
  Misses        956      956           
  Partials       96       96
Impacted Files Coverage Δ
...ages/vuetify/src/components/VSelect/VSelectList.js 97.18% <ø> (ø) ⬆️
packages/vuetify/src/components/VList/VListTile.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7170d9a...e1120a6. Read the comment docs.

@codecov

codecov Bot commented Apr 26, 2019

Copy link
Copy Markdown

Codecov Report

Merging #7079 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7079   +/-   ##
=======================================
  Coverage   85.43%   85.43%           
=======================================
  Files         298      298           
  Lines        7221     7221           
  Branches     1804     1804           
=======================================
  Hits         6169     6169           
  Misses        956      956           
  Partials       96       96
Impacted Files Coverage Δ
...ages/vuetify/src/components/VSelect/VSelectList.js 97.18% <ø> (ø) ⬆️
packages/vuetify/src/components/VList/VListTile.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fbd20c...4baa042. Read the comment docs.

@nekosaur

Copy link
Copy Markdown
Member

Please fill in the missing sections in PR description

@FAKER-A

FAKER-A commented Apr 26, 2019

Copy link
Copy Markdown
Contributor Author

Please fill in the missing sections in PR description

thanks for reminding

My English is not very good, I hope you don't mind.

@dsseng dsseng changed the title VSelect:Fixes #6685 fix(VSelect): update selected color Apr 27, 2019
@dsseng
dsseng merged commit 8a5760c into vuetifyjs:master Apr 27, 2019
@dsseng

dsseng commented Apr 27, 2019

Copy link
Copy Markdown
Contributor

@FAKER-A Thank you for your contribution and interest in improving Vuetify! Make sure to join us in the Discord community.

@lock lock Bot locked as resolved and limited conversation to collaborators May 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug Report] Autocomplete selected item color no change

4 participants