Skip to content

fix(VMenu): skip elements with 0 or NaN z-index - #7532

Merged
johnleider merged 1 commit into
masterfrom
fix/5351-menu-zindex-safari
Jun 18, 2019
Merged

fix(VMenu): skip elements with 0 or NaN z-index#7532
johnleider merged 1 commit into
masterfrom
fix/5351-menu-zindex-safari

Conversation

@KaelWD

@KaelWD KaelWD commented Jun 16, 2019

Copy link
Copy Markdown
Member

fixes #5351

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any feature but make things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and breaking changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)

@KaelWD KaelWD self-assigned this Jun 16, 2019
@KaelWD KaelWD added this to the 1.5.x milestone Jun 16, 2019
@codecov

codecov Bot commented Jun 16, 2019

Copy link
Copy Markdown

Codecov Report

Merging #7532 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7532   +/-   ##
=======================================
  Coverage   85.43%   85.43%           
=======================================
  Files         298      298           
  Lines        7221     7221           
  Branches     1804     1804           
=======================================
  Hits         6169     6169           
  Misses        956      956           
  Partials       96       96
Impacted Files Coverage Δ
packages/vuetify/src/util/helpers.ts 90.84% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db94b73...43a0310. Read the comment docs.

@KaelWD KaelWD changed the title fix(VMenu): ignore elements with 0 or NaN z-index fix(VMenu): skip elements with 0 or NaN z-index Jun 16, 2019
@johnleider johnleider added the T: bug Functionality that does not work as intended/expected label Jun 18, 2019
@johnleider
johnleider merged commit df96de0 into master Jun 18, 2019
@johnleider
johnleider deleted the fix/5351-menu-zindex-safari branch June 18, 2019 15:43
@lock lock Bot locked as resolved and limited conversation to collaborators Jul 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

T: bug Functionality that does not work as intended/expected

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug Report] menu in toolbar in dialog is not visible in safari

2 participants