Skip to content

fix: ignore click outside if component is being destroyed - #8471

Merged
johnleider merged 1 commit into
stablefrom
fix/6976-clickoutside-after-destroy-backport
Aug 12, 2019
Merged

fix: ignore click outside if component is being destroyed#8471
johnleider merged 1 commit into
stablefrom
fix/6976-clickoutside-after-destroy-backport

Conversation

@KaelWD

@KaelWD KaelWD commented Aug 12, 2019

Copy link
Copy Markdown
Member

fixes #6976

(cherry picked from commit f7682af)

Backport of #8470

Markup:

Details
<template>
  <div class="text-center">
    <v-menu offset-y v-if="$route.name === 'Page 1'">
      <template v-slot:activator="{ on }">
        <v-btn
          color="primary"
          dark
          v-on="on"
        >
          Dropdown
        </v-btn>
      </template>
      <v-list>
        <v-list-item
          v-for="(item, index) in items"
          :key="index"
          @click=""
        >
          <v-list-item-title>{{ item.title }}</v-list-item-title>
        </v-list-item>
      </v-list>
    </v-menu>
    <v-btn to="/page2">go</v-btn>
    <v-btn to="/page1">go</v-btn>
  </div>
</template>

<script>
  export default {
    data: () => ({
      items: [
        { title: 'Click Me' },
        { title: 'Click Me' },
        { title: 'Click Me' },
        { title: 'Click Me 2' },
      ],
    }),
  }
</script>

This is cool btw: https://git.wiki.kernel.org/index.php/GitFaq#How_to_manually_resolve_conflicts_when_Git_failed_to_detect_rename.3F

@johnleider johnleider added this to the v1.5-lts milestone Aug 12, 2019
@johnleider johnleider added C: VMenu T: bug Functionality that does not work as intended/expected labels Aug 12, 2019
@johnleider
johnleider merged commit cf8cbb2 into stable Aug 12, 2019
@johnleider
johnleider deleted the fix/6976-clickoutside-after-destroy-backport branch August 12, 2019 19:49
@lock lock Bot locked as resolved and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

C: VMenu T: bug Functionality that does not work as intended/expected

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants