add_h3t_source() for tiled H3 data (#199) - #209
Merged
Merged
Conversation
5 tasks
Contributor
|
Bravo! Thank you so much for your detailed review and merge :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lands @bbest's #199 (H3 tiled source), rebased onto the current 0.5
mainwith conflicts resolved.Adds
add_h3t_source()— an R wrapper for theh3tiles://MapLibre protocol bundled inh3j-h3t— so H3 hex layers can be driven from a tiled{z}/{x}/{y}endpoint (one request per viewport) instead of loading a single monolithic H3J file. Includes Ben's five upstreamedh3j-h3tfixes (0.9.2 → 0.9.7) for MapLibre v3–v5, query-string tile URLs, empty tiles, and multiple sources per page / per compare side.Conflict resolution notes
The original PR predated the 0.5 slider/flowmap/compare work and conflicted in
maplibregl.jsandmaplibregl_compare.js:maplibregl.js— kept main's filter-registryset_filter(so the slider/legend filter composition is preserved) and layered Ben's newadd_h3t_sources/add_h3j_sourcesproxy handlers alongside it.maplibregl_compare.js— main has since addedgetLayerControlVisibility()/setLayerControlVisibility()helpers that already perform Ben'sgetLayer()pre-check (silencing the missing-layer error event) and support multi-map compare (sync more than 2 maps #204) and flowmap layers. Those supersede Ben's inline version, so the helpers were kept. Ben's h3t init + proxy handlers are retained.console.logthat survived from the PR's development commits.add_h3t_source()now ends withreturn(map)to match the package convention.Ben's authorship is preserved on the commit.
R CMD checkclean (0 errors / 0 warnings / 0 notes); both JS bindings passnode --check. Supersedes #199.Note: Mapbox parity (
addH3TSourceonmapboxgl.js) is still out of scope, as in the original PR.