Skip to content

Convert "layer" argument to "layer_id" in Shiny functions - #89

Closed
mhpob wants to merge 1 commit into
walkerke:mainfrom
mhpob:main
Closed

Convert "layer" argument to "layer_id" in Shiny functions#89
mhpob wants to merge 1 commit into
walkerke:mainfrom
mhpob:main

Conversation

@mhpob

Copy link
Copy Markdown

Response to #86.

There are a bunch of misc. Air formatting changes in there (sorry!), so here are the pertinent changes for your review:

@mhpob

mhpob commented Mar 28, 2025

Copy link
Copy Markdown
Author

@walkerke I'm opening this PR in draft as this line also contains a reference to "layer = layer". I'm unsure if this is referring to underlying JS (don't change) or the object (should probably change). If you could give me direction on this, I'll tie it up and submit the PR.

@walkerke

Copy link
Copy Markdown
Owner

@mhpob in that example, we are referring to the layer specifically as we add it to the map - so we won't want to change that / can leave that function untouched.

@mhpob
mhpob marked this pull request as ready for review March 31, 2025 15:10
@walkerke

Copy link
Copy Markdown
Owner

We ended up doing some edits that introduced a bunch of merge conflicts, so I ended up handling separately to streamline. I do appreciate the contribution though!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@mhpob@walkerke