Skip to content

feat: add row level security - #25

Open
matteyu wants to merge 13 commits into
arc-937/auth-passkeysfrom
arc-1133/row-level-security
Open

feat: add row level security#25
matteyu wants to merge 13 commits into
arc-937/auth-passkeysfrom
arc-1133/row-level-security

Conversation

@matteyu

@matteyumatteyu commented Mar 26, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Jira: https://communitylabs.atlassian.net/browse/ARC-1133?atlOrigin=eyJpIjoiN2U0M2UxMjQ0OTY0NGQ3YTkyYmRhODQ2YTI5MzlkM2YiLCJwIjoiaiJ9

  • Add row level security to tables via migration files
  • Added a condition for an authenticated prisma client

@vercel

vercelBot commented Mar 26, 2025•
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

NameStatusPreviewCommentsUpdated (UTC)
embed-api✅ Ready (Inspect)Visit Preview💬 Add feedbackMay 5, 2025 5:09am

@matteyumatteyu changed the title feat: add row level security[WIP] feat: add row level securityMar 26, 2025
@matteyumatteyu changed the title [WIP] feat: add row level securityfeat: add row level securityApr 2, 2025
@matteyu
matteyu requested review from Danziger and pawanpaudel93 and removed request for pawanpaudel93April 2, 2025 15:27
@matteyu
matteyu changed the base branch from arc-937/auth-passkeys to developmentApril 2, 2025 15:27
@matteyu
matteyu changed the base branch from development to arc-937/auth-passkeysApril 2, 2025 15:28
@matteyu
matteyuforce-pushed the arc-1133/row-level-security branch from 1cb83fa to 5de4eeeCompareApril 3, 2025 05:10
@matteyu
matteyu changed the base branch from arc-937/auth-passkeys to developmentApril 3, 2025 05:10
@matteyu
matteyuforce-pushed the arc-1133/row-level-security branch from aaf14e6 to 033e994CompareApril 3, 2025 05:21
@Danziger

Danziger commented Apr 3, 2025

Copy link
Copy Markdown
Contributor

@7i7o No need to update the embed-api SDK on the app for this one. After one more review we can merge it.

Danziger
Danziger reviewed Apr 3, 2025
View reviewed changes
Comment threadprisma/migrations/20250402214855_enable_rls/migration.sql Outdated
Danziger
Danziger reviewed Apr 3, 2025
View reviewed changes
Comment threadprisma/migrations/20250402214855_enable_rls/migration.sql Outdated
Danziger
Danziger approved these changes Apr 3, 2025
View reviewed changes

@DanzigerDanziger left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some policies can be refined but this can be improved on a new PR. Also, some discussions is needed around plans and usage.

pawanpaudel93
pawanpaudel93 reviewed Apr 4, 2025
View reviewed changes
Comment threadprisma/migrations/20250402214855_enable_rls/migration.sql Outdated
pawanpaudel93
pawanpaudel93 reviewed Apr 4, 2025
View reviewed changes
Comment threadprisma/migrations/20250402214855_enable_rls/migration.sql
pawanpaudel93
pawanpaudel93 approved these changes Apr 9, 2025
View reviewed changes

@pawanpaudel93pawanpaudel93 left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uTACK. This needs to be tested with our DB so it works without causing any issues.

@matteyu
matteyuforce-pushed the arc-1133/row-level-security branch from 5e5366d to 1647b13CompareApril 25, 2025 22:04
@wanderwalletwanderwallet deleted a comment from mattionavaApr 29, 2025
@matteyu

matteyu commented Apr 29, 2025

Copy link
Copy Markdown
ContributorAuthor

Complete flow with RLS: https://drive.google.com/file/d/1ZyT0P7026hgl4Z6-VNqP9hbchGOTRWoH/view?usp=drive_link

  • login tested
  • wallet creation tested
  • wallet backup tested
  • wallet restore tested

Danziger
Danziger reviewed Apr 30, 2025
View reviewed changes
Comment threadserver/context.ts
Danziger
Danziger reviewed Apr 30, 2025
View reviewed changes
Comment threadserver/routers/backup/registerRecoveryShare.ts Outdated
Danziger
Danziger reviewed Apr 30, 2025
View reviewed changes
Comment threadserver/routers/backup/registerRecoveryShare.ts
Danziger
Danziger reviewed Apr 30, 2025
View reviewed changes
Comment threadserver/routers/backup/registerRecoveryShare.ts Outdated
Danziger
Danziger reviewed Apr 30, 2025
View reviewed changes
Comment threadserver/routers/share-recovery/generateWalletRecoveryChallenge.ts
Danziger
Danziger reviewed Apr 30, 2025
View reviewed changes
Comment threadserver/routers/share-recovery/recoverWallet.ts Outdated
Danziger
Danziger reviewed Apr 30, 2025
View reviewed changes
Comment threadserver/routers/wallets/createPublicWallet.ts Outdated
Danziger
Danziger reviewed Apr 30, 2025
View reviewed changes
Comment threadserver/routers/wallets/createPublicWallet.ts Outdated
Danziger
Danziger reviewed Apr 30, 2025
View reviewed changes
Comment threadserver/utils/backup/backup.utils.ts Outdated
Danziger
Danziger reviewed Apr 30, 2025
View reviewed changes
Comment threadserver/utils/device-n-location/device-n-location.utils.ts
Danziger
Danziger reviewed Apr 30, 2025
View reviewed changes
Comment threadserver/utils/prisma/prisma-client.ts Outdated
Danziger
Danziger reviewed Apr 30, 2025
View reviewed changes
Comment threadserver/utils/user/user.utils.ts
Danziger
Danziger reviewed Apr 30, 2025
View reviewed changes
Comment threadserver/utils/validation/validation.utils.ts Outdated
Danziger
Danziger reviewed Apr 30, 2025
View reviewed changes
Comment threadserver/routers/share-recovery/generateWalletRecoveryChallenge.ts Outdated
Danziger
Danziger reviewed Apr 30, 2025
View reviewed changes
Comment threadserver/routers/work-shares/activateWallet.ts Outdated
Danziger
Danziger reviewed Apr 30, 2025
View reviewed changes
Comment threadserver/routers/work-shares/generateWalletActivationChallenge.ts Outdated
@matteyu
matteyu changed the base branch from development to arc-937/auth-passkeysMay 4, 2025 22:10
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pawanpaudel93pawanpaudel93pawanpaudel93 approved these changes
+1 more reviewer
@DanzigerDanzigerDanziger approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@matteyu@Danziger@pawanpaudel93