Skip to content

Task updates #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HelpfulSoft1207 merged 2 commits into from
Sep 10, 2026
Merged

Task updates #77

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8603ee9
task updates
AnSq Sep 10, 2026
36d8795
add test: task text should end with a period
AnSq Sep 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions sources/js/tasks.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,12 @@
}
]
},
{
"id": "daily_nightwave",
"title": "Nightwave",
"text": "Complete daily Nightwave acts.",
"icon": "NightwaveIconSimple.png"
},
{
"id": "daily_sortie",
"title": "Sortie",
Expand Down Expand Up @@ -159,7 +165,7 @@
{
"id": "daily_kim_parent",
"title": "KIM",
"text": "complete daily chats with protoframes",
"text": "complete daily chats with protoframes.",
"location": "Base of Operations",
"terminal": "POM-2 PC",
"icon": "Computer.png",
Expand Down Expand Up @@ -308,7 +314,7 @@
{
"id": "weekly_nightwave_complete",
"title": "Nightwave",
"text": "Complete relevant weekly Nightwave missions.",
"text": "Complete relevant weekly Nightwave acts.",
"icon": "NightwaveIconSimple.png"
},
{
Expand All @@ -320,7 +326,7 @@
{
"id": "weekly_ayatan",
"title": "Ayatan Treasure Hunt",
"text": "Complete Maroo's weekly mission for an Ayatan Sculpture",
"text": "Complete Maroo's weekly mission for an Ayatan Sculpture.",
"icon": "Maroo.png",
"location": "Maroo's Bazaar, Mars",
"npc": "Maroo"
Expand Down Expand Up @@ -458,11 +464,11 @@
"subtasks": [
{
"id": "weekly_iron_wake",
"title": "Paladino",
"title": "Palladino",
"text": "Trade Riven Slivers.",
"icon": "IconOmegaMod256.png",
"location": "Iron Wake, Earth",
"npc": "Paladino",
"npc": "Palladino",
"prereq": "The Chains of Harrow"
},
{
Expand Down
8 changes: 8 additions & 0 deletions sources/tests/tasks.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,14 @@ describe("valildate task definitions", () => {
}
});

describe("task text should end with a period", () => {
test.for(flatTasks)("$id", (t) => {
if (t.text) {
expect(t.text.slice(-1)).toEqual(".");
}
});
});

const cycle_keys_for_test = Object.keys(cycles).map((i) => [i]);

describe("verify equal `order` lengths", () => {
Expand Down