Skip to content

fix(tts,stt,version): unpinned websocket-client - #833

Merged
apaparazzi0329 merged 1 commit into
watson-developer-cloud:masterfrom
arne-kapell:master
Aug 7, 2023
Merged

fix(tts,stt,version): unpinned websocket-client#833
apaparazzi0329 merged 1 commit into
watson-developer-cloud:masterfrom
arne-kapell:master

Conversation

@arne-kapell

Copy link
Copy Markdown
Contributor

fixes#810 and adds support for up to latest websocket-client (1.6.1)

fixeswatson-developer-cloud#810 and adds support for up to latest websocket-client (1.6.1)
@CLAassistant

CLAassistant commented Aug 4, 2023

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #833 (8e340d2) into master (c08a117) will not change coverage.
The diff coverage is 100.00%.

@@ Coverage Diff @@## master #833 +/- ##
=======================================
Coverage 89.82% 89.82% =======================================
Files 19 19 Lines 31987 31987 =======================================
Hits 28732 28732 Misses 3255 3255 
Files ChangedCoverage Δ
ibm_watson/websocket/recognize_listener.py24.57% <100.00%> (ø)
ibm_watson/websocket/synthesize_listener.py34.04% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@apaparazzi0329
apaparazzi0329 self-requested a review August 7, 2023 15:48

@apaparazzi0329apaparazzi0329 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for your contribution!

@apaparazzi0329
apaparazzi0329 merged commit 75432a6 into watson-developer-cloud:masterAug 7, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pinned down websocket-client==1.1.0

4 participants

@arne-kapell@CLAassistant@codecov-commenter@apaparazzi0329