Skip to content

chore(contracts): correct false TESTING.md → declared absence (no test command) - #35

Merged
yakimoto merged 1 commit into
mainfrom
contract-files/fix-false-testing
Aug 30, 2026
Merged

chore(contracts): correct false TESTING.md → declared absence (no test command)#35
yakimoto merged 1 commit into
mainfrom
contract-files/fix-false-testing

Conversation

@yakimoto

@yakimotoyakimoto commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

chore(contracts): correct a false TESTING.md → declared absence

What was wrong

The contract-files rollout (E5-FLEET, 2026-08-30) landed a TESTING.md here whose fenced test-contract block declared entry: npm test and a suite running npm test. This repository has no npm test script (re-verified live at clone time: package.json absent or without scripts.test), so the contract named a command that does not exist. The scaffold in contract-files ≤ v0.5.1 rendered that line unconditionally; bot reviewers caught it on the held PRs, and a fleet-wide census found 73 of 166 repos in the same state. A contract that lies is worse than no contract: in observe mode the Stop gate just logs, in block mode it would refuse every close on a command that cannot run.

What this does

  • Removes the false TESTING.md (the scaffold at contract-files v0.5.2 now REFUSES to render a test-contract when no test command is inferable — no-test-command — and that refusal was exercised here, not assumed).
  • Adds .contracts-absent.json declaring test-contract absent with reason no-test-command. That record is what the fleet census reads: this repo is now explicitly without a test contract, rather than silently missing one or falsely carrying one. When a real test command is added, delete the record and run contracts init --families test-contract.
  • PERMISSIONS.md from the same rollout is untouched — it was correct.

Guarantees

One reversible commit; reverting it restores the rollout state exactly. Nothing executes; no gate mode changes. Body kept above the fleet's measured 1,200-character PR floor deliberately.


View with [code]smithAutofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.


Note

Low Risk
Documentation and contract-metadata only; no runtime, gate mode, or test execution changes.

Overview
Replaces a misleading test contract with an explicit “no test contract” declaration because the removed TESTING.md fenced block pointed at npm test / suite commands that do not exist in this repo.

The PR deletesTESTING.md entirely and adds.contracts-absent.json recording test-contract as absent with reason no-test-command, so fleet tooling treats the repo as intentionally without a machine test contract rather than carrying a broken one that could fail gates in block mode.

Reviewed by Cursor Bugbot for commit 580394d. Bugbot is set up for automated code reviews on this repo. Configure here.

Review in cubic

Summary by Sourcery

Replace the misleading test contract with an explicit no-test-command declaration.

Bug Fixes:

  • Remove the invalid test contract that referenced a nonexistent test command.

Enhancements:

  • Explicitly declare the repository's absence of a test contract due to having no inferable test command.

@codeant-ai

Copy link
Copy Markdown

Your free trial PR review limit of 300 PRs has been reached. Please upgrade your plan to continue using CodeAnt AI.

@qodo-code-review

Copy link
Copy Markdown

ⓘ Qodo reviews are paused because your workspace is out of credits. Ask your workspace admin to add credits to resume reviews. Manage billing

@cursor

cursorBot commented Aug 30, 2026

Copy link
Copy Markdown

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: serverGenReqId_0978702c-ec37-4e64-8dd3-a5d8cf923f33)

@sourcery-aisourcery-aiBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @yakimoto, you've used your own review budget of 250,000 diff characters for the last 7 days.

You can request another review in 19 hours and 30 minutes by commenting @sourcery-ai review. Upgrade to get a review now.

@sourcery-ai

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Corrects the contract metadata to reflect that this repository has no inferable test command: the invalid TESTING.md is removed and absence is explicitly recorded for fleet census and future contract regeneration.

File-Level Changes

ChangeDetailsFiles
Replaces a misleading generated test contract with an explicit declaration that no test contract exists.
  • Deletes TESTING.md, removing the nonexistent npm test entry and suite.
  • Adds .contracts-absent.json recording test-contract as absent with reason no-test-command.
  • Leaves the valid permissions contract unchanged.
TESTING.md
.contracts-absent.json

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@coderabbitai

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 17 minutes.

View limit details

Limit details: You’ve used the included review currently available. Your 94 included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 7ddecbc0-c31f-4391-8cdf-9fe70ff5016b

📥 Commits

Reviewing files that changed from the base of the PR and between e758d2d and 580394d.

📒 Files selected for processing (2)
  • .contracts-absent.json
  • TESTING.md

Comment @coderabbitai help to get the list of available commands.

@gitar-bot

gitar-botBot commented Aug 30, 2026

Copy link
Copy Markdown

Note

Automatic reviews are paused because your team has used its included automatic processing for this billing period (headroom scales with your seat count). You can still comment "Gitar review" to run one anytime, and automatic reviews resume on their own by September 1. Add seats for more headroom.
Learn more

Code Review✅ Approved

Replaces the misleading TESTING.md test contract (which referenced a nonexistent npm test command) with an explicit .contracts-absent.json declaration marking test-contract as absent. This ensures fleet tooling treats the repo as intentionally without a test contract rather than carrying a broken one that could fail gates in block mode. No issues found.

Options

Display: compact → Showing less information.

Comment with these commands to change the behavior for this request:

Compact
gitar display:verbose 

Was this helpful? React with 👍 / 👎 | Gitar

@macroscopeapp

Copy link
Copy Markdown

Approvability

Verdict: Would Approve

Macroscope's review found this PR approvable — This is a two-file contract-metadata cleanup that removes a misleading test instruction and records its intentional absence for tooling. It does not modify Python code, package behavior, customer-facing APIs, or production workflows.

Not approved because:

  • Credit balance exhausted. Approvability relies on correctness review in order to determine eligibility

Review your spending limits in Billing settings. You can add or adjust custom eligibility rules. Learn more.

@yakimoto
yakimoto merged commit 2d1514c into mainAug 30, 2026
23 checks passed
@yakimoto
yakimoto deleted the contract-files/fix-false-testing branch August 30, 2026 03:14
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@yakimoto