[WIP] C API - #83
Conversation
| @@ -0,0 +1,146 @@ | |||
| #pragma once | |||
There was a problem hiding this comment.
It might be a good idea to use the standard C approach here, as #pragma once appears to be compiler dependent..
There was a problem hiding this comment.
If a compiler doesn't support pragma once, the rest of the stack won't compile either. This is a conscious design decision. Show me a modern compiler that doesn't support pragma once, and we can reconsider that choice. From this list, it seems that everything that we can reasonably support supports this paradigm
https://en.m.wikipedia.org/wiki/Pragma_once
NB, This may preclude some embedded compilers/platforms, but the fact that we're doing dynamic memory management (i.e. calls to malloc/new) already precludes them - if there's a reason to target these platforms, we'd have to do a rather large overhaul of everything and pragma once would be the least of our problems.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
| @@ -0,0 +1,146 @@ | |||
| #pragma once | |||
There was a problem hiding this comment.
If a compiler doesn't support pragma once, the rest of the stack won't compile either. This is a conscious design decision. Show me a modern compiler that doesn't support pragma once, and we can reconsider that choice. From this list, it seems that everything that we can reasonably support supports this paradigm
https://en.m.wikipedia.org/wiki/Pragma_once
NB, This may preclude some embedded compilers/platforms, but the fact that we're doing dynamic memory management (i.e. calls to malloc/new) already precludes them - if there's a reason to target these platforms, we'd have to do a rather large overhaul of everything and pragma once would be the least of our problems.
…rature RSCAL getter + UT
susilehtola
commented
Sep 25, 2023
via email
I've been staring at this and can't find the difference...? Neither can I, that’s my point. I don’t see any difference in these functions. The first one is different, the later ones are identical except the function name… |
wavefunction91
commented
Sep 25, 2023
@susilehtola Ohhh, I see. That was just because it wasn't fleshed out - the differences are apparent now |
No description provided.