You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If an argument to a contract method is a string which can be converted to number (like "1"), Utils::toHex() does this conversion. Also if sting starts with '0x' it will be stripped, which may be not expected behaviour.
The reason will be displayed to describe this comment to others. Learn more.
Hi @pash7ka
If you pass 0x prefixed string, it will strip the zero.
I think it might not be expected behavior.
Maybe it better to change behavior in Util::toHex.
Hi @sc0Vu
With my fix 0x prefix will stay intact. One example of such string is tx hash, which somebody may want to store in the contract as a string.
I agree, that fixing this in Util::toHex would be preffered, but to do it properly we may need to add additional parameter to Util::toHex with the type of input. It's a major rewrite of this function, which i decided to leave up to you.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If an argument to a contract method is a string which can be converted to number (like "1"),
Utils::toHex()does this conversion. Also if sting starts with '0x' it will be stripped, which may be not expected behaviour.