Skip to content

Feature improves transmatrix - #30

Merged
kalwalt merged 3 commits into
devfrom
feature-improves-transmatrix
Jan 14, 2025
Merged

Feature improves transmatrix#30
kalwalt merged 3 commits into
devfrom
feature-improves-transmatrix

Conversation

@kalwalt

@kalwalt kalwalt commented Nov 23, 2024

Copy link
Copy Markdown
Member

This pull request includes several changes to the WebARKit codebase, focusing on adding support for different types of blur and improving logging and tracking functionality. The most important changes include the introduction of a BLUR_TYPE enum, modifications to the processFrameData method to support different blur types, and updates to the tracking information handling.

Blur type support:

  • Introduced BLUR_TYPE enum to specify different types of blur: MEDIAN_BLUR, BOX_BLUR, and NONE_BLUR. (WebARKit/WebARKitTrackers/WebARKitOpticalTracking/include/WebARKitTrackers/WebARKitOpticalTracking/WebARKitEnums.h)
  • Modified processFrameData method signatures and implementations to accept BLUR_TYPE instead of a boolean for enabling blur. (WebARKit/WebARKitManager.cpp, WebARKit/WebARKitTrackers/WebARKitOpticalTracking/WebARKitTracker.cpp, WebARKit/WebARKitTrackers/WebARKitOpticalTracking/include/WebARKitTrackers/WebARKitOpticalTracking/WebARKitTracker.h, WebARKit/include/WebARKitManager.h) [1] [2] [3] [4] [5] [6]

Logging improvements:

  • Added detailed logging for the size of keypoints and descriptors in the WebARKitTrackerImpl class. (WebARKit/WebARKitTrackers/WebARKitOpticalTracking/WebARKitTracker.cpp) [1] [2]
  • Added logging for color space conversion steps in the convert2Grayscale function. (WebARKit/WebARKitTrackers/WebARKitOpticalTracking/include/WebARKitTrackers/WebARKitOpticalTracking/WebARKitUtils.h)

Tracking information updates:

  • Added updateTrackable method to the WebARKitPatternTrackingInfo class to update transformation matrices. (WebARKit/WebARKitPattern.cpp, WebARKit/include/WebARKitPattern.h) [1] [2]
  • Changed the getPoseMatrix2 method to return the updated transformation matrix. (WebARKit/WebARKitTrackers/WebARKitOpticalTracking/WebARKitTracker.cpp)
  • Called the updateTrackable method during the tracking process to ensure the transformation matrix is updated. (WebARKit/WebARKitTrackers/WebARKitOpticalTracking/WebARKitTracker.cpp)

kalwalt added 3 commits July 9, 2024 16:48
- bunch of debug logs
- removing enableBlur bool variable because not necessary anymore (commit files previously missed)
@kalwalt kalwalt added enhancement New feature or request C/C++ code concerning the C/C++ code design and improvements Emscripten labels Nov 23, 2024
@kalwalt kalwalt self-assigned this Nov 23, 2024
@kalwalt
kalwalt merged commit 6611957 into dev Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C/C++ code concerning the C/C++ code design and improvements Emscripten enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant