docs(bench): add a Current status table, realign three stale verdicts - #167
Merged
Conversation
bench/README.md had grown into a 677-line chronological log: six sections, each with its own status box. Working out "where do things stand today" required reading all of them and assembling the answer, and every new measurement had to be threaded into six places -- which is exactly how it drifted out of date. Added a Current status table at the top, measured over four full-suite runs on merged dev (after #159, #165 and #166). It states plainly that the sections below are the historical record and their numbers are NOT updated, so future measurements touch one table instead of six sections. Three verdicts were stale against the merged-dev measurements: - yape06 was recorded as "unchanged, still open" at 1.14-1.47. On merged dev it measures ~1.04 across four runs. Flagged as resolved but explicitly UNEXPLAINED: #166's alias alone did not produce this, so something in the combination of the three fixes did, and it is not credited to any one of them. - get_gaussian_kernel size 7 was described as "mostly below floor", with a following sentence asserting everything else sat at or below ~1.15x. The later series puts it at 1.15-1.23, four of four favouring jsfeat -- at or just above the floor, not below it. Both spots corrected and it is carried as open. - lu_solve's verdict was right but its numbers were superseded: 1.43-1.49 with a +/-0.03 spread, now the tightest signal in the suite, tighter than YAPE ever was. It has never been profiled, and #159 predicted in advance that its fix could not explain it. Documentation only -- no source or bench code touched. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a single “Current status” summary at the top of bench/README.md so readers can see today’s benchmark findings without re-reading multiple historical sections, and realigns a few stale narrative verdicts to match recent measurements on merged dev.
Changes:
- Adds a “Current status” table summarizing four full-suite runs on merged
dev, and clarifies that the rest of the document is historical (not continuously updated). - Updates the YAPE section framing and the
lu_solve/get_gaussian_kernelsize 7 notes to reflect newer measurements and revised verdicts.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
bench/README.mdhad grown into a 677-line chronological log: six sections, each with its own status box. Answering "where do things stand today?" meant reading all six and assembling the answer — and every new measurement had to be threaded into six places, which is exactly how it drifted out of date.What
A
Current statustable at the top, measured over four full-suite runs on mergeddev(after #159, #165, #166 — idle machine, warm-up discarded). It states plainly that the sections below are the historical record and their numbers are not updated, so future measurements touch one table instead of six sections.linalg.lu_solvehomography2d.check_subsetnew matmath()affine2d.run3 ptsmath.get_gaussian_kernelsize 7yape06/yape/invert_3x3/svd_*Three stale verdicts corrected
yape06was recorded as "unchanged, still open" at 1.14–1.47. On mergeddevit measures ~1.04 across four runs. Marked resolved — but explicitly unexplained: #166's alias alone did not produce this (that PR measured and reported no benefit foryape06), so something in the combination of the three fixes did. Recorded as unexplained rather than credited to any one change.get_gaussian_kernelsize 7 was described as "mostly below floor", with the next sentence asserting everything else sat at or below ~1.15x. The later series puts it at 1.15–1.23, four of four favouring jsfeat — at or just above the floor, not below it. Both spots corrected; carried as open.lu_solve's verdict was right but its numbers were superseded: now 1.43–1.49 with a ±0.03 spread, tighter than YAPE ever was. It has never been profiled, and #159 predicted in advance that its fix could not explain it (lu_solveconstructs no internalmatrix_t).Scope
Documentation only — no source or bench code touched.
npm test265 passed,license-check93 files clean.Note:
dist/andtypes/show local modifications from the verification build on this machine; they are deliberately not included here.Refs #86.
🤖 Generated with Claude Code